The block index (CBlockTreeDB) is required to write and read blocks, so move it to blockstorage
Move CBlockTreeDB to node/blockstorage #22242
pull maflcko wants to merge 4 commits into bitcoin:master from maflcko:2106-blockstorage changing 9 files +147 −122-
maflcko commented at 6:03 PM on June 14, 2021: member
- maflcko added the label Refactoring on Jun 14, 2021
- maflcko added the label Block storage on Jun 14, 2021
-
practicalswift commented at 8:41 PM on June 14, 2021: contributor
Concept ACK
-
DrahtBot commented at 8:53 PM on June 14, 2021: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #23581 (Move BlockManager to node/blockstorage by MarcoFalke)
- #23517 (scripted-diff: Move miner to src/node by MarcoFalke)
- #22932 (Guard CBlockIndex::nStatus by cs_main, require GetBlockPos/GetUndoPos to hold cs_main by jonatack)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- bitcoin deleted a comment on Jun 16, 2021
-
theStack commented at 2:32 PM on June 18, 2021: contributor
Concept ACK
- DrahtBot added the label Needs rebase on Jun 23, 2021
- maflcko force-pushed on Jun 29, 2021
- DrahtBot removed the label Needs rebase on Jun 29, 2021
- maflcko marked this as a draft on Jun 29, 2021
- maflcko force-pushed on Jul 20, 2021
-
fanquake commented at 3:02 AM on November 16, 2021: member
Concept ACK - want to rebase/fixup this?
- maflcko force-pushed on Nov 23, 2021
-
fa27a459bb
Move ~BlockManager impl to cpp file
This avoids compile errors in future commits.
-
fad86b74b5
move-only: Move CBlockTreeDB to node/blockstorage
Can be reviewed with --color-moved=dimmed-zebra
-
faea2f78d8
fixup style of moved code
Can be reviewed with --ignore-all-space --word-diff-regex=.
-
fad4d81625
refactor: Remove dbwrapper header from blockstorage header
There is no need to expose the internals in the header when only the blockstorage implementation (and txindex for historical reasons) care about them.
- maflcko force-pushed on Nov 23, 2021
- maflcko marked this as ready for review on Nov 23, 2021
- DrahtBot added the label Needs rebase on Nov 26, 2021
-
DrahtBot commented at 9:14 AM on November 26, 2021: contributor
<!--cf906140f33d8803c4a75a2196329ecb-->
🐙 This pull request conflicts with the target branch and needs rebase.
<sub>Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".</sub>
-
DrahtBot commented at 1:06 PM on March 21, 2022: contributor
<!--13523179cfe9479db18ec6c5d236f789-->There hasn't been much activity lately and the patch still needs rebase. What is the status here?
- Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
- Is it no longer relevant? ➡️ Please close.
- Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.
- maflcko closed this on Jul 22, 2022
- maflcko deleted the branch on Jul 22, 2022
- bitcoin locked this on Jul 22, 2023
- bitcoin unlocked this on Aug 1, 2023
- maflcko removed the label Needs rebase on Aug 1, 2023
- fanquake referenced this in commit ecab855838 on Sep 5, 2023
- bitcoin locked this on Jul 31, 2024
