system: skip trying to set the locale on NetBSD #22390

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:netbsd_dont_set_locale changing 1 files +1 −1
  1. fanquake commented at 3:14 am on July 2, 2021: member

    Just treat it the same as the other BSDs.

    Fixes #17379.

  2. system: skip trying to set the locale on NetBSD
    Just treat it the same as the other BSDs.
    
    Fixes #17379.
    fdd71448e7
  3. fanquake added the label Utils/log/libs on Jul 2, 2021
  4. theStack commented at 8:47 am on July 3, 2021: member
    Concept ACK
  5. tryphe commented at 3:59 am on August 1, 2021: contributor

    Concept ACK

    This change matches the intention of the comment above the changed line.

  6. laanwj commented at 7:15 am on September 2, 2021: member

    I wonder at some point it wont make more sense to make this override Linux specific, “instead of all UNIXy systems-except-BSDs and MacOS”.

    Anyhow, Code review ACK fdd71448e78f442ffd93a3a3398a5062eaba9f1b This is a valid solution, just not nice to keep extending this list forever, there are so many BSDs.

  7. practicalswift commented at 2:14 pm on September 4, 2021: contributor
    cr ACK fdd71448e78f442ffd93a3a3398a5062eaba9f1b
  8. fanquake commented at 5:50 am on September 9, 2021: member

    This is a valid solution, just not nice to keep extending this list forever, there are so many BSDs.

    Going to merge this for now. Agree that we could rework how this is done in future.

  9. fanquake merged this on Sep 9, 2021
  10. fanquake closed this on Sep 9, 2021

  11. fanquake deleted the branch on Sep 9, 2021
  12. fanquake locked this on Sep 9, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 21:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me