LevelDB build bugfix #2243

pull luke-jr wants to merge 2 commits into bitcoin:master from luke-jr:bugfix_leveldb changing 2 files +12 −8
  1. luke-jr commented at 3:59 PM on January 30, 2013: member
    • Bugfix: LevelDB: Use "xCXXFLAGS" variable to avoid user-defined CXXFLAGS from clobbering necessary compiler options
  2. sipa commented at 4:08 PM on January 30, 2013: member

    ACK if pulltester & gitian are happy with this.

  3. gmaxwell commented at 1:42 AM on February 5, 2013: contributor

    Ahh.. without this non-default cflags break the build. Where'd pulltester go?

  4. sipa commented at 9:37 AM on February 5, 2013: member

    @TheBlueMatt can you force a pulltester run on this pullreq?

  5. gavinandresen commented at 3:27 PM on February 5, 2013: contributor

    ACK.

    Although I think leveldb/libleveldb.a should probably depend on FORCE, so if bug-fixes are made to leveldb source files we don't have to make clean to pick up the changes.

  6. luke-jr commented at 3:41 PM on February 5, 2013: member

    @gavinandresen That sounds like a good idea to me. Shall I add it to this pullreq?

  7. luke-jr commented at 1:42 AM on February 9, 2013: member

    Amended to fix gitian spec to use standard CXXFLAGS for -frandom-seed

  8. BitcoinPullTester commented at 7:47 PM on February 9, 2013: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/2effd4162b45a8e99529797e403efc05bf341864 for binaries and test log.

  9. gavinandresen commented at 6:48 PM on February 15, 2013: contributor

    Testing this... doesn't fix the problem, the -Qt build is non-deterministic.

    Also, I don't like the extensive changes to the leveldb/Makefile, it will make merging upstream changes harder.

    I'm testing an alternative that cherry-picks some of the changes here, but doesn't touch anything in leveldb/ (passes CXXFLAGS in OPT; LDFLAGS is irrelevant, because we're building leveldb .a's).

  10. luke-jr commented at 1:14 AM on February 16, 2013: member

    Closing, mostly superceded by #2311

  11. luke-jr closed this on Feb 16, 2013
  12. Bugfix: makefile.linux-mingw: Fix so passed CXXFLAGS/LDFLAGS work correctly 7e2d850b12
  13. luke-jr commented at 5:25 AM on February 19, 2013: member

    Reopening with one remaining fix that wasn't in #2311

  14. luke-jr reopened this on Feb 19, 2013
  15. Bugfix: makefile.unix: Honour BOOST_LIB_SUFFIX on boost_unit_test_framework 3a9c2d51e1
  16. BitcoinPullTester commented at 1:57 AM on February 25, 2013: none

    Automatic sanity-testing: WARNING, see http://jenkins.bluematt.me/pull-tester/3a9c2d51e12fcf321daa78303e38c725b6477b66 for binaries and test log.

    This pull decreases total test coverage, please add unit tests to test all new code and help us add test cases for existing code. Coverage report can be found at http://jenkins.bluematt.me/pull-tester/3a9c2d51e12fcf321daa78303e38c725b6477b66/bitcoin/src/total.coverage/

  17. jgarzik commented at 12:04 AM on April 9, 2013: contributor

    ACK

  18. gavinandresen referenced this in commit f49992d983 on Apr 9, 2013
  19. gavinandresen merged this on Apr 9, 2013
  20. gavinandresen closed this on Apr 9, 2013
  21. laudney referenced this in commit 787b20c797 on Mar 19, 2014
  22. luke-jr deleted the branch on Oct 19, 2014
  23. DrahtBot locked this on Sep 8, 2021
Contributors
luke-jrsipagmaxwellgavinandresenBitcoinPullTesterjgarzik
Linked (view graph)
#2241 Support for building against system LevelDB#2288 Windows build not gitian-build-reproducible
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 15:16 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me