ResendWalletTransactions() sends transactions which were long ago included in the blockchain #2445

rebroad commented at 12:36 PM on April 2, 2013: contributor

My bitcoin-qt from the latest master is still sending transactions to the network which were included a block in the blockchain almost a year ago.

sipa commented at 7:04 PM on April 2, 2013: member

Are you synchronized and the transactions shown confirmed?

rebroad commented at 2:38 PM on April 8, 2013: contributor

@sipa yes

rebroad commented at 5:05 AM on May 12, 2013: contributor

looks like I'm going to have to issue the patch for this one myself...

gmaxwell commented at 5:30 AM on May 12, 2013: contributor

Seeing #2122 ... are you talking about initial block download here?? That isn't at all clear from the above.

sipa commented at 8:47 AM on May 12, 2013: member

ResendWalletTransactions() shouldn't be called during IBD at all...

rdponticelli commented at 1:16 PM on May 12, 2013: contributor

It shouldn't. Unless there is something wrong on #2259

rebroad commented at 2:31 AM on May 13, 2013: contributor

This occurs when the node has downloaded the most recently mined block.

rdponticelli commented at 4:24 PM on May 17, 2013: contributor

I can't reproduce this. Reindexing and forcing a IBD on a used wallet seems to work as expected on my tests. @rebroad: can you explain more thoroughly how you're triggering this?

rebroad commented at 6:39 AM on December 20, 2013: contributor

@rdponticelli I'm just running bitcoin-qt as normal. It's retransmitting two old transactions whenever it runs ResendWalletTransactions(). I see this by the fact that it shows up in debug.log, and then shortly after the connected nodes request these old transactions.

laanwj commented at 7:35 AM on December 20, 2013: member

@rebroad Can you debug why the retransmission logic decides to broadcast them? I have the suspicion that they're part of vtxPrev of some other transaction that was included long ago.

In CWalletTx::RelayWalletTransactions ( https://github.com/bitcoin/bitcoin/blob/master/src/wallet.cpp#L900 ) you'll see that it will transmit vtxPrevs without checking if the transaction itself should be broadcasted.

rebroad commented at 3:10 AM on February 27, 2014: contributor

@laanwj Sorry for the delay in replying. I'm not seeing this happen any more since using newer code, so it looks like something fixed it.

cozz commented at 11:47 AM on March 6, 2014: contributor

@rebroad so you can close this issue?

laanwj commented at 12:25 PM on March 6, 2014: member

The recent removal of vfSpent probably solved this; no longer are parent transactions of old transactions re-transmitted.

laanwj closed this on Mar 6, 2014

MarcoFalke locked this on Sep 8, 2021