Signrawtransaction shouldn't require redeemScript for non-p2sh txins. #2264

1. 
   gmaxwell commented at 4:02 AM on February 2, 2013: contributor

   The redeemScript functionality broke plain offline signing, this change makes it only look for that parameter when signing a p2sh input.

2. Signrawtransaction shouldn't require redeemScript for non-p2sh txins.

   The redeemScript functionality broke plain offline signing, this
   change makes it only look for that parameter when signing a p2sh
   input.

   21c6d3aead
3. 
   gmaxwell commented at 4:03 AM on February 2, 2013: contributor

   Marked as 0.8 milestone because it's a pretty irritating regression. (I hadn't noticed until now because my normal offline signer is offline and thus isn't running the very latest bitcoind)

4. 
   petertodd commented at 7:49 AM on February 2, 2013: contributor

   ACK

   Thanks, I ran into this myself a few times.

   Note for anyone testing this the bug is only a problem when a txin is unknown to bitcoin, IE not in the mempool or blockchain, and therefore the scriptPubKey has to be provided explicitly.

5. in src/rpcrawtransaction.cpp:None in 21c6d3aead

    420 | @@ -421,7 +421,7 @@ Value signrawtransaction(const Array& params, bool fHelp)
    421 |  
    422 |              Object prevOut = p.get_obj();
    423 |  
    424 | -            RPCTypeCheck(prevOut, map_list_of("txid", str_type)("vout", int_type)("scriptPubKey", str_type)("redeemScript",str_type));
    425 | +            RPCTypeCheck(prevOut, map_list_of("txid", str_type)("vout", int_type)("scriptPubKey", str_type));
   

   ---

   ---

   

   gavinandresen commented at 10:20 PM on February 2, 2013:

   ACK changing this line. But I believe the only other line of code you need for this patch is one additional RPCTypeCheck right here:

   RPCTypeCheck(prevOut, map_list_of("redeemScript",str_type), true);
   

   The rest of the existing code should then Do The Right Thing. The third arg to RPCTypeCheck will make redeemScript optional...

6. 
   BitcoinPullTester commented at 2:35 AM on February 5, 2013: none

   Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/21c6d3aead31ba80af060749ba55c1aee9bf2cca for binaries and test log.

7. gavinandresen referenced this in commit 817c44a00d on Feb 6, 2013
8. gavinandresen merged this on Feb 6, 2013
9. gavinandresen closed this on Feb 6, 2013

   ---

10. laudney referenced this in commit 4c17202798 on Mar 19, 2014
11. DrahtBot locked this on Sep 8, 2021

Milestone
0.8.0