Signrawtransaction shouldn't require redeemScript for non-p2sh inputs #2281

1. 
   gavinandresen commented at 5:54 PM on February 6, 2013: contributor

   The redeemScript functionality broke plain offline signing, this change makes it only look for that parameter when signing a p2sh input.

   Shorter version of #2264

   Tested by creating two chained, not-broadcast raw transactions, verifying that not providing redeemScript for the second fails without this change, succeeds with this change.

2. Signrawtransaction shouldn't require redeemScript for non-p2sh inputs

   The redeemScript functionality broke plain offline signing, this
   change makes it only look for that parameter when signing a p2sh
   input.
   
   Shorter version of https://github.com/bitcoin/bitcoin/pull/2264

   a591f10dbf
3. 
   gmaxwell commented at 5:56 PM on February 6, 2013: contributor

   I don't think that will give you a useful error message when you need one but don't provide it.

4. 
   gavinandresen commented at 6:02 PM on February 6, 2013: contributor

   Excellent point, gmaxwell. ACK on 2264 over this one.

5. gavinandresen closed this on Feb 6, 2013

   ---

6. gavinandresen deleted the branch on Feb 6, 2013
7. DrahtBot locked this on Sep 8, 2021

Milestone
0.8.0