doc: Fix RPC result documentation #22798

Fix:

• Incorrectly named fields
• Add missing ones
• Add missing optional flag

Wow. Concept ACK.

If RPC result documentation is fixed in bulk, maybe this can be added: https://github.com/bitcoin/bitcoin/pull/22430/

Concept ACK

@prayank23 My plan is to auto-generate the RPC examples, so that such issues are impossible. See #22799 for the meta issue.

For reference, if someone wants to export the RPC docs to produce a rendered diff, the following patch might be useful:

(dump_dir is a directory created by git init)

diff --git a/src/rpc/server.cpp b/src/rpc/server.cpp
index cf80b08b96..6c6a71c6e4 100644
--- a/src/rpc/server.cpp
+++ b/src/rpc/server.cpp
@@ -95,7 +95,7 @@ std::string CRPCTable::help(const std::string& strCommand, const JSONRPCRequest&
     {
         const CRPCCommand *pcmd = command.second;
         std::string strMethod = pcmd->name;
-        if ((strCommand != "" || pcmd->category == "hidden") && strMethod != strCommand)
+        if ((strCommand != "") && strMethod != strCommand)
             continue;
         jreq.strMethod = strMethod;
         try
diff --git a/test/functional/rpc_help.py b/test/functional/rpc_help.py
index de21f43747..753ee771ad 100755
--- a/test/functional/rpc_help.py
+++ b/test/functional/rpc_help.py
@@ -100,7 +100,7 @@ class HelpRpcTest(BitcoinTestFramework):
         # command titles
         titles = [line[3:-3] for line in node.help().splitlines() if line.startswith('==')]
 
-        components = ['Blockchain', 'Control', 'Generating', 'Mining', 'Network', 'Rawtransactions', 'Util']
+        components = ['Blockchain', 'Control', 'Generating', 'Hidden', 'Mining', 'Network', 'Rawtransactions', 'Util']
 
         if self.is_wallet_compiled():
             components.append('Wallet')
@@ -116,7 +116,8 @@ class HelpRpcTest(BitcoinTestFramework):
     def dump_help(self):
         dump_dir = os.path.join(self.options.tmpdir, 'rpc_help_dump')
         os.mkdir(dump_dir)
-        calls = [line.split(' ', 1)[0] for line in self.nodes[0].help().splitlines() if line and not line.startswith('==')]
+        dump_dir = '/tmp/temp_git/' ##HACK
+        calls = [line.split(' ', 1)[0].split('|', 1)[0] for line in self.nodes[0].help().splitlines() if line and not line.startswith('==')]
         for call in calls:
             with open(os.path.join(dump_dir, call), 'w', encoding='utf-8') as f:
                 # Make sure the node can generate the help at runtime without crashing

<!--e57a25ab6845829454e8d69fc972939a-->

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

<!--174a7506f384e20aa4161008e828411d-->

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #22650 (Remove -deprecatedrpc=addresses flag and corresponding code/logic by mjdietzx)
• #22558 (psbt: Taproot fields for PSBT by achow101)
• #22525 (docs: Update the explainer text for the listunspent RPC by Fonta1n3)
• #22016 (rpc: add period_start to version bits statistics by Sjors)
• #21283 (Implement BIP 370 PSBTv2 by achow101)
• #19888 (rpc, test: Improve getblockstats for unspendables by fjahr)
• #19002 (docs: Document that 'fee' is unavailable when there are non-wallet inputs by shesek)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Properly fixed with the comment integration for clear and understandable codebase

Concept ACK

Concept ACK

ACK fa1d3ddaa35424ce92a1d3c31aa7a94787811281 - Clearly this is a big improvement, some of the docs here are flat out wrong.

Force pushed to reply to feedback

Failing CI can be ignored

ACK fa10fbc6658fb8d87118cd550e4de406dca45f23