ci: Enable the gui in the tsan build #22815

1. 
   hebasto commented at 5:47 am on August 27, 2021: member

   This PR is a reincarnation of #19162.
2. hebasto added the label Tests on Aug 27, 2021
3. in depends/packages/qt.mk:143 in 7cb003f005 outdated

   139@@ -140,7 +140,11 @@ $(package)_config_opts_linux += -no-feature-vulkan
   140 $(package)_config_opts_linux += -dbus-runtime
   141 $(package)_config_opts_arm_linux += -platform linux-g++ -xplatform bitcoin-linux-g++
   142 $(package)_config_opts_i686_linux  = -xplatform linux-g++-32
   143+ifneq (,$(findstring clang++ -stdlib=libc++,$($(1)_cxx)))
   

   ---

   ---

   

   laanwj commented at 2:31 pm on August 27, 2021:

   I don’t think it’s correct to assume clang++ exists here, as well as is the compiler that is used to compile qt?

   ---

   

   laanwj commented at 2:35 pm on August 27, 2021:

   Oh, I misunderstand what this does. It doesn’t actually run the command but searches for it in expanded $($(1)_cxx).

   It does seem somewhat over-specific to look for clang++ -stdlib=libc++.

   ---

   

   hebasto commented at 2:36 pm on August 27, 2021:

   I think it is not an assumption, rather an option. If clang++ compiler with -stdlib=libc++ flag is used to compile the qt package, we just choose the correct linux-clang-libc++ mkspec.

   Otherwise, the linux-g++-64 mkspec is used as usually.

   ---

   

   hebasto commented at 2:39 pm on August 27, 2021:

   It does seem somewhat over-specific to look for clang++ -stdlib=libc++.

   True. Because clang++ -stdlib=libc++ requires the linux-clang-libc++ mkspec.

   ---

   

   laanwj commented at 7:50 pm on August 27, 2021:

   But what if say, the version of clang uses libc++ by default? Looking only at the argument (which should directly follow the compiler name) looks kind of fragile and will not catch every case where someone links against libc++.

   ---

   

   hebasto commented at 8:40 pm on August 27, 2021:

   Fair point…

   Have you any suggestions?

   ---

   

   hebasto commented at 9:06 am on September 28, 2021:

   Suggesting to continue this discussion in #22814 where this commit belongs to.
4. 
   practicalswift commented at 1:51 pm on September 4, 2021: contributor

   Strong Concept ACK
5. hebasto force-pushed on Sep 28, 2021
6. fanquake referenced this in commit de28c348a0 on Dec 30, 2021
7. 
   fanquake commented at 3:37 am on December 30, 2021: member

   Please rebase this on master.
8. sidhujag referenced this in commit 4975b13579 on Dec 30, 2021
9. ci: Enable the gui in the TSan build ec7b7d4a36
10. hebasto force-pushed on Dec 30, 2021
11. 
    hebasto commented at 9:01 am on December 30, 2021: member

    Please rebase this on master.

    Rebased.

12. 
    MarcoFalke commented at 11:22 am on December 30, 2021: member

    review ACK ec7b7d4a36e6e7dfa708f64666f96cd97f83f6dd
13. MarcoFalke merged this on Dec 30, 2021
14. MarcoFalke closed this on Dec 30, 2021

    ---

15. hebasto deleted the branch on Dec 30, 2021
16. sidhujag referenced this in commit ec6f6732af on Dec 30, 2021
17. hebasto referenced this in commit d04f68d99c on Jan 3, 2022
18. fanquake referenced this in commit db5f441408 on Jan 4, 2022
19. sidhujag referenced this in commit b7a0fce7ed on Jan 4, 2022
20. mzumsande referenced this in commit dc7c357417 on Jan 17, 2022
21. rebroad referenced this in commit 6d2e0e299f on Feb 3, 2022
22. PastaPastaPasta referenced this in commit 86c0067754 on Apr 7, 2022
23. PastaPastaPasta referenced this in commit 015034a31d on Apr 11, 2022
24. gades referenced this in commit 5031959363 on May 12, 2022
25. janus referenced this in commit ac200f8eca on Jul 10, 2022
26. DrahtBot locked this on Dec 30, 2022

Contributors
hebasto laanwj practicalswift fanquake MarcoFalke

Labels
Tests