Address in listunspent #2282

pull mb300sd wants to merge 1 commits into bitcoin:master from mb300sd:addressinlistunspent changing 1 files +7 −0

mb300sd commented at 10:55 PM on February 6, 2013: contributor

Add the bitcoin address and account to the listunspent output. Makes manual use easier since the user doesn't have to look up the tx to get the address.
BitcoinPullTester commented at 11:15 PM on February 6, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/999ee87f70ea58ecd656830a0deabb6720aae815 for binaries and test log.
fanquake commented at 10:38 AM on February 9, 2013: member

You'll probably want to squash this into two commits for a better chance of getting it merged.
Diapolo commented at 11:21 AM on February 9, 2013: none

Yeah this for sure needs to be squashed to have a merge-chance :).
sipa commented at 11:34 AM on February 9, 2013: member

ACK if you squash the two commits together.
BitcoinPullTester commented at 7:31 PM on February 9, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/06e437001a2b5fe173a54508b95f447def30dde3 for binaries and test log.
BitcoinPullTester commented at 8:32 PM on February 9, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/f53e2c38e7f3e2bad5b302621f6ffbb10d8f2bfc for binaries and test log.
mb300sd commented at 10:23 PM on February 9, 2013: contributor

Think I did it right, still getting used to git.
fanquake commented at 2:26 AM on February 10, 2013: member

Looks good. You got an 'ACK' from one of the core devs so this will be merged when there ready.
BitcoinPullTester commented at 1:37 AM on February 25, 2013: none

Automatic sanity-testing: WARNING, see http://jenkins.bluematt.me/pull-tester/a09cb4cade9adb1d4c7bd408737c224a698956fb for binaries and test log.

This pull decreases total test coverage, please add unit tests to test all new code and help us add test cases for existing code. Coverage report can be found at http://jenkins.bluematt.me/pull-tester/a09cb4cade9adb1d4c7bd408737c224a698956fb/bitcoin/src/total.coverage/
add address and account information to listunspent 550479b09f
BitcoinPullTester commented at 3:50 AM on February 28, 2013: none

Automatic sanity-testing: WARNING, see http://jenkins.bluematt.me/pull-tester/44d7f4cbebd446f8f4a48ff9048d4549c0e2448a for binaries and test log.

This pull decreases total test coverage, please add unit tests to test all new code and help us add test cases for existing code. Coverage report can be found at http://jenkins.bluematt.me/pull-tester/44d7f4cbebd446f8f4a48ff9048d4549c0e2448a/bitcoin/src/total.coverage/
BitcoinPullTester commented at 4:45 AM on February 28, 2013: none

Automatic sanity-testing: WARNING, see http://jenkins.bluematt.me/pull-tester/550479b09f1a2bacc5a5fe2b9259baaa3c05029e for binaries and test log.

This pull decreases total test coverage, please add unit tests to test all new code and help us add test cases for existing code. Coverage report can be found at http://jenkins.bluematt.me/pull-tester/550479b09f1a2bacc5a5fe2b9259baaa3c05029e/bitcoin/src/total.coverage/
sipa commented at 6:30 PM on April 7, 2013: member

Anyone an objection against this?
gmaxwell commented at 9:30 PM on April 7, 2013: contributor

@codeshark Does use of pwalletMain here to get the account gum up the mult-wallet support?
sipa commented at 9:34 PM on April 7, 2013: member

@gmaxwell All wallet RPCs receive an extra parameter pointing to the wallet, that will indeed need to be adapted for this method too, but it's a trivial change.
gmaxwell commented at 9:44 PM on April 7, 2013: contributor

ACK then. This works fine for me.
gmaxwell referenced this in commit 96371bc6e0 on Apr 7, 2013
gmaxwell merged this on Apr 7, 2013
gmaxwell closed this on Apr 7, 2013
laudney referenced this in commit 24f73e3802 on Mar 19, 2014
DrahtBot locked this on Sep 8, 2021

Contributors