While not many of these are used, some, like HAVE_DLLEXPORT_ATTRIBUTE, are used when creating libbitcoinconsensus.
Given this file is static, also just remove everything that is commented out.
msvc: update bitcoin_config.h defines #22843
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:update_msvc_bitcoin_configg changing 1 files +4 −129-
fanquake commented at 11:45 AM on August 31, 2021: member
- fanquake added the label Windows on Aug 31, 2021
- fanquake requested review from sipsorcery on Aug 31, 2021
- sipsorcery approved
-
sipsorcery commented at 1:25 PM on August 31, 2021: member
tACK.
Builds fine for me on Windows 10.
I was also unable to find any reference to the defines below in the source code when doing a Windows build. I was able to build with them removed.
LT_OBJDIR PACKAGE_STRING PACKAGE_TARNAME #if defined AC_APPLE_UNIVERSAL_BUILD # if defined __BIG_ENDIAN__ # define WORDS_BIGENDIAN 1 # endif #else # ifndef WORDS_BIGENDIAN /* # undef WORDS_BIGENDIAN */ # endif #endif _FILE_OFFSET_BITS STDC_HEADERS -
ae4ad1a125
msvc: update bitcoin_config.h defines
While not many of these are used, some, like HAVE_DLLEXPORT_ATTRIBUTE, are used when creating libbitcoinconsensus. Given this file is static, also just remove everything that is commented out.
- fanquake force-pushed on Sep 2, 2021
-
fanquake commented at 3:15 AM on September 2, 2021: member
@sipsorcery thanks. Added some more removals.
-
sipsorcery commented at 7:32 AM on September 2, 2021: member
tACK ae4ad1a1259886fe32a447749700fc132f387930.
- fanquake merged this on Sep 2, 2021
- fanquake closed this on Sep 2, 2021
- fanquake deleted the branch on Sep 2, 2021
- sidhujag referenced this in commit 084d17065c on Sep 2, 2021
- DrahtBot locked this on Sep 2, 2022
Contributors
Labels