Split out from #22762 to avoid having to carry it around in (an)other rebase(s)
Remove confusing CAddrDB #22915
pull MarcoFalke wants to merge 3 commits into bitcoin:master from MarcoFalke:2109-noAddrDb changing 13 files +37 −46-
MarcoFalke commented at 7:37 AM on September 8, 2021: member
-
fa3f5d0dae
Move addrman includes from .h to .cpp
This is a follow-up to the code move in commit a820e79512b67b1bfda20bdc32b47086d2b0910d
-
Fix addrdb includes fa7f77b7d1
-
fade9a1a4d
Remove confusing CAddrDB
The class only stores the file path, reading it from a global. Globals are confusing and make testing harder. The method reading from a stream does not even use any class members, so putting it in a class is also confusing.
- MarcoFalke added the label Refactoring on Sep 8, 2021
- MarcoFalke added the label P2P on Sep 8, 2021
-
practicalswift commented at 7:54 AM on September 8, 2021: contributor
Concept ACK
- ryanofsky approved
-
ryanofsky commented at 1:07 PM on September 8, 2021: member
Code review ACK fade9a1a4db71241ccad03fdacfb626453952963
-
DrahtBot commented at 1:23 PM on September 8, 2021: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #22910 ([RFC] Encapsulate asmap in NetGroupManager by jnewbery)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- lsilva01 approved
-
lsilva01 commented at 1:37 AM on September 9, 2021: contributor
Code Review ACK https://github.com/bitcoin/bitcoin/pull/22915/commits/fade9a1a4db71241ccad03fdacfb626453952963
This change makes the code clearer.
-
MarcoFalke commented at 6:09 AM on September 9, 2021: member
Going to merge this because the commit has another three (indirect) ACKs from the parent pull.
- MarcoFalke merged this on Sep 9, 2021
- MarcoFalke closed this on Sep 9, 2021
- MarcoFalke deleted the branch on Sep 9, 2021
- fanquake referenced this in commit 17e27dd000 on Sep 9, 2021
- sidhujag referenced this in commit b1bb38aa5d on Sep 11, 2021
- Fabcien referenced this in commit 9f83b8b171 on Oct 19, 2022
- DrahtBot locked this on Oct 30, 2022
