Fix Qt test broken by #22219 #22992

1. 
   ryanofsky commented at 2:14 am on September 16, 2021: member

   It looks like this should have been caught by CI but there might have been a conflict with a recently merged PR like #19101. Failure was reported by fanquake #22219 (comment)

   Fix avoids null WalletClient pointer dereference in address book test by adding MakeWalletClient call and making address book test initialization more consistent with wallet test initialization:

   https://github.com/bitcoin/bitcoin/blob/865ee1af201238f48671e3b79b8215f896db7a05/src/qt/test/addressbooktests.cpp#L63-L66 https://github.com/bitcoin/bitcoin/blob/865ee1af201238f48671e3b79b8215f896db7a05/src/qt/test/wallettests.cpp#L141-L144

2. Fix Qt test broken by #22219

   It looks like this should have been caught by CI but perhaps there was a
   conflict with a recently merged PR. Failure reported by fanquake <fanquake@gmail.com>
   https://github.com/bitcoin/bitcoin/pull/22219#issuecomment-920496509

   865ee1af20
3. ryanofsky force-pushed on Sep 16, 2021
4. 
   ryanofsky commented at 2:25 am on September 16, 2021: member

   Updated f2c0afdc017078d12cf70250068482bcd6bae21c -> 865ee1af201238f48671e3b79b8215f896db7a05 (pr/sfix.1 -> pr/sfix.2, compare) just to make addressbooktests init more consistent with wallettests init, and to do more complete wallet initialization at the beginning of the test instead of partial initialization in the middle.
5. fanquake approved
6. 
   fanquake commented at 4:09 am on September 16, 2021: member

   ACK 865ee1af201238f48671e3b79b8215f896db7a05 - I’m merging this now to unbreak the build.
7. fanquake merged this on Sep 16, 2021
8. fanquake closed this on Sep 16, 2021

   ---

9. DrahtBot locked this on Oct 30, 2022

Contributors
ryanofsky fanquake