doc: remove WSL install instructions and point to upstream #23007

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:remove_verbose_WSL_instructions changing 1 files +5 −35

fanquake commented at 3:28 AM on September 17, 2021: member

There's not really any need for us to have to replicate (ever-changing) instructions for installing an operating system in our build documentation.

doc: remove WSL install instructions and point to upstream

There's not really any need to us to have to replicate (ever-changing)
instructions for installing an operating system in our build
documentation.

f58f697c98

fanquake added the label Docs on Sep 17, 2021
fanquake added the label Windows on Sep 17, 2021
laanwj commented at 7:17 AM on September 17, 2021: member

Concept ACK for reasons outlined here #22373 (review)

ACK f58f697c98ebe0660cb7c5c2048ae5b2acb35a15

in doc/build-windows.md:8 in f58f697c98

   4 | @@ -5,11 +5,9 @@ Below are some notes on how to build Bitcoin Core for Windows.
   5 |  
   6 |  The options known to work for building Bitcoin Core on Windows are:
   7 |  
   8 | -* On Linux, using the [Mingw-w64](https://mingw-w64.org/doku.php) cross compiler tool chain. Ubuntu Bionic 18.04 is required
   9 | -and is the platform used to build the Bitcoin Core Windows release binaries.
  10 | -* On Windows, using [Windows
  11 | -Subsystem for Linux (WSL)](https://docs.microsoft.com/windows/wsl/about) and the Mingw-w64 cross compiler tool chain.
  12 | -* On Windows, using a native compiler tool chain such as [Visual Studio](https://www.visualstudio.com). See [README.md](/build_msvc/README.md).
  13 | +* On Linux, using the [Mingw-w64](https://www.mingw-w64.org/) cross compiler tool chain.

shaavan commented at 12:23 PM on September 17, 2021:

nit:

* On Linux, using the [Mingw-w64](https://www.mingw-w64.org/) cross compiler toolchain.

in doc/build-windows.md:19 in f58f697c98

  43 | -  * Create a new UNIX user account (this is a separate account from your Windows account)
  44 | -
  45 | -After the bash shell is active, you can follow the instructions below, starting
  46 | -with the "Cross-compilation" section. Compiling the 64-bit version is
  47 | -recommended, but it is possible to compile the 32-bit version.
  48 | +Follow the upstream installation instructions, available [here](https://docs.microsoft.com/windows/wsl/install-win10).

shaavan commented at 12:23 PM on September 17, 2021:

nit:

Follow the upstream installation instructions available [here](https://docs.microsoft.com/windows/wsl/install-win10).

shaavan commented at 12:30 PM on September 17, 2021: contributor

Concept ACK

This change would remove the unnecessary maintenance burden over the system. While at the same time keeping the WSL installations instructions up-to-date with the source.

I have noticed down some minor nit that I have noted down here.
DrahtBot commented at 2:09 AM on September 18, 2021: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #22373 (doc: Improve notes on installing WSL on windows 10 by nourou4them)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
hebasto commented at 6:39 PM on September 18, 2021: member

ACK f58f697c98ebe0660cb7c5c2048ae5b2acb35a15

Also #22373 (review)
fanquake merged this on Sep 20, 2021
fanquake closed this on Sep 20, 2021
fanquake deleted the branch on Sep 20, 2021
sidhujag referenced this in commit f993bafd13 on Sep 20, 2021
DrahtBot locked this on Oct 30, 2022

Contributors

Labels

doc: remove WSL install instructions and point to upstream #23007

Conflicts