doc: Remove outdated comments #23094

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:210925-comment changing 1 files +0 −2

hebasto commented at 11:24 AM on September 25, 2021: member

The first removed comment was introduced in #5288, the second one in #13503.

Both are outdated since #14336.
doc: Remove outdated comments
They are outdated since #14336.
ee7891a0c4
DrahtBot added the label Docs on Sep 25, 2021
dunxen approved
dunxen commented at 8:42 PM on September 25, 2021: contributor

crACK ee7891a0
laanwj merged this on Sep 27, 2021
laanwj closed this on Sep 27, 2021
hebasto deleted the branch on Sep 27, 2021
sidhujag referenced this in commit e84c360598 on Sep 27, 2021

in src/init.cpp:875 in ee7891a0c4

 870 | @@ -871,8 +871,6 @@ bool AppInitParameterInteraction(const ArgsManager& args)
 871 |      nUserMaxConnections = args.GetArg("-maxconnections", DEFAULT_MAX_PEER_CONNECTIONS);
 872 |      nMaxConnections = std::max(nUserMaxConnections, 0);
 873 |  
 874 | -    // Trim requested connection counts, to fit into system limitations
 875 | -    // <int> in std::min<int>(...) to work around FreeBSD compilation issue described in #2695

fanquake commented at 5:07 AM on September 28, 2021:

Both are outdated since #14336.

Why? The code the comment referred to previously was just moved a few lines down (unchanged) in #14336. This PR should have either moved the comment down, or had an actual explanation of why the FreeBSD compilation issue is no longer relevant.

hebasto commented at 9:16 AM on September 28, 2021:

:man_facepalming:

ouch, you are right...

laanwj referenced this in commit dbbb7fbcc0 on Sep 30, 2021
sidhujag referenced this in commit a2b232de94 on Sep 30, 2021
DrahtBot locked this on Oct 30, 2022

Contributors

Labels

Linked (view graph)

#5288 Added -whiteconnections=<n> option #13503 Document FreeBSD quirk. Fix FreeBSD build: Use std::min<int>(...) to allow for compilation under certain FreeBSD versions.#14336 net: implement poll #23130 doc: Revert "Remove outdated comments" and place comment correctly