doc: Revert "Remove outdated comments" and place comment correctly #23130

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:210929-revert changing 1 files +2 −0

hebasto commented at 8:37 AM on September 29, 2021: member

Unfortunately, in #23094 the assumption that #14336 makes comments outdated is wrong. As pointed in #23094 (review), the #14336 just moved the relevant code a few lines down.

This PR reverts commit ee7891a0c412728cf8bec667f25263682a9baaaf, and moves the comments into the right place.

I apologize about that.

Revert "doc: Remove outdated comments"

This reverts commit ee7891a0c412728cf8bec667f25263682a9baaaf, and moves
the comments into the right place.

8ff3743f5e

hebasto commented at 8:37 AM on September 29, 2021: member

cc @fanquake
MarcoFalke commented at 8:52 AM on September 29, 2021: member

cr ACK 8ff3743f5e99c693710bc446bfd595687156ca6b
laanwj commented at 10:10 AM on September 29, 2021: member

Sorry for merging it so quickly it seemed obvious to me.
MarcoFalke added the label Docs on Sep 29, 2021
laanwj renamed this:
~~Revert "doc: Remove outdated comments"~~
doc: Revert "Remove outdated comments" and place comment correctly
on Sep 30, 2021
laanwj commented at 10:32 AM on September 30, 2021: member

ACK 8ff3743f5e99c693710bc446bfd595687156ca6b
laanwj merged this on Sep 30, 2021
laanwj closed this on Sep 30, 2021
hebasto deleted the branch on Sep 30, 2021
sidhujag referenced this in commit a2b232de94 on Sep 30, 2021
DrahtBot locked this on Oct 30, 2022

Contributors

Labels