build: add python3.10 alias to AC_PATH_PROGS call in configure #23182

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:python_3_10_configure changing 1 files +1 −1

fanquake commented at 4:02 am on October 5, 2021: member

Python 3.10 is now released, and has been available as a beta/rc in distros for a little while already.

build: add python3.10 alias to AC_PATH_PROGS call in configure

Python 3.10 is now relased, and has been available as a beta/rc in
distros for a little while already.

ef15c574ff

fanquake added the label Build system on Oct 5, 2021
MarcoFalke commented at 8:16 am on October 5, 2021: member

Might as well add 3.11 to buy us 6 more months of having not to touch this again?
MarcoFalke commented at 8:16 am on October 5, 2021: member

cr ACK ef15c574ffc62969f65c87b33aec45ef82fdd476
laanwj commented at 8:54 am on October 5, 2021: member

Might as well add 3.11 to buy us 6 more months of having not to touch this again?

I sometimes wonder if we can do something smarter than hardcoding all the versions… (also why this order? why do we prefer lower versions)

That said, I’m good on kicking this particular can down the road one more time, doesn’t seem something worth spending a lot of time on. Code review ACK ef15c574ffc62969f65c87b33aec45ef82fdd476
MarcoFalke commented at 9:03 am on October 5, 2021: member

This patch will only makes a difference if python3 (or python) refer to python 3.5 or earlier and none of python3.6 - python3.9 are available, but python3.10 is. I don’t think such a system exists in practice.

why this order? why do we prefer lower versions

My guess is that it makes it easier for devs to find incompatibilities with the minimum supported version.
laanwj commented at 9:13 am on October 5, 2021: member

My guess is that it makes it easier for devs to find incompatibilities with the minimum supported version.

Good point.
hebasto approved
hebasto commented at 9:27 am on October 5, 2021: member

ACK ef15c574ffc62969f65c87b33aec45ef82fdd476, I have reviewed the code and it looks OK, I agree it can be merged.

UPDATE: #23182 (review)
MarcoFalke merged this on Oct 5, 2021
MarcoFalke closed this on Oct 5, 2021
in configure.ac:110 in ef15c574ff
106@@ -107,7 +107,7 @@ AC_PATH_TOOL(GCOV, gcov) 107 AC_PATH_TOOL(LLVM_COV, llvm-cov) 108 AC_PATH_PROG(LCOV, lcov) 109 dnl Python 3.6 is specified in .python-version and should be used if available, see doc/dependencies.md 110-AC_PATH_PROGS([PYTHON], [python3.6 python3.7 python3.8 python3.9 python3 python]) 111+AC_PATH_PROGS([PYTHON], [python3.6 python3.7 python3.8 python3.9, python3.10, python3 python])
hebasto commented at 9:36 am on October 5, 2021:

Commas actually break checking, and they must be dropped.

AC_PATH_PROGS won’t find python3.9 and python3.10 executables.

MarcoFalke commented at 9:51 am on October 5, 2021:

@fanquake Are you testing the review process? :eyes:

fanquake commented at 0:25 am on October 8, 2021:

👀. Will be addressed in a follow up shortly.

Empact commented at 12:39 pm on October 13, 2021:

Included the fix here: #23270, lmk if you’d like to take a different approach.
sidhujag referenced this in commit df5f7b2125 on Oct 5, 2021
fanquake deleted the branch on Oct 8, 2021
luke-jr commented at 2:48 am on October 11, 2021: member

why this order? why do we prefer lower versions

We can’t possibly know in advance if newer versions will break our scripts?
fanquake referenced this in commit a78137ec33 on Oct 20, 2021
fanquake commented at 4:30 am on October 20, 2021: member

Ultimately fixed in #23317.
MarcoFalke referenced this in commit f9ad4d51e3 on Oct 20, 2021
sidhujag referenced this in commit 486d17cc9c on Oct 20, 2021
luke-jr referenced this in commit ff7d9df492 on Dec 14, 2021
luke-jr referenced this in commit e864328b90 on Dec 14, 2021
DrahtBot locked this on Oct 30, 2022

Contributors
fanquake MarcoFalke laanwj hebasto Empact luke-jr

Labels
Build system