On master (9013f23b0a6e0e450c4603f9d0f050ff10d552f6) observed a failed assertion after trying to quit immediately after the GUI open:
$ src/qt/bitcoin-qt
bitcoin-qt: init.cpp:183: auto Shutdown(NodeContext &)::(anonymous class)::operator()() const: Assertion `"node.args" && check' failed.
Aborted (core dumped)
cc @ryanofsky
Looks like this assert(node.arg) is running
https://github.com/bitcoin/bitcoin/blob/9013f23b0a6e0e450c4603f9d0f050ff10d552f6/src/init.cpp#L183
before node.args is assigned
Unclear how this would happen or if it is a new problem
Probably stack trace for the assert is
Shutdown() https://github.com/bitcoin/bitcoin/blob/9013f23b0a6e0e450c4603f9d0f050ff10d552f6/src/init.cpp#L183
NodeImpl::appShutdown() https://github.com/bitcoin/bitcoin/blob/9013f23b0a6e0e450c4603f9d0f050ff10d552f6/src/node/interfaces.cpp#L92
InitExecutor::shutdown https://github.com/bitcoin/bitcoin/blob/9013f23b0a6e0e450c4603f9d0f050ff10d552f6/src/qt/initexecutor.cpp#L62
So initexecutor is somehow shutting down before MakeNodeInit is called?
So initexecutor is somehow shutting down before MakeNodeInit is called?
This seems impossible actually. More likely might be that Shutdown() is being called twice, and second call fails because the first call resets args to null:
https://github.com/bitcoin/bitcoin/blob/9013f23b0a6e0e450c4603f9d0f050ff10d552f6/src/init.cpp#L298
If the problem is that Shutdown() is being called twice, it would be good to figure out why Shutdown is being called twice, and whether that is happening in a thread safe way, and whether GUI shutdown logic can be simplified so this doesn't happen.
But whether or not you actually want the GUI to call Shutdown multiple times, it would probably be good to make the Shutdown function idempotent and just delete the node.args = nullptr; line since it doesn't really belong there anyway:
https://github.com/bitcoin/bitcoin/blob/9013f23b0a6e0e450c4603f9d0f050ff10d552f6/src/init.cpp#L298
This bug is 100% reproducible in my Qt 6 branch.
If the problem is that Shutdown() is being called twice
~No. Shutdown() is being called once.~ Sorry. Confirmed. It is being called twice.
Confirmed. It is being called twice.
I don't remember all the details here but it does seem like making it idempotent and deleting the node.args = nullptr; line could be a good fix
This bug is 100% reproducible in my Qt 6 branch.
It's unrelated to the initial issue, as it appears Qt 6 specific.
Is this still an issue? If yes. How is it reproduced? If it's GUI/qt only, then move it to the GUI repo?
Closing for now. Will reopen after being able to reproduce.