remove duplicate bitdb.Open() code from init #2333

1. 
   Diapolo commented at 10:52 pm on February 23, 2013: none

   • remove code from step 7, which we already have in step 5 of init
2. 
   BitcoinPullTester commented at 0:36 am on February 25, 2013: none

   Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/f703e1efde24c1dff91982787cc8d59e69be7017 for binaries and test log.

   This could happen for one of several reasons:

   1. It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts
   2. It adds/modifies tests which test network rules (thanks for doing that), which conflicts with a patch applied at test time
   3. It does not build on either Linux i386 or Win32 (via MinGW cross compile)
   4. The test suite fails on either Linux i386 or Win32
   5. The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)

   If you believe this to be in error, please ping BlueMatt on freenode or TheBlueMatt here.

3. 
   Diapolo commented at 8:14 am on February 25, 2013: none

   @TheBlueMatt How can my change here cause this: test/util_tests.cpp(307): error in "util_seed_insecure_rand": check count<=10000/mod+err failed?
4. 
   BitcoinPullTester commented at 8:38 am on March 13, 2013: none

   Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/502ecf77dbc091dd0da72c4aecd5186c7dd49470 for binaries and test log.
5. 
   Diapolo commented at 7:27 am on March 21, 2013: none

   Can any core-dev confirm this is okay? I know that @gmaxwell recently changed that message with another pull, but perhaps didn’t see that duplicate, which used the same string.

   Edit: It was #2384.

6. 
   luke-jr commented at 5:32 am on April 8, 2013: member

   Needs rebase.
7. remove duplicate bitdb.Open() code from init

   - remove code from step 7, which we already have in step 5 of init

   894b7c1534
8. 
   Diapolo commented at 6:07 am on April 8, 2013: none

   Rebased!
9. 
   BitcoinPullTester commented at 6:53 am on April 8, 2013: none

   Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/894b7c1534165ec5c3b78cd09ae56db843f8a915 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
10. Diapolo closed this on May 4, 2013

    ---

11. DrahtBot locked this on Sep 8, 2021

Contributors
Diapolo BitcoinPullTester luke-jr