build: Fix cross compiling with DEBUG=1 for Windows #23612

1. 
   hebasto commented at 2:27 pm on November 27, 2021: member

   On master (200d97faf2ed0bd0cbef93dd4bbbe77cf8fe5d13) cross compiling for Windows with depends being built with DEBUG=1 is broken in two places:

   • libbitcoinconsensus, see bitcoin/bitcoin#19772
   • libunivalue, see #22646 (comment)

   This PR workarounds both cases.

   Closes bitcoin/bitcoin#19772.

   The previous attempt was #21344.

2. build: Fix cross compiling with DEBUG=1 for Windows 36f39b487a
3. hebasto added the label Windows on Nov 27, 2021
4. hebasto added the label Build system on Nov 27, 2021
5. laanwj requested review from fanquake on Nov 30, 2021
6. 
   laanwj commented at 6:39 pm on November 30, 2021: member

   Cannot test this at the moment. I’m confused why enable_shared=no works in this case, tagged @fanquake as reviewer because of #19772 (comment) .
7. 
   hebasto commented at 7:32 pm on November 30, 2021: member

   Cannot test this at the moment. I’m confused why enable_shared=no works in this case

   It controls how the libtool will be configured by the following ./configure script.

8. luke-jr changes_requested
9. 
   luke-jr commented at 11:07 pm on November 30, 2021: member

   Concept NACK. This doesn’t fix the build, just prevents it…
10. 
    fanquake commented at 4:12 am on December 1, 2021: member

    I agree with Luke. It’s hard to call this a fix when it’s just ignoring what’s broken. As-is, we’d also get an undocumented special casing in our config.site, which I’d rather avoid. If this a big problem for someone, maybe we could carry this in the interim, but this isn’t a long term solution, and shouldn’t be merged undocumented.
11. hebasto closed this on Apr 25, 2022

    ---

12. DrahtBot locked this on Apr 25, 2023

Contributors
hebasto laanwj luke-jr fanquake

Review Requested
fanquake

Labels
Windows Build system