build: don’t compress macOS DMG #24031

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:dont_compress_macos_dmg changing 10 files +7 −111
  1. fanquake commented at 4:09 am on January 11, 2022: member

    Skip compressing the macOS DMG, and drop related build steps and dependencies. Uncompressed the DMG increases from ~16mb to ~30mb, which compared to other software a user may download, (Firefox 125mb, VLC 52mb, Open Office 176mb), is still relatively small. When contrasted against the 100’s of GB of blockchain data a node will download, an additional 15mb to get the release binary, isn’t much additional overhead. Note that if / when we build with LTO enabled for releases, this size will shrink back down significantly again.

    native_libdmg-hfsplus is not maintained, and I doubt the DMG creation feature will ever be fixed. If at some point xorrisofs supports compressing dmgs, we could enable that.

    Guix Build on x86_64:

    025b7c8bb7bc8ea014d43cebb844a842d2ac8d5a343039a820d24b649c9e6bc8a  guix-build-1dd8cbfbc631/output/arm64-apple-darwin/SHA256SUMS.part
116beb5c52c9bf51b5ce9ef5a0d17c0038238a833383586a1b14acbca78533e4b  guix-build-1dd8cbfbc631/output/arm64-apple-darwin/bitcoin-1dd8cbfbc631-arm64-apple-darwin-unsigned.dmg
2d8f89a61a7448d6334dbb3639386a7b6340542393933f35421a9e6dfc724e455  guix-build-1dd8cbfbc631/output/arm64-apple-darwin/bitcoin-1dd8cbfbc631-arm64-apple-darwin-unsigned.tar.gz
311617dc261ef602433f5bb29956a40a9085dbc783f519f75fbe06e80970148d0  guix-build-1dd8cbfbc631/output/arm64-apple-darwin/bitcoin-1dd8cbfbc631-arm64-apple-darwin.tar.gz
4aa8550d4a394d3161d14ec5e6012ed07354135afb022e905a1946785b4665664  guix-build-1dd8cbfbc631/output/dist-archive/bitcoin-1dd8cbfbc631.tar.gz
52b837f2f971a9738d0b7b8497f7ded740ef5e67c8baa7f30ca33e6b7d826eec8  guix-build-1dd8cbfbc631/output/x86_64-apple-darwin/SHA256SUMS.part
6db972b2c06dbde5525a3f9e6ceb9c20a8120bc9a6f15e1d852a4bfac09d88569  guix-build-1dd8cbfbc631/output/x86_64-apple-darwin/bitcoin-1dd8cbfbc631-x86_64-apple-darwin-unsigned.dmg
750fe990c3f9923ee92195125faf6517396e7c1b017a8f4f7d52e991ebce52f0c  guix-build-1dd8cbfbc631/output/x86_64-apple-darwin/bitcoin-1dd8cbfbc631-x86_64-apple-darwin-unsigned.tar.gz
81d9022b0ae46ead41046c40f82291ce363760660a3cd6e6ef6a5b1128b90faef  guix-build-1dd8cbfbc631/output/x86_64-apple-darwin/bitcoin-1dd8cbfbc631-x86_64-apple-darwin.tar.gz

    Guix Build on arm64:

  2. DrahtBot added the label Build system on Jan 11, 2022
  3. DrahtBot added the label Scripts and tools on Jan 11, 2022
  4. DrahtBot commented at 6:21 am on January 11, 2022: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #21778 (build: LLVM 14 & LLD based macOS toolchain by fanquake)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  5. Sjors commented at 1:23 pm on January 13, 2022: member

    Concept ACK

    When I build locally on macOS 12.1 and without using depends, the difference in size between this commit and its parent is negligible. Both are 20 MB. Am I doing it wrong or is there something in the Guix build that lends itself more to compression?

    Update: oh wait, when building on macOS it uses completely different tools (see if BUILD_DARWIN in Makefile)

  6. monstrito commented at 7:11 am on January 18, 2022: none
    @maldito-dot
  7. fanquake commented at 10:59 am on January 31, 2022: member
    An additional reason for merging this is that is will fix Guix building for arm64 darwin on arm64 darwin (#24211).
  8. fanquake force-pushed on Feb 2, 2022
  9. fanquake marked this as ready for review on Feb 2, 2022
  10. fanquake force-pushed on Feb 22, 2022
  11. fanquake force-pushed on Mar 9, 2022
  12. DrahtBot added the label Needs rebase on Mar 16, 2022
  13. fanquake force-pushed on Mar 16, 2022
  14. fanquake commented at 4:20 pm on March 16, 2022: member
    Rebased past #23565.
  15. DrahtBot removed the label Needs rebase on Mar 16, 2022
  16. DrahtBot added the label Needs rebase on Mar 16, 2022
  17. fanquake force-pushed on Mar 16, 2022
  18. DrahtBot removed the label Needs rebase on Mar 16, 2022
  19. DrahtBot added the label Needs rebase on Mar 18, 2022
  20. fanquake force-pushed on Mar 18, 2022
  21. Sjors commented at 11:28 am on March 18, 2022: member
    The code in 6c73e2ac13317e828b72ac46333a7d3209b7e1a2 looks reasonable, but what’s the process for testing this? I assume we need detached signatures to have guix bake the DMG? If that can be done with something self-signed, what’s the incantation?
  22. DrahtBot removed the label Needs rebase on Mar 18, 2022
  23. fanquake commented at 9:28 pm on March 18, 2022: member

    but what’s the process for testing this?

    Performing a macOS cross compile, on Linux, using depends, and building with make deploy. You can compare the size of the .dmg for master vs this PR, check that the .dmg still works etc.

    i.e:

     0make -C depends/ HOST=x86_64-apple-darwin -j9
 1./autogen.sh
 2CONFIG_SITE=/home/ubuntu/bitcoin/depends/x86_64-apple-darwin/share/config.site ./configure
 3make deploy -j9
 4
 5# master 2320d31aaacd2bc05fc26482108d30d5d897250a
 616107796 Bitcoin-Core.dmg
 7
 8# swap to this branch, re-make depends, re-make-deploy etc
 9
10# PR 6c73e2ac13317e828b72ac46333a7d3209b7e1a2
1132227328 Bitcoin-Core.dmg
  24. Sjors commented at 9:07 am on March 19, 2022: member

    I haven’t done cross compilation in a while it seems, have you ever seen this error? Ubuntu 21.10, on the the commit before this PR.

     0$ cd depends
 1$ make HOST=x86_64-apple-darwin
 2Fetching v1.3.0.tar.gz from https://github.com/al45tair/ds_store/archive/
 3  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
 4                                 Dload  Upload   Total   Spent    Left  Speed
 5100   135  100   135    0     0    794      0 --:--:-- --:--:-- --:--:--   794
 6100 23031    0 23031    0     0  59976      0 --:--:-- --:--:-- --:--:--  137k
 7/home/dev/bitcoin/depends/work/download/native_ds_store-1.3.0/v1.3.0.tar.gz.temp: OK
 8Extracting native_ds_store...
 9/home/dev/bitcoin/depends/sources/v1.3.0.tar.gz: OK
10Preprocessing native_ds_store...
11Configuring native_ds_store...
12Building native_ds_store...
13Segmentation fault (core dumped)
14make: *** [funcs.mk:282: /home/dev/bitcoin/depends/work/build/x86_64-apple-darwin/native_ds_store/1.3.0-65fe7ecd050/./.stamp_built] Error 139

    Update: this seems to be a Python environment issue. I switched to 3.9.11 (using PyEnv) and it’s happy now.

  25. Sjors commented at 4:47 pm on March 19, 2022: member
    tACK 6c73e2ac13317e828b72ac46333a7d3209b7e1a2
  26. hebasto added the label macOS on Mar 20, 2022
  27. hebasto commented at 6:06 am on March 20, 2022: member

    Concept ACK.

    Could this solution have any implications regarding our future attempts to notarize Bitcoin Core binaries?

  28. fanquake commented at 11:32 am on March 21, 2022: member

    Could this solution have any implications regarding our future attempts to notarize Bitcoin Core binaries?

    I can’t think of a problem this might cause in regards to notarization; did you have a specific issue in mind?

  29. hebasto commented at 8:22 am on March 29, 2022: member

    Guix builds on x86_64:

    0$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
176c58f01d9482521fe04cdc543c02f490cab8da260949a72f1a0090fc45b590e  guix-build-6c73e2ac1331/output/arm64-apple-darwin/SHA256SUMS.part
278803e6cd4456c3ea725a02a791da64d861b064d401a76e0266ba038d24758c5  guix-build-6c73e2ac1331/output/arm64-apple-darwin/bitcoin-6c73e2ac1331-arm64-apple-darwin-unsigned.dmg
3ee5a82bb774784e767a41399dea8bbdc6f17cca9616ae1d3b5ef6c96411b0ba4  guix-build-6c73e2ac1331/output/arm64-apple-darwin/bitcoin-6c73e2ac1331-arm64-apple-darwin-unsigned.tar.gz
4f9b4389ecce123e97ffeec7131e2e11219eb1300bece414979ef46268dae37d2  guix-build-6c73e2ac1331/output/arm64-apple-darwin/bitcoin-6c73e2ac1331-arm64-apple-darwin.tar.gz
5d7bc76123ce2b328ae210d13ef46ab2ecaeefb7550d5a9f82e7c42bc5458bbaf  guix-build-6c73e2ac1331/output/dist-archive/bitcoin-6c73e2ac1331.tar.gz
66d257f3f673059c0f0953398bbd279dbcfa11a700fa3725cf1da881df82378d7  guix-build-6c73e2ac1331/output/x86_64-apple-darwin/SHA256SUMS.part
7543ec768c13508ed3218f531443b6bf6b4532f01473565489cf6b4b6a226db1f  guix-build-6c73e2ac1331/output/x86_64-apple-darwin/bitcoin-6c73e2ac1331-x86_64-apple-darwin-unsigned.dmg
8b75973e4e39088bddaac726fe712c979a96b96cf0ad280860114a7b664840266  guix-build-6c73e2ac1331/output/x86_64-apple-darwin/bitcoin-6c73e2ac1331-x86_64-apple-darwin-unsigned.tar.gz
9a2de8ac6a345ccc96cfbc0280a24995bcc1995db67f3299d9e2170466162c7e5  guix-build-6c73e2ac1331/output/x86_64-apple-darwin/bitcoin-6c73e2ac1331-x86_64-apple-darwin.tar.gz
  30. fanquake commented at 1:57 pm on March 29, 2022: member
    An additional (and probably now the primary) reason for removing this is that the usage of the dmg tool, and it’s existence in the macOS tarballs is a blocker for cross-arch reproducibility. See discussion in #24615.
  31. hebasto commented at 6:44 pm on April 2, 2022: member

    Guix builds on arm64:

    0# find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
169f6aebc32c4f76fdbc477ddff3c549bab959b2e805643ba39d4a41642a28854  guix-build-6c73e2ac1331/output/arm64-apple-darwin/SHA256SUMS.part
294451d0573a2360967bd1094107434e8bf3b45ae3210a6cd360ae3e1306453d8  guix-build-6c73e2ac1331/output/arm64-apple-darwin/bitcoin-6c73e2ac1331-arm64-apple-darwin-unsigned.dmg
3d5e70451a92106f65ae275d98054f269af817d78fb8d846f2063c0c2e062b05f  guix-build-6c73e2ac1331/output/arm64-apple-darwin/bitcoin-6c73e2ac1331-arm64-apple-darwin-unsigned.tar.gz
49a0d6b5e76a49ca84eab260287c287eb1656597afd9f6f5eb419d7b6ce083f00  guix-build-6c73e2ac1331/output/arm64-apple-darwin/bitcoin-6c73e2ac1331-arm64-apple-darwin.tar.gz
5d7bc76123ce2b328ae210d13ef46ab2ecaeefb7550d5a9f82e7c42bc5458bbaf  guix-build-6c73e2ac1331/output/dist-archive/bitcoin-6c73e2ac1331.tar.gz
66d257f3f673059c0f0953398bbd279dbcfa11a700fa3725cf1da881df82378d7  guix-build-6c73e2ac1331/output/x86_64-apple-darwin/SHA256SUMS.part
7543ec768c13508ed3218f531443b6bf6b4532f01473565489cf6b4b6a226db1f  guix-build-6c73e2ac1331/output/x86_64-apple-darwin/bitcoin-6c73e2ac1331-x86_64-apple-darwin-unsigned.dmg
8b75973e4e39088bddaac726fe712c979a96b96cf0ad280860114a7b664840266  guix-build-6c73e2ac1331/output/x86_64-apple-darwin/bitcoin-6c73e2ac1331-x86_64-apple-darwin-unsigned.tar.gz
9a2de8ac6a345ccc96cfbc0280a24995bcc1995db67f3299d9e2170466162c7e5  guix-build-6c73e2ac1331/output/x86_64-apple-darwin/bitcoin-6c73e2ac1331-x86_64-apple-darwin.tar.gz
  32. hebasto commented at 9:00 am on April 3, 2022: member

    native_libdmg-hfsplus is not maintained, and I doubt the DMG creation feature will ever be fixed.

    Also #17057

  33. hebasto commented at 9:09 am on April 3, 2022: member

    Approach ACK 6c73e2ac13317e828b72ac46333a7d3209b7e1a2.

    An additional (and probably now the primary) reason for removing this is that the usage of the dmg tool, and it’s existence in the macOS tarballs is a blocker for cross-arch reproducibility. See discussion in #24615.

    This PR by itself makes Guix builds for x86_64-apple-darwin cross-architecture reproducible.

  34. hebasto commented at 2:32 pm on April 3, 2022: member

    Testing bitcoin-6c73e2ac1331-x86_64-apple-darwin-unsigned.dmg, and when double-click on the file, not seeing such a window :

    Screenshot from 2022-04-03 16-22-47

    Is it expected?

    If “yes”, should we modify our macOS install instructions?

  35. fanquake commented at 8:54 am on April 5, 2022: member

    and when double-click on the file, not seeing such a window :

    The dmg still mounts though? I think the reason this may no-longer pop up is because there isn’t a hfsplus volume, which would have a specific bit set in it’s header, to tell the OS/Finder to open a window on mount. Adding -hfsplus to the xorrisofs invocation doesn’t seem to fix this, although maybe we should be adding that anyway.

    If “yes”, should we modify our macOS install instructions?

    Which install instructions?

  36. fanquake force-pushed on Apr 6, 2022
  37. fanquake commented at 10:38 am on April 6, 2022: member
    Rebased past #24669.
  38. jarolrod commented at 3:04 am on April 11, 2022: member

    Getting a similar error as the macOS 10.15 failing test when trying to guix build for arm64 and x86 apple-darwin on m1 Mac or on x86 linux.

    0xorriso : NOTE : Environment variable SOURCE_DATE_EPOCH encountered with value 1640938135
1Drive current: -outdev 'stdio:/distsrc-base/distsrc-466a91c48791-arm64-apple-darwin/output/bitcoin-466a91c48791-arm64-apple-darwin-unsigned.dmg'
2Media current: stdio file, overwriteable
3Media status : is blank
4Media summary: 0 sessions, 0 data blocks, 0 data,  132g free
5xorriso : WARNING : -volid text does not comply to ISO 9660 / ECMA 119 rules
6xorriso : FAILURE : Cannot determine attributes of source file '/distsrc-base/distsrc-466a91c48791-arm64-apple-darwin/dist' : No such file or directory
7xorriso : aborting : -abort_on 'FAILURE' encountered 'FAILURE'
8make: *** [Makefile:1306: /distsrc-base/distsrc-466a91c48791-arm64-apple-darwin/output/bitcoin-466a91c48791-arm64-apple-darwin-unsigned.dmg] Error 5
  39. build: don't compress macOS DMG 1dd8cbfbc6
  40. fanquake force-pushed on Apr 11, 2022
  41. jarolrod commented at 9:43 pm on April 11, 2022: member

    Concept ACK

    Guix hashes on x86

    025b7c8bb7bc8ea014d43cebb844a842d2ac8d5a343039a820d24b649c9e6bc8a  guix-build-1dd8cbfbc631/output/arm64-apple-darwin/SHA256SUMS.part
116beb5c52c9bf51b5ce9ef5a0d17c0038238a833383586a1b14acbca78533e4b  guix-build-1dd8cbfbc631/output/arm64-apple-darwin/bitcoin-1dd8cbfbc631-arm64-apple-darwin-unsigned.dmg
2d8f89a61a7448d6334dbb3639386a7b6340542393933f35421a9e6dfc724e455  guix-build-1dd8cbfbc631/output/arm64-apple-darwin/bitcoin-1dd8cbfbc631-arm64-apple-darwin-unsigned.tar.gz
311617dc261ef602433f5bb29956a40a9085dbc783f519f75fbe06e80970148d0  guix-build-1dd8cbfbc631/output/arm64-apple-darwin/bitcoin-1dd8cbfbc631-arm64-apple-darwin.tar.gz
4aa8550d4a394d3161d14ec5e6012ed07354135afb022e905a1946785b4665664  guix-build-1dd8cbfbc631/output/dist-archive/bitcoin-1dd8cbfbc631.tar.gz
52b837f2f971a9738d0b7b8497f7ded740ef5e67c8baa7f30ca33e6b7d826eec8  guix-build-1dd8cbfbc631/output/x86_64-apple-darwin/SHA256SUMS.part
6db972b2c06dbde5525a3f9e6ceb9c20a8120bc9a6f15e1d852a4bfac09d88569  guix-build-1dd8cbfbc631/output/x86_64-apple-darwin/bitcoin-1dd8cbfbc631-x86_64-apple-darwin-unsigned.dmg
750fe990c3f9923ee92195125faf6517396e7c1b017a8f4f7d52e991ebce52f0c  guix-build-1dd8cbfbc631/output/x86_64-apple-darwin/bitcoin-1dd8cbfbc631-x86_64-apple-darwin-unsigned.tar.gz
81d9022b0ae46ead41046c40f82291ce363760660a3cd6e6ef6a5b1128b90faef  guix-build-1dd8cbfbc631/output/x86_64-apple-darwin/bitcoin-1dd8cbfbc631-x86_64-apple-darwin.tar.gz

    Guix hashes on arm64

    0e5c954168658b4e8347b96753b78cddb84f5fd8758260e26769b35e00f15ee02  guix-build-1dd8cbfbc631/output/arm64-apple-darwin/SHA256SUMS.part
123bf8ddde7c6850843a79843fa4c42f5d09f1dd11ed3492ed00462fd87d32583  guix-build-1dd8cbfbc631/output/arm64-apple-darwin/bitcoin-1dd8cbfbc631-arm64-apple-darwin-unsigned.dmg
2f441b8695d26af1040ed5dfe7feb217561edc56bf693639774711502d27172c7  guix-build-1dd8cbfbc631/output/arm64-apple-darwin/bitcoin-1dd8cbfbc631-arm64-apple-darwin-unsigned.tar.gz
3d7a3ccb47907db23f263d2f9c3ca548bb60e357d80f765a45bfdc38652030d68  guix-build-1dd8cbfbc631/output/arm64-apple-darwin/bitcoin-1dd8cbfbc631-arm64-apple-darwin.tar.gz
4aa8550d4a394d3161d14ec5e6012ed07354135afb022e905a1946785b4665664  guix-build-1dd8cbfbc631/output/dist-archive/bitcoin-1dd8cbfbc631.tar.gz
52b837f2f971a9738d0b7b8497f7ded740ef5e67c8baa7f30ca33e6b7d826eec8  guix-build-1dd8cbfbc631/output/x86_64-apple-darwin/SHA256SUMS.part
6db972b2c06dbde5525a3f9e6ceb9c20a8120bc9a6f15e1d852a4bfac09d88569  guix-build-1dd8cbfbc631/output/x86_64-apple-darwin/bitcoin-1dd8cbfbc631-x86_64-apple-darwin-unsigned.dmg
750fe990c3f9923ee92195125faf6517396e7c1b017a8f4f7d52e991ebce52f0c  guix-build-1dd8cbfbc631/output/x86_64-apple-darwin/bitcoin-1dd8cbfbc631-x86_64-apple-darwin-unsigned.tar.gz
81d9022b0ae46ead41046c40f82291ce363760660a3cd6e6ef6a5b1128b90faef  guix-build-1dd8cbfbc631/output/x86_64-apple-darwin/bitcoin-1dd8cbfbc631-x86_64-apple-darwin.tar.gz
  42. Sjors commented at 6:22 pm on April 13, 2022: member

    re-tACK 1dd8cbfbc6318308b5e75023568f818ef6a9c7e4 on Intel macOS

    File is about 31 MB.

    Only changes compared to 6c73e2ac13317e828b72ac46333a7d3209b7e1a2 are in Makefile.am. Guix hashes match what @jarolrod found.

  43. laanwj commented at 7:23 am on April 14, 2022: member
    Build system changes code review ACK 1dd8cbfbc6318308b5e75023568f818ef6a9c7e4, I don’t know anything about MacOS application formats and their internals so do not have an opinion on the contents of this change.
  44. hebasto commented at 7:47 pm on April 17, 2022: member

    I think the reason this may no-longer pop up is because there isn’t a hfsplus volume, which would have a specific bit set in it’s header, to tell the OS/Finder to open a window on mount. Adding -hfsplus to the xorrisofs invocation doesn’t seem to fix this, although maybe we should be adding that anyway.

    Looks like a bug in the xorrisofs. Has it already been known/reported by someone?

    If “yes”, should we modify our macOS install instructions?

    Which install instructions?

    I mean, the change in user’s steps to install Bitcoin Core on macOS should be documented somehow. Maybe, in release notes?

    While touching this code, could the deploydir target be added to .PHONY:?

  45. jarolrod commented at 8:09 am on April 19, 2022: member

    Approach ACK. I have reviewed the code and done some testing, but still plan to do more testing before my final ack.

    Confirming that the quix built dmg does not automatically open in a file window when double clicked, but does mount as expected. The DMG deployed through make deploy on a non-depends native compile build does open up automatically in a file window when double clicked.

    This behavior change is fine with me, as we are getting rid of things (yay less things) and achieving cross-architecture reproducibility on a platform. If we need documentation on the behavior change, that can be picked up in a follow-up. Additionally, it could be possible to address the behavior change in a follow-up down the road.

  46. Sjors commented at 9:21 am on April 19, 2022: member

    Confirming that the quix built dmg does not automatically open in a file window when double clicked, but does mount as expected.

    We should explain to the user that they have to do “open Bitcoin-Core.dmg”. Could be fixed in a followup; I’d rather not have to run Guix again :-)

  47. fanquake commented at 8:16 am on April 20, 2022: member

    Looks like a bug in the xorrisofs. Has it already been known/reported by someone?

    I’m not sure it is a bug. Aside from my not being sure if my assumption is correct, if it was, the same header bit that means something on macOS, probably doesn’t mean anything on Linux for hfsplus volumes, which would likely be why the developers of the tool wouldn’t have cared about this behaviour. I can look at following up.

    I mean, the change in user’s steps to install Bitcoin Core on macOS should be documented somehow. Maybe, in release notes?

    Sure, we could add something to the release notes. I don’t think it’s a big deal either way.

    While touching this code, could the deploydir target be added to .PHONY:?

    If I touch this branch again I could do.

    We should explain to the user that they have to do “open Bitcoin-Core.dmg”.

    They don’t have to do open Bitcoin-Core.dmg. They can also just double click on it as usual, and pick the volume in Finder.

  48. jarolrod approved
  49. jarolrod commented at 5:06 am on April 21, 2022: member

    ACK https://github.com/bitcoin/bitcoin/commit/1dd8cbfbc6318308b5e75023568f818ef6a9c7e4

    I’ve tested guix builds on x86 and arm64 to ensure that I can build and open the resulting dmg. This change looks good to me, While technically there is a behavior change in that the dmg doesn’t automatically open up in the finder, I don’t think this will reasonably cause any disturbance; I also don’t think there will be any need for any documentation changes. One can reasonably be expected to know how to open up the dmg. The need for documentation can be revisited if there is ever an issue opened up on this topic.

  50. fanquake merged this on Apr 21, 2022
  51. fanquake closed this on Apr 21, 2022
  52. fanquake deleted the branch on Apr 21, 2022
  53. fanquake added the label Needs release note on Apr 21, 2022
  54. fanquake referenced this in commit 0b22b0e1a5 on Apr 21, 2022
  55. sidhujag referenced this in commit 1abd2cf98c on Apr 22, 2022
  56. fanquake removed the label Needs release note on Sep 15, 2022
  57. fanquake commented at 3:25 pm on September 15, 2022: member
    I’m going to remove “Needs release note” here (this will be in 24.0), as I don’t actually think it warrants one.
  58. jarolrod commented at 5:48 pm on September 26, 2022: member

    I’m going to remove “Needs release note” here (this will be in 24.0), as I don’t actually think it warrants one.

    In regards to #26176, perhaps a release note is needed.

  59. dekm referenced this in commit 513decbe7d on Oct 27, 2022
  60. Fabcien referenced this in commit 3b3fb90b24 on May 30, 2023
  61. kwvg referenced this in commit 549f96dd83 on Jun 20, 2023
  62. kwvg referenced this in commit 0858421687 on Jun 20, 2023
  63. kwvg referenced this in commit 5365419d3b on Jun 20, 2023
  64. kwvg referenced this in commit 59ba060dff on Jun 20, 2023
  65. kwvg referenced this in commit a95d9dbc8a on Jun 20, 2023
  66. kwvg referenced this in commit 29739eb8b5 on Jun 20, 2023
  67. kwvg referenced this in commit fa60cfb44e on Jun 28, 2023
  68. bitcoin locked this on Sep 26, 2023


fanquake DrahtBot Sjors monstrito hebasto jarolrod laanwj

Labels
macOS Build system Scripts and tools

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 09:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me