build: remove unneeded configure $*val setting #24671

pull fanquake wants to merge 29 commits into bitcoin:master from fanquake:remove_uneeded_configure_defaults changing 2 files +230 −226
  1. fanquake commented at 11:42 AM on March 25, 2022: member

    Setting these values has been redundant since autoconf ~2.60, and we require 2.69. Should not change behaviour. Includes minor formatting improvements.

    secp256k1 also recently made the same change: https://github.com/bitcoin-core/secp256k1/pull/1079.

  2. fanquake added the label Build system on Mar 25, 2022
  3. fanquake added the label DrahtBot Guix build requested on Mar 25, 2022
  4. fanquake commented at 11:42 AM on March 25, 2022: member

    cc @real-or-random

  5. real-or-random commented at 12:05 PM on March 25, 2022: contributor

    The automatic setting works only for variables enable_foo ( --enable-foo) or variables with_foo (--with-foo). But some of the removed assignments assign to use_foo or build_bitcoin_foo variables.

  6. fanquake removed the label DrahtBot Guix build requested on Mar 25, 2022
  7. fanquake commented at 12:16 PM on March 25, 2022: member

    The automatic setting works only for variables enable_foo ( --enable-foo) or variables with_foo (--with-foo).

    😅 Right. I guess we try should clean these up as well; given we currently use a mix of everything throughout configure.. Will update the changes.

  8. fanquake force-pushed on Mar 30, 2022
  9. fanquake commented at 8:29 PM on March 30, 2022: member

    Right. I guess we try should clean these up as well; given we currently use a mix of everything throughout configure.. Will update the changes.

    Have done this now. The changes are too granular as-is, and can be split-out / squashed down, but this should better reflect what we want to accomplish.

  10. jb55 commented at 9:08 PM on March 30, 2022: contributor

    ACK, tested that {enable,disable}-usdt still works

  11. DrahtBot commented at 4:49 AM on March 31, 2022: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #24958 (build: Fix macOS Apple M1 build with miniupnpc and libnatpmp. Again :) by hebasto)
    • #24798 ([POC] build: Hello Qt 6 by hebasto)
    • #24291 (build: Remove negated --enable-fuzz checks from build system by MarcoFalke)
    • #24051 (Bugfix: configure: bitcoin-{cli,tx,util} don't need UPnP, NAT-PMP, or ZMQ by luke-jr)
    • #22644 (Deprecate UPnP support, require 2.1 or later by fanquake)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  12. bitcoin deleted a comment on Mar 31, 2022
  13. DrahtBot added the label Needs rebase on Apr 5, 2022
  14. build: autoconfize --with-seccomp bb640da744
  15. build: autoconfize --enable-external-signer 45f7ad05ac
  16. build: autoconfize --disable-zmq dc1f954df3
  17. build: autoconfize --with-sanitizers 4f9004bd3a
  18. build: autoconfize --enable_usdt e92c6f667a
  19. build: autotoolize --enable-suppress-external-warnings e9b1f840f9
  20. build: autotoolize --enable-asm b03d3bf6ff
  21. build: autotoolize --enable-lto feb3f6e8ec
  22. build: autotoolize --enable-werror ebcb7ef813
  23. build: autotoolize --enable-gprof 95208ed27c
  24. build: autotoolize --enable-debug e593a63e1f
  25. build: autotoolize --disable-man 6ffec0f1d3
  26. build: autotoolize --multiprocess related flags 6dd2418756
  27. build: autotoolize --enable-threadlocal 832c0df56b
  28. build: autotoolize lcov flags 4e8f39a66c
  29. build: autotoolize --enable-ccache 2a085bd44c
  30. build: autotoolize --enable-reduce-exports 3e34bbb4c2
  31. build: autotoolize --enable-hardening ddcea824a8
  32. build: autotoolize --with-qrencode fa6328b332
  33. build: autotoolize --enable-fuzz* 8a13e95c18
  34. build: autotoolize --enable-extended-functional-tests a5513eb2f7
  35. build: autotoolize --enable-bench 4dea2cdaf7
  36. build: autotoolize --enable-gui-tests ecffefc6b5
  37. build: autotoolize --enable-tests 7294cb65b2
  38. build: autotoolize --with-natpmp* 184fb629a7
  39. build: autotoolize --enable-wallet 8d5933ac47
  40. build: autotoolize upnp 891deb9faf
  41. build: autotoolize --with-bdb ae6e709e26
  42. build: autotoolize --with-sqlite 92c9d75b4f
  43. fanquake force-pushed on Apr 20, 2022
  44. fanquake commented at 12:49 PM on April 20, 2022: member

    Rebased past #24391 and #24681. I'll start splitting a few changes off from here so we can move things forward.

  45. DrahtBot removed the label Needs rebase on Apr 20, 2022
  46. real-or-random commented at 11:25 AM on April 23, 2022: contributor

    I guess it's clear from the context but:

    Concept ACK

  47. DrahtBot added the label Needs rebase on Apr 28, 2022
  48. DrahtBot commented at 7:21 PM on April 28, 2022: contributor

    <!--cf906140f33d8803c4a75a2196329ecb-->

    🐙 This pull request conflicts with the target branch and needs rebase.

    <sub>Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".</sub>

  49. laanwj commented at 6:16 AM on June 2, 2022: member

    Concept and light code review ACK 92c9d75b4f55e853e8148ede2a3334af1bd3e204

  50. fanquake commented at 10:36 AM on August 31, 2022: member

    May follow up with some related changes later on.

  51. fanquake closed this on Aug 31, 2022
  52. bitcoin locked this on Aug 31, 2023
  53. fanquake deleted the branch on Sep 14, 2023
Contributors
fanquakereal-or-randomjb55DrahtBotlaanwj
Labels
Build systemNeeds rebase
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-26 06:13 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me