build: force CRCCheck in Windows installer #24111

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:force_win_installer_crccheck changing 1 files +1 −1

fanquake commented at 1:41 PM on January 20, 2022: member

Otherwise a user can pass /NCRC on the command line and bypass the CRC check, meaning they could use a corrupted installer. I can't think of a reason why we'd want to allow the use of corrupted installers.

NSIS docs:

Specifies whether or not the installer will perform a CRC on itself before allowing an install. Note that if the user uses /NCRC on the command line when executing the installer, and you didn't specify 'force', the CRC will not occur, and the user will be allowed to install a (potentially) corrupted installer.

build: force CRCCheck in Windows installer

Otherwise a user can pass /NCRC on the command line and bypass the
crc check, meaning they could install a potentially corrupted
installer.

b3ccf26df4

fanquake added the label Windows on Jan 20, 2022
fanquake added the label Build system on Jan 20, 2022
hebasto commented at 2:59 PM on January 20, 2022: member

Concept ACK.

While improving share/setup.nsi.in maybe incorporate 2646c062ba4e4ca510004f594581d44ecc937b81 from #22625?
laanwj commented at 7:14 PM on January 20, 2022: member

Is there anyone that still uses CRC for file corruption checks :smile: Well it's better than nothing, I guess. I don't see a reason for this to be overridable either.

Concept ACK.
laanwj added the label DrahtBot Guix build requested on Jan 20, 2022

DrahtBot commented at 7:40 PM on January 26, 2022: member

File	commit 9ec3991ad3b2ae91997c696a4c2f187fe538eff0<br>(master)	commit 664b9df3bc9e52c6f4e531d985cd149b47d31176<br>(master and this pull)
SHA256SUMS.part	`2e7b021f8a032087...`	`ed85100b10378927...`
*-aarch64-linux-gnu-debug.tar.gz	`f04dbee73b174e6f...`	`2711f0051329b531...`
*-aarch64-linux-gnu.tar.gz	`c754b36e82e33a9c...`	`14259f0e0eb5d7be...`
*-arm-linux-gnueabihf-debug.tar.gz	`25013d4ae19fb6f3...`	`3788f2378145644b...`
*-arm-linux-gnueabihf.tar.gz	`ec025145858460ce...`	`4bff6ca096d4b978...`
*-osx-unsigned.dmg	`dd865c6fd4218a09...`	`74c83cfbca3de1cb...`
*-osx-unsigned.tar.gz	`f2adf40f7d956e6e...`	`158b159113567caa...`
*-osx64.tar.gz	`9bf700786395a8fb...`	`0ef4131e46bcb610...`
*-powerpc64-linux-gnu-debug.tar.gz	`eba65aa8eaec1c89...`	`9134c109b8f67f4f...`
*-powerpc64-linux-gnu.tar.gz	`3312edee780236ee...`	`cb6b1339250a313b...`
*-powerpc64le-linux-gnu-debug.tar.gz	`4ccd57dd41f448eb...`	`80bc4d84247a68b9...`
*-powerpc64le-linux-gnu.tar.gz	`025f050dd642ca2f...`	`7f26f38542480f6f...`
*-riscv64-linux-gnu-debug.tar.gz	`9c3dfcba4deadf0b...`	`2314268cd4abcbf8...`
*-riscv64-linux-gnu.tar.gz	`54f25a0d36c806fa...`	`ddbd8a0e70900f71...`
*-x86_64-linux-gnu-debug.tar.gz	`63ebd6c1a1137971...`	`b09bf41ebe2f9516...`
*-x86_64-linux-gnu.tar.gz	`1be184e1c61ed869...`	`ff90aa4c9c58ae05...`
*.tar.gz	`d399991ce771ba6c...`	`85a7254a99c0b58d...`
guix_build.log	`334f236ac4ef766b...`	`ecb6fd3eeb6552d0...`
guix_build.log.diff		`a60adc2682d5d529...`

DrahtBot removed the label DrahtBot Guix build requested on Jan 26, 2022
MarcoFalke commented at 6:36 AM on January 27, 2022: member

DrahtBot didn't actually build the windows installer, because the Windows build isn't working right now.
fanquake commented at 8:02 AM on January 27, 2022: member

While improving share/setup.nsi.in maybe incorporate 2646c06 from #22625?

Happy for you to PR this separately. I'd rather keep this change simple and obviously correct.
MarcoFalke added this to the milestone 23.0 on Jan 27, 2022
hebasto approved
hebasto commented at 9:41 PM on January 28, 2022: member

ACK b3ccf26df47c70e7559625a0e65205648f64efb7, I have reviewed the code and it looks OK, I agree it can be merged.
prusnak approved
prusnak commented at 9:08 AM on January 30, 2022: contributor

utACK b3ccf26df47c70e7559625a0e65205648f64efb7

checked against the documentation in https://nsis.sourceforge.io/Reference/CRCCheck
fanquake merged this on Jan 31, 2022
fanquake closed this on Jan 31, 2022
fanquake deleted the branch on Jan 31, 2022
sidhujag referenced this in commit 72b56ddd22 on Feb 1, 2022
DrahtBot locked this on Jan 31, 2023

Contributors

Labels

Milestone
23.0