Looks like this hasn't been needed since https://github.com/chaincodelabs/libmultiprocess/pull/25 and was just missed in #19160.
build: remove boost dep from libmultiprocess #24385
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:boost_less_multiprocess changing 1 files +1 −1-
fanquake commented at 3:16 PM on February 18, 2022: member
-
07dcf1a76e
build: remove boost dep from libmultiprocess
Looks like this hasn't been needed since https://github.com/chaincodelabs/libmultiprocess/pull/25 and was just missed in #19160.
- fanquake added the label Build system on Feb 18, 2022
- fanquake requested review from ryanofsky on Feb 18, 2022
- MarcoFalke added the label DrahtBot Guix build requested on Feb 18, 2022
-
ryanofsky commented at 6:32 PM on February 18, 2022: member
Code review ACK 07dcf1a76e34a6f7c919e7d5c57fa61caea6007b. Should probably wait for GUIX build results, but I think this should be fine
-
fanquake commented at 9:46 AM on February 19, 2022: member
Should probably wait for GUIX build results, but I think this should be fine
We don't do anything multiprocess related in the Guix build, so this change shouldn't make a difference. However I ran a build in any case:
bash-5.1# find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum 44d80adc3c9f53fb6626ccaf27e90cf347920d78b843783994e64f700b1064a4 guix-build-07dcf1a76e34/output/aarch64-linux-gnu/SHA256SUMS.part 74a7104de9c34300146f01d6706113080ff49b342a78889b3718bce090f35848 guix-build-07dcf1a76e34/output/aarch64-linux-gnu/bitcoin-07dcf1a76e34-aarch64-linux-gnu-debug.tar.gz 4eaf81b1f0b3f470b854f178c5a9c62409c8005e314a9ba92461d6c9b14306af guix-build-07dcf1a76e34/output/aarch64-linux-gnu/bitcoin-07dcf1a76e34-aarch64-linux-gnu.tar.gz e23206c0c50f55301e6268f85aff15c776e17dfc9969c06a464d75c580779afe guix-build-07dcf1a76e34/output/arm-linux-gnueabihf/SHA256SUMS.part b68741814af870ac27a1a5aefb173ba9f6015fe995bfecf06d57b1f12053b2ce guix-build-07dcf1a76e34/output/arm-linux-gnueabihf/bitcoin-07dcf1a76e34-arm-linux-gnueabihf-debug.tar.gz 7c50a5661458064ff08a64362f8e775cea76cce762f1ccd485b8739aced6ed22 guix-build-07dcf1a76e34/output/arm-linux-gnueabihf/bitcoin-07dcf1a76e34-arm-linux-gnueabihf.tar.gz 9dbc97c2cd6c46c91c428bfca3b77dca643e9993e04b068fd7e6827b2f7379bf guix-build-07dcf1a76e34/output/arm64-apple-darwin/SHA256SUMS.part 5d2933846965e3117e4e3ca4834ed4bf546dd3e03f82eefbc2cbef8d048158a0 guix-build-07dcf1a76e34/output/arm64-apple-darwin/bitcoin-07dcf1a76e34-arm64-apple-darwin.tar.gz 7633919850e4a93b6298315100f5e28b50e7030a299582bea7f509fe88e1e74a guix-build-07dcf1a76e34/output/arm64-apple-darwin/bitcoin-07dcf1a76e34-osx-unsigned.dmg cfc7fddb9e88981f643ec381ad5eb2a87733b3708471ff7925057eaa4c1b995d guix-build-07dcf1a76e34/output/arm64-apple-darwin/bitcoin-07dcf1a76e34-osx-unsigned.tar.gz d88335eae12ef559de0581e535350948c030cd71eed6f8ce2a14c974239185da guix-build-07dcf1a76e34/output/dist-archive/bitcoin-07dcf1a76e34.tar.gz 4c6624af196ef09cf0f37a74bdd88afa39df2066b48f455ee1e2b9775ae2fb31 guix-build-07dcf1a76e34/output/powerpc64-linux-gnu/SHA256SUMS.part 7ca78a6e54e9d60df70cb5221b426ec20098d8cdb770716ed330f765cfd5a7f9 guix-build-07dcf1a76e34/output/powerpc64-linux-gnu/bitcoin-07dcf1a76e34-powerpc64-linux-gnu-debug.tar.gz bb8df03a056a534b1be371a3e86ad6564dd468ad4a65a58abe5a727f6371ad50 guix-build-07dcf1a76e34/output/powerpc64-linux-gnu/bitcoin-07dcf1a76e34-powerpc64-linux-gnu.tar.gz f679f3487cfa6648de079c719faee427443df4ba0efc3d89652aef217e5fb9c6 guix-build-07dcf1a76e34/output/powerpc64le-linux-gnu/SHA256SUMS.part 63cbb9ce94def726bc92458d2b2090c35e23d27e1633611da70d9a52fe70d0f0 guix-build-07dcf1a76e34/output/powerpc64le-linux-gnu/bitcoin-07dcf1a76e34-powerpc64le-linux-gnu-debug.tar.gz d4cf1523fb902f5b1d145813c6009ba8f964e7c25295490e809056a3f7e1b654 guix-build-07dcf1a76e34/output/powerpc64le-linux-gnu/bitcoin-07dcf1a76e34-powerpc64le-linux-gnu.tar.gz f4a48cd1ecf7606d77f9e18d68c0c6f1268bbc7311b62414f63437e9475d6150 guix-build-07dcf1a76e34/output/riscv64-linux-gnu/SHA256SUMS.part b2f4466cbb4186edda54fdbc00b6594a10aef3c90db17ab71f00c3e43af9576a guix-build-07dcf1a76e34/output/riscv64-linux-gnu/bitcoin-07dcf1a76e34-riscv64-linux-gnu-debug.tar.gz 4aaabe04dd3a46c3409d597e3661288458a669789ce19d171183dbe46abab8fe guix-build-07dcf1a76e34/output/riscv64-linux-gnu/bitcoin-07dcf1a76e34-riscv64-linux-gnu.tar.gz 9671cff5d17d0066d5d1c3fb0cd242b16395cda3d96c8b9fde954759ad6a15ab guix-build-07dcf1a76e34/output/x86_64-apple-darwin/SHA256SUMS.part d99ab7de2a1485437d4bedcd791c74b77674b68799ac96d7cd56064509c95a74 guix-build-07dcf1a76e34/output/x86_64-apple-darwin/bitcoin-07dcf1a76e34-osx-unsigned.dmg eaac885c648139b7565e0f883bb0a338fa55cc14fbdfeca923007b51e2a98d8b guix-build-07dcf1a76e34/output/x86_64-apple-darwin/bitcoin-07dcf1a76e34-osx-unsigned.tar.gz 41b1e0e28d065242d71870bc15ac91e22d0ec28c85b07ede5827484194c03df4 guix-build-07dcf1a76e34/output/x86_64-apple-darwin/bitcoin-07dcf1a76e34-osx64.tar.gz 8802dd4545919783e03c4783324794cfd931ae8125967c8b8423aab035bc491e guix-build-07dcf1a76e34/output/x86_64-linux-gnu/SHA256SUMS.part c1c5b7487151902b5afa0f9e1e1846db1a22f315c77efc468173590ea729b117 guix-build-07dcf1a76e34/output/x86_64-linux-gnu/bitcoin-07dcf1a76e34-x86_64-linux-gnu-debug.tar.gz 36b5b9b5163a2afbc309ac3f965b7bd582d6b6ac7bf666cc9505892e39e35387 guix-build-07dcf1a76e34/output/x86_64-linux-gnu/bitcoin-07dcf1a76e34-x86_64-linux-gnu.tar.gz 6c7a8cced36460e3fb1e9c2389012736c9de7e956e52bc66e030bc6bc53ebc5e guix-build-07dcf1a76e34/output/x86_64-w64-mingw32/SHA256SUMS.part 906adb1cdcaecf7afeccc3188c48da0ca1a401cfc23dee832cae713ccfc4d1c8 guix-build-07dcf1a76e34/output/x86_64-w64-mingw32/bitcoin-07dcf1a76e34-win-unsigned.tar.gz 554ddb3bae9803884b9df9536e569d4a0cf42c3a624a494d09513986c17908aa guix-build-07dcf1a76e34/output/x86_64-w64-mingw32/bitcoin-07dcf1a76e34-win64-debug.zip e3c1e148799ff32c277ed3bb557d8b207d441a6d45641c27c6bbc143da5de32b guix-build-07dcf1a76e34/output/x86_64-w64-mingw32/bitcoin-07dcf1a76e34-win64-setup-unsigned.exe b21c8c1a993c27ba50c4dd057fc5dbd94292c83a9f4fa002d4ff3fc88382a98e guix-build-07dcf1a76e34/output/x86_64-w64-mingw32/bitcoin-07dcf1a76e34-win64.zip -
MarcoFalke commented at 9:49 AM on February 19, 2022: member
Yeah, I only assigned the label to give Drahty something to work on
- hebasto approved
-
hebasto commented at 9:58 AM on February 19, 2022: member
ACK 07dcf1a76e34a6f7c919e7d5c57fa61caea6007b
- MarcoFalke merged this on Feb 19, 2022
- MarcoFalke closed this on Feb 19, 2022
- fanquake deleted the branch on Feb 19, 2022
- sidhujag referenced this in commit 1e44c5729f on Feb 20, 2022
-
DrahtBot commented at 1:05 AM on February 21, 2022: member
<!--9cd9c72976c961c55c7acef8f6ba82cd-->
Guix builds
- DrahtBot removed the label DrahtBot Guix build requested on Feb 21, 2022
- DrahtBot locked this on Feb 21, 2023
Contributors
Labels