contrib: fix implicit function decleration in win symbol check #24491

fanquake commented at 12:14 PM on March 7, 2022: member

test3.c: In function 'main':
test3.c:6:21: warning: implicit declaration of function 'CoFreeUnusedLibrariesEx' [-Wimplicit-function-declaration]
    6 |                     CoFreeUnusedLibrariesEx(0,0);

bash-5.1# find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
1907745369f13b0b01583795e395b7e8ecda174a8a3b6309184b14609bfdcb20  guix-build-e4e9dd3a287f/output/dist-archive/bitcoin-e4e9dd3a287f.tar.gz
6973025bd46acdbc327118541f26d36885434305d20a7fa33e0db61f66f8b930  guix-build-e4e9dd3a287f/output/x86_64-w64-mingw32/SHA256SUMS.part
4cdc4efc0d27b3fcfb8f36244dfd956d19ae5df0414dcc23e733c88188f1f93a  guix-build-e4e9dd3a287f/output/x86_64-w64-mingw32/bitcoin-e4e9dd3a287f-win-unsigned.tar.gz
022e9743b13f5366cd0f4b52ff8350b42d8c6a506c98363071501a6c4ac735f1  guix-build-e4e9dd3a287f/output/x86_64-w64-mingw32/bitcoin-e4e9dd3a287f-win64-debug.zip
62e65f04fdcacb3d3fbcffbea5204f723f2b27a5f9a62a77abaf0b7ee7de3744  guix-build-e4e9dd3a287f/output/x86_64-w64-mingw32/bitcoin-e4e9dd3a287f-win64-setup-unsigned.exe
d773f5ba6afe456b7b5286f0cf98bcb711da8087b96a31f2e38f9c43af44fe96  guix-build-e4e9dd3a287f/output/x86_64-w64-mingw32/bitcoin-e4e9dd3a287f-win64.zip

contrib: fix implicit function decleration in win symbol check

```bash
test3.c: In function 'main':
test3.c:6:21: warning: implicit declaration of function 'CoFreeUnusedLibrariesEx' [-Wimplicit-function-declaration]
    6 |                     CoFreeUnusedLibrariesEx(0,0);
```

e4e9dd3a28

fanquake added the label Windows on Mar 7, 2022

fanquake added the label Scripts and tools on Mar 7, 2022

fanquake added the label DrahtBot Guix build requested on Mar 7, 2022

DrahtBot commented at 2:46 PM on March 11, 2022: member

Guix builds

File	commit 430acb7d2a3272977d5a66bf9a09bcd55ffd15cc<br>(master)	commit 035953292253a2ca909645439e1bf8a14776366d<br>(master and this pull)
SHA256SUMS.part	`fb014fad3fa7aa59...`	`df3694335e832afd...`
*-aarch64-linux-gnu-debug.tar.gz	`df084f3f391f3b30...`	`fce0fb94b187cbcb...`
*-aarch64-linux-gnu.tar.gz	`056cc044240e3b9b...`	`effb0817acf2c1a9...`
*-arm-linux-gnueabihf-debug.tar.gz	`1a729da7dd2859b3...`	`e3e00e97fa44fb67...`
*-arm-linux-gnueabihf.tar.gz	`a70d3ec700c6c426...`	`678ffbf9cc33d79c...`
*-arm64-apple-darwin.tar.gz	`a843d0e0f00f4e61...`	`163d0a7af41b6517...`
*-osx-unsigned.dmg	`3b217a066a32ba86...`	`278bcb483dd9fa8a...`
*-osx-unsigned.tar.gz	`2a0d18ac34d25d7a...`	`d19e51c5e33bb101...`
*-osx64.tar.gz	`df01dbf2a0ac86ef...`	`2b2f1cdebd8ce414...`
*-powerpc64-linux-gnu-debug.tar.gz	`eb6ac4df7b7338aa...`	`fb42ea77b7b64c3b...`
*-powerpc64-linux-gnu.tar.gz	`0abd80b965a25241...`	`f5d6194240c2c766...`
*-powerpc64le-linux-gnu-debug.tar.gz	`f115fd1e034aba4b...`	`850fb27ba7a91a08...`
*-powerpc64le-linux-gnu.tar.gz	`4e8837fef05b9f0f...`	`184373aa8b923327...`
*-riscv64-linux-gnu-debug.tar.gz	`a195ab9732c37c4b...`	`35b565066b308ce1...`
*-riscv64-linux-gnu.tar.gz	`398d3e148f6a0e35...`	`ddab3225c1874e9a...`
*-win-unsigned.tar.gz	`ea1130eb74154e46...`	`b36c612a7bf455d2...`
*-win64-debug.zip	`31b6035d954db528...`	`6350d45654abd67a...`
*-win64-setup-unsigned.exe	`fdf630b5c1e3f100...`	`b9c2a14682eba0de...`
*-win64.zip	`6a8722cf2cc5d043...`	`747a65370a92231b...`
*-x86_64-linux-gnu-debug.tar.gz	`df75c9fb5f231c24...`	`1e77dbd94f9a16c7...`
*-x86_64-linux-gnu.tar.gz	`c317fd545e9a7443...`	`91cb70858d58e043...`
*.tar.gz	`c838b19962382eca...`	`6a3e92e4f84224ef...`
guix_build.log	`96b1eab2b1b02fe4...`	`0ce42766c48fbdcd...`
guix_build.log.diff		`6bdf7c827f4546ab...`

DrahtBot removed the label DrahtBot Guix build requested on Mar 11, 2022

hebasto approved

hebasto commented at 1:48 AM on March 12, 2022: member

ACK e4e9dd3a287f134356044f636e189da704de8ed4, tested on Ubuntu 22.04.

Guix build on `x86_64`:

$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
1907745369f13b0b01583795e395b7e8ecda174a8a3b6309184b14609bfdcb20  guix-build-e4e9dd3a287f/output/dist-archive/bitcoin-e4e9dd3a287f.tar.gz
6973025bd46acdbc327118541f26d36885434305d20a7fa33e0db61f66f8b930  guix-build-e4e9dd3a287f/output/x86_64-w64-mingw32/SHA256SUMS.part
4cdc4efc0d27b3fcfb8f36244dfd956d19ae5df0414dcc23e733c88188f1f93a  guix-build-e4e9dd3a287f/output/x86_64-w64-mingw32/bitcoin-e4e9dd3a287f-win-unsigned.tar.gz
022e9743b13f5366cd0f4b52ff8350b42d8c6a506c98363071501a6c4ac735f1  guix-build-e4e9dd3a287f/output/x86_64-w64-mingw32/bitcoin-e4e9dd3a287f-win64-debug.zip
62e65f04fdcacb3d3fbcffbea5204f723f2b27a5f9a62a77abaf0b7ee7de3744  guix-build-e4e9dd3a287f/output/x86_64-w64-mingw32/bitcoin-e4e9dd3a287f-win64-setup-unsigned.exe
d773f5ba6afe456b7b5286f0cf98bcb711da8087b96a31f2e38f9c43af44fe96  guix-build-e4e9dd3a287f/output/x86_64-w64-mingw32/bitcoin-e4e9dd3a287f-win64.zip

nit: typo in commit message: decleration --> declaration

laanwj commented at 8:23 AM on March 13, 2022: member

Code review ACK e4e9dd3a287f134356044f636e189da704de8ed4

laanwj merged this on Mar 13, 2022

laanwj closed this on Mar 13, 2022

fanquake deleted the branch on Mar 13, 2022

DrahtBot locked this on Mar 13, 2023

contrib: fix implicit function decleration in win symbol check #24491

Guix builds

Guix build on x86_64:

Guix build on `x86_64`: