[23.x] qt: Avoid crash on startup if int specified in settings.json #24511

1. 
   achow101 commented at 4:04 PM on March 9, 2022: member

   Backport of #24498

2. test: Add tests for GetArg methods / settings.json type coercion

   Just add tests. No changes to application behavior. Tests will be
   updated in the next commit changing & improving current behavior.
   
   Include a Qt test for GUI startup crash reported by Rspigler in
   https://github.com/bitcoin/bitcoin/issues/24457 caused by GetArg
   behavior that happens if settings.json contains an integer value for any
   of the configuration options which GUI settings can currently clash with
   (-dbcache, -par, -spendzeroconfchange, -signer, -upnp, -natpmp, -listen,
   -server, -proxy, -proxy, -onion, -onion, -lang, and -prune).
   
   Github-Pull: bitcoin/bitcoin#24498
   Rebased-From: 84b0973e35dae63cd1b60199b481e24d54e58c97

   4607f700d0
3. qt: Avoid crash on startup if int specified in settings.json

   Fix GUI startup crash reported by Rspigler in
   https://github.com/bitcoin/bitcoin/issues/24457 that happens if
   settings.json contains an integer value for any of the configuration
   options which GUI settings can currently clash with (-dbcache, -par,
   -spendzeroconfchange, -signer, -upnp, -natpmp, -listen, -server, -proxy,
   -proxy, -onion, -onion, -lang, and -prune).
   
   Fix is a one-line change in ArgsManager::GetArg.
   
   Github-Pull: bitcoin/bitcoin#24498
   Rebased-From: 5b1aae12ca4a99c6b09349981a4902717a6a5d3e

   7e1b968f61
4. fanquake added the label Backport on Mar 9, 2022
5. fanquake added this to the milestone 23.0 on Mar 9, 2022
6. 
   jonatack commented at 4:36 PM on March 9, 2022: member

   ACK 7e1b968f61a1309dfd0fc4f7cd5a2d964bfc4f30

7. ryanofsky approved
8. 
   ryanofsky commented at 6:07 PM on March 9, 2022: member

   ACK confirmed conflict-free backport with no changes using script (https://github.com/bitcoin/bitcoin/pull/11592#pullrequestreview-73922693)

9. fanquake merged this on Mar 10, 2022
10. fanquake closed this on Mar 10, 2022

    ---

11. laanwj referenced this in commit 04fdd644b4 on May 25, 2022
12. DrahtBot locked this on Mar 10, 2023

Milestone
23.0