[22.x] qt: Avoid crash on startup if int specified in settings.json #25180

1. 
   ryanofsky commented at 5:34 PM on May 20, 2022: member

   Backport of #24498 to 22.x branch

   This was already backported to the 23.x branch in #24511, but vasild discovered the issue can affect 22.x as well #15936 (comment):

   While testing this, 22.x crashes if settings.json contains "prune": 1234 due to #24498 which was fixed in 23.0. So, if this PR is included in 24.x and a user upgrades to 24.x and then downgrades to 22.x his 22.x would crash at startup.

   It's not very important to backport this to 22.x because I can work around the issue other ways, but I do see 22.x is listed as an active branch https://github.com/bitcoin/bitcoin/branches, so if there is another 22.x release, it would be nice to have this fix and not have a wonky uncaught univalue exception waiting to be hit

2. qt: Avoid crash on startup if int specified in settings.json

   Fix GUI startup crash reported by Rspigler in
   https://github.com/bitcoin/bitcoin/issues/24457 that happens if
   settings.json contains an integer value for any of the configuration
   options which GUI settings can currently clash with (-dbcache, -par,
   -spendzeroconfchange, -signer, -upnp, -natpmp, -listen, -server, -proxy,
   -proxy, -onion, -onion, -lang, and -prune).
   
   Fix is a one-line change in ArgsManager::GetArg.
   
   Github-Pull: bitcoin/bitcoin#24498
   Rebased-From: 5b1aae12ca4a99c6b09349981a4902717a6a5d3e

   344537cf04
3. DrahtBot added the label Backport on May 20, 2022
4. laanwj added this to the milestone 22.1 on May 24, 2022
5. 
   laanwj commented at 10:23 AM on May 25, 2022: member

   ACK 344537cf04373d757522e042f29f25a0f9595404

6. laanwj merged this on May 25, 2022
7. laanwj closed this on May 25, 2022

   ---

8. DrahtBot locked this on May 25, 2023

Milestone
22.1