doc: add more info to dependencies.md #24586

prusnak commented at 4:46 PM on March 16, 2022: contributor

Follow-up to #23565

I added more info to dependencies.md - especially links to depends/packages/*.mk files and link to PRs where used versions were bumped.

Preview at: https://github.com/prusnak/bitcoin/blob/dependencies/doc/dependencies.md

prusnak force-pushed on Mar 16, 2022

DrahtBot added the label Docs on Mar 16, 2022

DrahtBot commented at 8:52 PM on March 21, 2022: member

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#22644 (Deprecate UPnP support, require 2.1 or later by fanquake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

DrahtBot added the label Needs rebase on Apr 4, 2022

in doc/dependencies.md:48 in e1eb823da9 outdated

  65 | -| --- | --- | --- | --- |
  66 | -| [Berkeley DB](https://www.oracle.com/technetwork/database/database-technologies/berkeleydb/downloads/index.html) (legacy wallet) | 4.8.30 | 4.8.x | No |
  67 | -| [SQLite](https://sqlite.org) | 3.32.1 | [3.7.17](https://github.com/bitcoin/bitcoin/pull/19077) | No |
  68 | +| Dependency | Releases | Version used | Minimum required | Runtime |
  69 | +| --- | --- | --- | --- | --- |
  70 | +| [Berkeley DB](../depends/packages/bdb.mk  )  (legacy wallet) | [link](https://www.oracle.com/technetwork/database/database-technologies/berkeleydb/downloads/index.html) | 4.8.30 | 4.8.x | No |

laanwj commented at 11:14 AM on April 4, 2022:

Some extra spaces within (…) here

prusnak commented at 12:38 PM on April 13, 2022:

Fixed in 39bd6843c5349503a4e8aec819838290e954c728

laanwj commented at 11:14 AM on April 4, 2022: member

Concept ACK

prusnak force-pushed on Apr 13, 2022

prusnak commented at 12:38 PM on April 13, 2022: contributor

Rebased => 39bd6843c5349503a4e8aec819838290e954c728

DrahtBot removed the label Needs rebase on Apr 13, 2022

in doc/dependencies.md:20 in 39bd6843c5 outdated

  16 | @@ -17,33 +17,33 @@ You can find installation instructions in the `build-*.md` file for your platfor
  17 |  
  18 |  | Dependency | Version used | Minimum required | Runtime |
  19 |  | --- | --- | --- | --- |
  20 | -| [Boost](https://www.boost.org/users/download/) | 1.77.0 | [1.64.0](https://github.com/bitcoin/bitcoin/pull/22320) | No |
  21 | -| [libevent](https://github.com/libevent/libevent/releases) | 2.1.12-stable | [2.1.8](https://github.com/bitcoin/bitcoin/pull/24681) | No |
  22 | +| [Boost](../depends/packages/boost.mk) | [link](https://www.boost.org/users/download/) | [1.77.0](https://github.com/bitcoin/bitcoin/pull/24383) | [1.64.0](https://github.com/bitcoin/bitcoin/pull/22320) | No |

laanwj commented at 6:59 PM on April 13, 2022:

I think something went wrong; versions ends up in the "runtime" column here.

prusnak commented at 8:56 AM on April 15, 2022:

Fixed in 128e4ed02c03ce8c4ce206f5858dd787d06e1a18

prusnak force-pushed on Apr 15, 2022

in doc/dependencies.md:43 in 128e4ed02c outdated

  56 | -| Dependency | Version used | Minimum required | Runtime |
  57 | -| --- | --- | --- | --- |
  58 | -| [ZeroMQ](https://zeromq.org) | 4.3.4 | 4.0.0 | No |
  59 | +| Dependency | Releases | Version used | Minimum required | Runtime |
  60 | +| --- | --- | --- | --- | --- |
  61 | +| [ZeroMQ](../depends/packages/zeromq.mk) | [link](https://zeromq.org) | [4.3.4](https://github.com/bitcoin/bitcoin/pull/23956) | 4.0.0 | No |

mruddy commented at 12:06 PM on April 17, 2022:

nit: while you're changing this file...the zeromq release link is actually https://github.com/zeromq/libzmq/releases this was changed by #23565. in my opinion, https://zeromq.org is less useful.

prusnak commented at 12:34 PM on April 17, 2022:

Agreed, addressed in f9c6df545efa3ca804f99dd3d7c3022cf313f27e

mruddy commented at 12:08 PM on April 17, 2022: contributor

Concept ACK with the one zeromq nit that you can choose to address or not as it's a matter of opinion

prusnak force-pushed on Apr 17, 2022

in doc/dependencies.md:22 in f9c6df545e outdated

  22 | -| [glibc](https://www.gnu.org/software/libc/) | N/A | [2.18](https://github.com/bitcoin/bitcoin/pull/23511) | Yes |
  23 | +| Dependency | Releases | Version used | Minimum required | Runtime |
  24 | +| --- | --- | --- | --- | --- |
  25 | +| [Boost](../depends/packages/boost.mk) | [link](https://www.boost.org/users/download/) | [1.77.0](https://github.com/bitcoin/bitcoin/pull/24383) | [1.64.0](https://github.com/bitcoin/bitcoin/pull/22320) | No |
  26 | +| [libevent](../depends/packages/libevent.mk) | [link](https://github.com/libevent/libevent/releases) | [2.1.12-stable](https://github.com/bitcoin/bitcoin/pull/21991) | [2.1.8](https://github.com/bitcoin/bitcoin/pull/24681) | No |
  27 | +| glibc | [link](https://www.gnu.org/software/libc/) | [2.18](https://github.com/bitcoin/bitcoin/pull/23511) | Yes |

fanquake commented at 1:17 PM on April 20, 2022:

| glibc | [link](https://www.gnu.org/software/libc/) | N/A | [2.18](https://github.com/bitcoin/bitcoin/pull/23511) | Yes |

You've dropped N/A from Version Used in the glibc column, which has broken the table.

Screen Shot 2022-04-20 at 2 17 08 pm

prusnak commented at 1:22 PM on April 20, 2022:

Good catch! Fixed in abcb8769bf1d8ed227e6abddd7250a613e91277d

doc: add more info to dependencies.md abcb8769bf

prusnak force-pushed on Apr 20, 2022

fanquake approved

fanquake commented at 1:36 PM on April 20, 2022: member

ACK abcb8769bf1d8ed227e6abddd7250a613e91277d - I didn't click on or test all of the links, but this looks ok.

fanquake merged this on Apr 21, 2022

fanquake closed this on Apr 21, 2022

prusnak deleted the branch on Apr 21, 2022

sidhujag referenced this in commit 758b31b0d3 on Apr 22, 2022

DrahtBot locked this on Apr 21, 2023