build, qt: bump Qt5 version to 5.15.3 #24668

pull prusnak wants to merge 3 commits into bitcoin:master from prusnak:qt5-5.15.3 changing 10 files +36 −204
  1. prusnak commented at 9:34 AM on March 25, 2022: contributor

    build, qt: bump Qt5 version to 5.15.3

    Qt 5.15.3 release is a patch release made on the top of Qt 5.15.2. As a patch release, Qt 5.15.3 does not add any new functionality but provides bug fixes and other improvements.

    https://code.qt.io/cgit/qt/qtreleasenotes.git/about/qt/5.15.3/release-note.md

    • dropped patches:
      • patches/qt/dont_use_avx_android_x86_64.patch
      • patches/qt/fix_bigsur_style.patch
    • adjusted patches:
      • patches/qt/fix_android_jni_static.patch
      • patches/qt/fix_limits_header.patch
      • patches/qt/use_android_ndk23.patch
  2. prusnak closed this on Mar 25, 2022
  3. prusnak reopened this on Mar 25, 2022
  4. hebasto commented at 9:45 AM on March 25, 2022: member

    Qt 5.15.3 does not add any new functionality but provides bug fixes and other improvements.

    Are there explicit benefits for our project?

    UPDATE: Could dont_use_avx_android_x86_64.patch and fix_limits_header.patch be dropped now?

  5. hebasto commented at 9:56 AM on March 25, 2022: member

    I've restarted CI: https://cirrus-ci.com/build/6411581146791936

  6. prusnak force-pushed on Mar 25, 2022
  7. MarcoFalke added the label DrahtBot Guix build requested on Mar 25, 2022
  8. prusnak commented at 10:00 AM on March 25, 2022: contributor

    Are there explicit benefits for our project? ... UPDATE: Could dont_use_avx_android_x86_64.patch and fix_limits_header.patch be dropped now?

    Right, we can now drop the following (upstreamed) patches:

    • dont_use_avx_android_x86_64.patch
    • fix_limits_header.patch
    • fix_bigsur_style.patch

    I force pushed c959d296c879e9f628504cb070c26bcbbbf12926 which drops these patches.

    I went through the release notes and there are macOS rendering fixes included in the release. Some of them were backported in fix_bigsur_style.patch but maybe there are more ...

  9. in depends/packages/qt.mk:21 in c959d296c8 outdated 
      16 | +$(package)_patches += dont_hardcode_x86_64.patch fix_montery_include.patch
  17 |  $(package)_patches += fix_android_jni_static.patch dont_hardcode_pwd.patch
  18 | -$(package)_patches += qtbase-moc-ignore-gcc-macro.patch fix_limits_header.patch
  19 | -$(package)_patches += fix_bigsur_style.patch use_android_ndk23.patch
  20 | +$(package)_patches += qtbase-moc-ignore-gcc-macro.patch
  21 | +$(package)_patches += use_android_ndk23.patch
    hebasto commented at 10:07 AM on March 25, 2022:

    Our fix_limits_header.patch has broader changes than the https://github.com/qt/qtbase/commit/0afad46bb71b106780dd641de768a81d9f6c6a51 commit.

    prusnak commented at 10:20 AM on March 25, 2022:

    That's unfortunate ... fixed in 393acc41

  10. prusnak force-pushed on Mar 25, 2022
  11. hebasto commented at 10:24 AM on March 25, 2022: member

    Right, we can now drop the following (upstreamed) patches:

    * `dont_use_avx_android_x86_64.patch`

* `fix_limits_header.patch`

* `fix_bigsur_style.patch`

    I force pushed c959d29 which drops these patches.

    I went through the release notes and there are macOS rendering fixes included in the release. Some of them were backported in fix_bigsur_style.patch but maybe there are more ...

    I've verified that all changes in our fix_bigsur_style.patch are backported into 5.15.3:

    I've verified that all changes in our dont_use_avx_android_x86_64.patch are backported into 5.15.3:

  12. hebasto commented at 10:26 AM on March 25, 2022: member

    Concept ACK.

  13. prusnak force-pushed on Mar 25, 2022
  14. hebasto commented at 11:37 AM on March 25, 2022: member

    To adjust other Qt patches, suggesting the following changes:

    diff --git a/depends/patches/qt/fix_android_jni_static.patch b/depends/patches/qt/fix_android_jni_static.patch
index bb6466176..22a4d5ab0 100644
--- a/depends/patches/qt/fix_android_jni_static.patch
+++ b/depends/patches/qt/fix_android_jni_static.patch
@@ -1,6 +1,6 @@
 --- old/qtbase/src/plugins/platforms/android/androidjnimain.cpp
 +++ new/qtbase/src/plugins/platforms/android/androidjnimain.cpp
-@@ -914,6 +914,14 @@ Q_DECL_EXPORT jint JNICALL JNI_OnLoad(JavaVM *vm, void */*reserved*/)
+@@ -934,6 +934,14 @@ Q_DECL_EXPORT jint JNICALL JNI_OnLoad(JavaVM *vm, void */*reserved*/)
          __android_log_print(ANDROID_LOG_FATAL, "Qt", "registerNatives failed");
          return -1;
      }
diff --git a/depends/patches/qt/use_android_ndk23.patch b/depends/patches/qt/use_android_ndk23.patch
index 85b869021..f22367d52 100644
--- a/depends/patches/qt/use_android_ndk23.patch
+++ b/depends/patches/qt/use_android_ndk23.patch
@@ -2,7 +2,7 @@ Use Android NDK r23 LTS
 
 --- old/qtbase/mkspecs/features/android/default_pre.prf
 +++ new/qtbase/mkspecs/features/android/default_pre.prf
-@@ -73,7 +73,7 @@ else: equals(QT_ARCH, x86_64): CROSS_COMPILE = $$NDK_LLVM_PATH/bin/x86_64-linux-
+@@ -76,7 +76,7 @@ else: equals(QT_ARCH, x86_64): CROSS_COMPILE = $$NDK_LLVM_PATH/bin/x86_64-linux-
  else: equals(QT_ARCH, arm64-v8a): CROSS_COMPILE = $$NDK_LLVM_PATH/bin/aarch64-linux-android-
  else: CROSS_COMPILE = $$NDK_LLVM_PATH/bin/arm-linux-androideabi-
  15. prusnak force-pushed on Mar 25, 2022
  16. prusnak commented at 12:15 PM on March 25, 2022: contributor

    To adjust other Qt patches, suggesting the following changes:

    Done in d6042b57265d5e42899ce8f6d2a1a0f6d354200a

  17. hebasto commented at 12:17 PM on March 25, 2022: member

    Approach ACK d6042b57265d5e42899ce8f6d2a1a0f6d354200a.

  18. hebasto commented at 1:19 PM on March 25, 2022: member

    Some notes about depends/patches/qt/fix_limits_header.patch:

    1. Apparently, patching of qtbase/src/tools/moc/generator.cpp was required only for Qt 5.12.11. It even is not required on the current master branch for Qt 5.15.2. Therefore, it seems safe to drop this diff from the patch, although the line https://github.com/qt/qtbase/blob/v5.15.3-lts-lgpl/src/tools/moc/generator.cpp#L1621 still exists:
            if (d == floor(d) && fabs(d) <= (Q_INT64_C(1) << std::numeric_limits<double>::digits))
    1. Two remaining diffs have been took from different upstream fixes. Therefore, suggesting to comment them more explicitly:
    $ cat depends/patches/qt/fix_limits_header.patch
Fix compiling with GCC 11

Upstream:
 - bug report: https://bugreports.qt.io/browse/QTBUG-89977
 - fix in Qt 6.1: 813a928c7c3cf98670b6043149880ed5c955efb9

--- old/qtbase/src/corelib/text/qbytearraymatcher.h
+++ new/qtbase/src/corelib/text/qbytearraymatcher.h
@@ -42,6 +42,8 @@
 
 #include <QtCore/qbytearray.h>
 
+#include <limits>
+
 QT_BEGIN_NAMESPACE
 
 

Upstream fix and backports:
 - Qt 6.1: 3eab20ad382569cb2c9e6ccec2322c3d08c0f716
 - Qt 6.2: 380294a5971da85010a708dc23b0edec192cbf27
 - Qt 6.3: 2b2b3155d9f6ba1e4f859741468fbc47db09292b

--- old/qtbase/src/corelib/tools/qoffsetstringarray_p.h
+++ new/qtbase/src/corelib/tools/qoffsetstringarray_p.h
@@ -55,6 +55,7 @@
 
 #include <tuple>
 #include <array>
+#include <limits>
 
 QT_BEGIN_NAMESPACE
    1. I'd like to discuss whether we should backport the https://github.com/qt/qtbase/commit/813a928c7c3cf98670b6043149880ed5c955efb9 commit entirely, not just a diff for src/corelib/text/qbytearraymatcher.h. At least, should we add a diff for src/plugins/platforms/xcb/qxcbwindow.cpp? OTOH, I have not observed any build failures with the current implementation.
  19. hebasto commented at 1:31 PM on March 25, 2022: member

    Should we add CVE-2022-25643-5.15.diff to our patches?

    See: https://nvd.nist.gov/vuln/detail/CVE-2022-25634

    If "yes", then maybe in a separated commit?

  20. prusnak commented at 2:54 PM on March 25, 2022: contributor

    Should we add CVE-2022-25643-5.15.diff to our patches?

    There are also (both have the same contents):

    and we use QProcess here: https://github.com/bitcoin/bitcoin/blob/7c08d81e119570792648fe95bbacddbb1d5f9ae2/src/qt/guiutil.cpp#L447

  21. hebasto commented at 5:39 PM on March 25, 2022: member

    There are also:

    * [`qprocess5-15.diff`](https://download.qt.io/official_releases/qt/5.15/qprocess5-15.diff)

* [`CVE-2022-25255-qprocess5-15.diff`](https://download.qt.io/official_releases/qt/5.15/CVE-2022-25255-qprocess5-15.diff)

    and we use QProcess here:

    https://github.com/bitcoin/bitcoin/blob/7c08d81e119570792648fe95bbacddbb1d5f9ae2/src/qt/guiutil.cpp#L447

    I'd rather avoid using QProcess altogether.

  22. DrahtBot commented at 10:06 PM on March 25, 2022: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #24586 (doc: add more info to dependencies.md by prusnak)
    • #22708 (build, qt: Add Wayland support for Linux builds with depends by hebasto)
    • #21778 (build: LLVM 14 & LLD based macOS toolchain by fanquake)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  23. promag commented at 11:16 AM on March 26, 2022: member

    Concept ACK.

  24. hebasto commented at 11:42 AM on March 26, 2022: member

    Was thinking again about Qt security patches, and I believe it would be better to split the relevant discussion into separated issues / PRs.

    Therefore, only (1) and (2) are remaining from my #24668 (comment).

  25. prusnak commented at 11:50 AM on March 26, 2022: contributor

    Was thinking again about Qt security patches, and I believe it would be better to split the relevant discussion into separated issues / PRs.

    Agreed. Created PR #24688

    Therefore, only (1) and (2) are remaining from my #24668 (comment).

    Done in 7cbeee9ffcfc55df6bb6c3ff009fe75f5462ed

  26. prusnak force-pushed on Mar 26, 2022
  27. hebasto commented at 3:00 PM on March 26, 2022: member

    Guix builds on arm64:

    # find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
6c5d87680d478fa2baddc2401d4961b7b2444a78e2e9237d99438b1f5e4e49bf  guix-build-7cbeee9ffcfc/output/arm-linux-gnueabihf/SHA256SUMS.part
b4a058e63edc0d7f81e215f4f7eb9b814bbeef26879c8f55b22e9676083e0996  guix-build-7cbeee9ffcfc/output/arm-linux-gnueabihf/bitcoin-7cbeee9ffcfc-arm-linux-gnueabihf-debug.tar.gz
14031af39bd3b43d6cf72fb792b2c4f39953bfa7e7391acefc3b35ea0d908b6f  guix-build-7cbeee9ffcfc/output/arm-linux-gnueabihf/bitcoin-7cbeee9ffcfc-arm-linux-gnueabihf.tar.gz
f133392124716110fc026bf5d3c5407494428477f8f7d392c7b96a64281e2348  guix-build-7cbeee9ffcfc/output/arm64-apple-darwin/SHA256SUMS.part
d6579db10c3d068c2a834ca87a37dcfda9520bcb39cc38ed9e23abc67e664de3  guix-build-7cbeee9ffcfc/output/arm64-apple-darwin/bitcoin-7cbeee9ffcfc-arm64-apple-darwin-unsigned.dmg
cc0c3cf795699a5a85b0cd0cfbd747fa354247428b70f75eedab5d28c79a8825  guix-build-7cbeee9ffcfc/output/arm64-apple-darwin/bitcoin-7cbeee9ffcfc-arm64-apple-darwin-unsigned.tar.gz
9045ecf8b72fe3a9dfb278726570ff8cd1c9659fe8fda8d101a649b6a86ed2ec  guix-build-7cbeee9ffcfc/output/arm64-apple-darwin/bitcoin-7cbeee9ffcfc-arm64-apple-darwin.tar.gz
b6697a9b0e921b0cbdde6f3298f62e276adddb3755e3eb8b51dff5761a0beb36  guix-build-7cbeee9ffcfc/output/dist-archive/bitcoin-7cbeee9ffcfc.tar.gz
e2b7c76b2e56e2e07c17ed843e5aecb26c4c17ccc71fc2cf764e4a5207b932c7  guix-build-7cbeee9ffcfc/output/powerpc64-linux-gnu/SHA256SUMS.part
61bf1fb5b456d7ff5e735533a2da916926aedc0e13f3290008686b51f759848d  guix-build-7cbeee9ffcfc/output/powerpc64-linux-gnu/bitcoin-7cbeee9ffcfc-powerpc64-linux-gnu-debug.tar.gz
d9dba813f4780ddf2af71fe65b0d90ebd3fb61f4105d2db1d6879f2d89099e3e  guix-build-7cbeee9ffcfc/output/powerpc64-linux-gnu/bitcoin-7cbeee9ffcfc-powerpc64-linux-gnu.tar.gz
20c64f42304043e52aca2d9b6e8a24825e080309906fba549e65094643e01d5c  guix-build-7cbeee9ffcfc/output/powerpc64le-linux-gnu/SHA256SUMS.part
5e897c753128d7d9e23703fd5fbcd40f7ff26ae1db1ee825b0725090a43458fa  guix-build-7cbeee9ffcfc/output/powerpc64le-linux-gnu/bitcoin-7cbeee9ffcfc-powerpc64le-linux-gnu-debug.tar.gz
0e71d8f42428440eebe359d7aee7b0accaa071fd6b061fce9f7c31c028956aab  guix-build-7cbeee9ffcfc/output/powerpc64le-linux-gnu/bitcoin-7cbeee9ffcfc-powerpc64le-linux-gnu.tar.gz
bcdbe2844ebd851211308b6cb91339f88faa9987c52832d36c2cf3afb9ecfcbb  guix-build-7cbeee9ffcfc/output/riscv64-linux-gnu/SHA256SUMS.part
a8fc4553289e79d32b20fac53f256708c784b017658f8b41b63e4969b54d1acf  guix-build-7cbeee9ffcfc/output/riscv64-linux-gnu/bitcoin-7cbeee9ffcfc-riscv64-linux-gnu-debug.tar.gz
d17c7c9bb1c90e98ea750c5b04a4e3041e6eaaf8b641e1977725775caf2ef39e  guix-build-7cbeee9ffcfc/output/riscv64-linux-gnu/bitcoin-7cbeee9ffcfc-riscv64-linux-gnu.tar.gz
c55c7bc1c3f89bc1b4fab31c784e5261b04027843b8e3f1560129d19a32b1a4e  guix-build-7cbeee9ffcfc/output/x86_64-apple-darwin/SHA256SUMS.part
55c6934849d0f18336b4a34588c0f6b500e31ddf680c6c5d83f0900b27462cab  guix-build-7cbeee9ffcfc/output/x86_64-apple-darwin/bitcoin-7cbeee9ffcfc-x86_64-apple-darwin-unsigned.dmg
54e936e16538b751e7d80be359522e3d03f129efa62efb1ef6b986337cacc524  guix-build-7cbeee9ffcfc/output/x86_64-apple-darwin/bitcoin-7cbeee9ffcfc-x86_64-apple-darwin-unsigned.tar.gz
4e20b230f6196087c57661be9d1554b1e8eb4ffeabab02bef123f679c4d6933f  guix-build-7cbeee9ffcfc/output/x86_64-apple-darwin/bitcoin-7cbeee9ffcfc-x86_64-apple-darwin.tar.gz
c44a187b36bfce3aba1fbc8f7b5811316be8d0a305cf5354d5346b5af227868b  guix-build-7cbeee9ffcfc/output/x86_64-linux-gnu/SHA256SUMS.part
fb8ef3e5d894ed4017e03287c145196a2ebeda678adf57e45fa1f58939a6fd3b  guix-build-7cbeee9ffcfc/output/x86_64-linux-gnu/bitcoin-7cbeee9ffcfc-x86_64-linux-gnu-debug.tar.gz
e11fbedea2e977705c75bc2a846975c0d1c8ab65dfbccdae47ceef313f2b9de7  guix-build-7cbeee9ffcfc/output/x86_64-linux-gnu/bitcoin-7cbeee9ffcfc-x86_64-linux-gnu.tar.gz
0b444b623d12a7b57e6544021a502379d0161872c6ad412f027d4cecc30749b4  guix-build-7cbeee9ffcfc/output/x86_64-w64-mingw32/SHA256SUMS.part
f65c9254ee780a9b6f84fcf98e4ff689d6770b472bc9d9bd6039825daa7c289f  guix-build-7cbeee9ffcfc/output/x86_64-w64-mingw32/bitcoin-7cbeee9ffcfc-win64-debug.zip
b4f0543f9f8d97866b14e69868208796e75f76aa8f743c121d4e7383b778f3a3  guix-build-7cbeee9ffcfc/output/x86_64-w64-mingw32/bitcoin-7cbeee9ffcfc-win64-setup-unsigned.exe
612f6c6ab413cfe5053aa565c915ad7a26f3d44d372a10441204298cfa89c654  guix-build-7cbeee9ffcfc/output/x86_64-w64-mingw32/bitcoin-7cbeee9ffcfc-win64-unsigned.tar.gz
42425428e736a72d6798072f20460d61beb39946abd19cc5ba92de11187a3268  guix-build-7cbeee9ffcfc/output/x86_64-w64-mingw32/bitcoin-7cbeee9ffcfc-win64.zip
  28. hebasto commented at 4:14 PM on March 26, 2022: member

    @icota

    Mind testing this PR, especially for the x86_64-linux-android (due to removing of depends/patches/qt/dont_use_avx_android_x86_64.patch)?

  29. hebasto commented at 4:55 PM on March 26, 2022: member

    Guix builds on x86_64:

    $ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
21e3f1748b2c84ce6991d40715682ed2376786c77f3cc47f3fac4d96f003787e  guix-build-7cbeee9ffcfc/output/aarch64-linux-gnu/SHA256SUMS.part
a513838287cb5ce34fe7d41a6c6f72ecb970890783c8498a98f1d989ad8be8f2  guix-build-7cbeee9ffcfc/output/aarch64-linux-gnu/bitcoin-7cbeee9ffcfc-aarch64-linux-gnu-debug.tar.gz
b643ece43b7ecc37f9cbf485cf106d2b1d9e8a8ccc1408f7ae4278aa3467f694  guix-build-7cbeee9ffcfc/output/aarch64-linux-gnu/bitcoin-7cbeee9ffcfc-aarch64-linux-gnu.tar.gz
f5909ce15f701ac079054adf4a79dcd73b96740231be5a48d9f72d8252aec38a  guix-build-7cbeee9ffcfc/output/arm-linux-gnueabihf/SHA256SUMS.part
e2a299c145f879ffd22ac2ad83af6b32b0011a01781b013a03d181b9d539c552  guix-build-7cbeee9ffcfc/output/arm-linux-gnueabihf/bitcoin-7cbeee9ffcfc-arm-linux-gnueabihf-debug.tar.gz
3a9a17e937ceb8f623a74f02fb4c7cea996cc6d80167a1de73319699a64b2bf9  guix-build-7cbeee9ffcfc/output/arm-linux-gnueabihf/bitcoin-7cbeee9ffcfc-arm-linux-gnueabihf.tar.gz
534a34bb85a359b532537778e027d3c838dff319e86db1be22c2edf5219f12b0  guix-build-7cbeee9ffcfc/output/arm64-apple-darwin/SHA256SUMS.part
48be8c0d018056ca56185297fda7bdacc775c321feb5c610d4a85b0b30043ddd  guix-build-7cbeee9ffcfc/output/arm64-apple-darwin/bitcoin-7cbeee9ffcfc-arm64-apple-darwin-unsigned.dmg
be4c730d5cde1587f768d10073c779febae38aad6cffe82d523e0d947c6997d7  guix-build-7cbeee9ffcfc/output/arm64-apple-darwin/bitcoin-7cbeee9ffcfc-arm64-apple-darwin-unsigned.tar.gz
9c6f6939af5f2c4e09dc978131f024c051717341bc1442cc2d761d8ca36bd941  guix-build-7cbeee9ffcfc/output/arm64-apple-darwin/bitcoin-7cbeee9ffcfc-arm64-apple-darwin.tar.gz
b6697a9b0e921b0cbdde6f3298f62e276adddb3755e3eb8b51dff5761a0beb36  guix-build-7cbeee9ffcfc/output/dist-archive/bitcoin-7cbeee9ffcfc.tar.gz
648eccf4ad4b01459f2094785df339aea79eb792451fecdf538ce27f71f29c23  guix-build-7cbeee9ffcfc/output/powerpc64-linux-gnu/SHA256SUMS.part
d75e20d9cba870fe311db3267a1891ae0b26e8070a500d297ff8ccf6ad14dc64  guix-build-7cbeee9ffcfc/output/powerpc64-linux-gnu/bitcoin-7cbeee9ffcfc-powerpc64-linux-gnu-debug.tar.gz
bef179ded7ab4441a702002c478f7be0469b9bba56860934ef10a4e89f0e9d81  guix-build-7cbeee9ffcfc/output/powerpc64-linux-gnu/bitcoin-7cbeee9ffcfc-powerpc64-linux-gnu.tar.gz
c04e7b20b7e7b187e0e788a1f0d904448d411ab1371aed08bd704728fcc7ee34  guix-build-7cbeee9ffcfc/output/powerpc64le-linux-gnu/SHA256SUMS.part
3cdb5719e2e36f2b1c51d6c8814ead975f8102eaff3bf4a0bc0246a14386c953  guix-build-7cbeee9ffcfc/output/powerpc64le-linux-gnu/bitcoin-7cbeee9ffcfc-powerpc64le-linux-gnu-debug.tar.gz
0355d48a4ae7114601d26587b51968fa311ac39e302312631844dc5b1e18c612  guix-build-7cbeee9ffcfc/output/powerpc64le-linux-gnu/bitcoin-7cbeee9ffcfc-powerpc64le-linux-gnu.tar.gz
c53a2d20ae9d34a8c2f94b782eefd16dfcda692cd4cf7d55ac02665fa8f4e1a3  guix-build-7cbeee9ffcfc/output/riscv64-linux-gnu/SHA256SUMS.part
fd44fe1a90f5e684604a6cab7aaa66a4bb57b63c3d812c199af1aa8d9c6e47d1  guix-build-7cbeee9ffcfc/output/riscv64-linux-gnu/bitcoin-7cbeee9ffcfc-riscv64-linux-gnu-debug.tar.gz
0962ebaefbd5f8420df98164e45d43c435ddb2b7427921d15ae526f63da62659  guix-build-7cbeee9ffcfc/output/riscv64-linux-gnu/bitcoin-7cbeee9ffcfc-riscv64-linux-gnu.tar.gz
c178a0da8b469041788957ca142a55735f347ba07e0e14a440be74e3c95545bf  guix-build-7cbeee9ffcfc/output/x86_64-apple-darwin/SHA256SUMS.part
55c6934849d0f18336b4a34588c0f6b500e31ddf680c6c5d83f0900b27462cab  guix-build-7cbeee9ffcfc/output/x86_64-apple-darwin/bitcoin-7cbeee9ffcfc-x86_64-apple-darwin-unsigned.dmg
a2c9c684b72e4b5e4d050fc8a3a43749c95da82256605e1e6b7b8a8008a6a84e  guix-build-7cbeee9ffcfc/output/x86_64-apple-darwin/bitcoin-7cbeee9ffcfc-x86_64-apple-darwin-unsigned.tar.gz
4e20b230f6196087c57661be9d1554b1e8eb4ffeabab02bef123f679c4d6933f  guix-build-7cbeee9ffcfc/output/x86_64-apple-darwin/bitcoin-7cbeee9ffcfc-x86_64-apple-darwin.tar.gz
8e8876986d330164e148b82f4b953be45273b000b728da431098640df59663b0  guix-build-7cbeee9ffcfc/output/x86_64-linux-gnu/SHA256SUMS.part
4239a8fd23dc20ac5d56aa503f61b34c72a39dbb341a52977214c5f398557c6d  guix-build-7cbeee9ffcfc/output/x86_64-linux-gnu/bitcoin-7cbeee9ffcfc-x86_64-linux-gnu-debug.tar.gz
f3eda3cb80476e3fb3517d6bd06b919975e7d95f4b1ced2b3bd580d54dd92532  guix-build-7cbeee9ffcfc/output/x86_64-linux-gnu/bitcoin-7cbeee9ffcfc-x86_64-linux-gnu.tar.gz
012941790e6379c48781976cb80fd400c4316fba9f0fcb6dd4deda8ff9b56113  guix-build-7cbeee9ffcfc/output/x86_64-w64-mingw32/SHA256SUMS.part
e0a012f6ad9aef19b4b41bd4868a50349603f92b43827e92b31ac94dbcf53be3  guix-build-7cbeee9ffcfc/output/x86_64-w64-mingw32/bitcoin-7cbeee9ffcfc-win64-debug.zip
b4f0543f9f8d97866b14e69868208796e75f76aa8f743c121d4e7383b778f3a3  guix-build-7cbeee9ffcfc/output/x86_64-w64-mingw32/bitcoin-7cbeee9ffcfc-win64-setup-unsigned.exe
612f6c6ab413cfe5053aa565c915ad7a26f3d44d372a10441204298cfa89c654  guix-build-7cbeee9ffcfc/output/x86_64-w64-mingw32/bitcoin-7cbeee9ffcfc-win64-unsigned.tar.gz
b4cd561a6c8266b96b2876e3c4105e4d21183e2debf1fd0373652fa0601a230f  guix-build-7cbeee9ffcfc/output/x86_64-w64-mingw32/bitcoin-7cbeee9ffcfc-win64.zip
  30. hebasto commented at 5:40 PM on March 26, 2022: member

    Tested bitcoin-7cbeee9ffcfc-win64.zip on Windows 11 Pro 21H2:

    doc_2022-03-26_18-40-11

  31. hebasto commented at 5:59 PM on March 26, 2022: member

    Tested bitcoin-7cbeee9ffcfc-x86_64-apple-darwin-unsigned.dmg on macOS Monterey 12.3 (21E230):

    photo_2022-03-26_19-06-10

    photo_2022-03-26_19-05-27

  32. hebasto commented at 6:24 PM on March 26, 2022: member

    Tested bitcoin-7cbeee9ffcfc-arm64-apple-darwin-unsigned.dmg on Mac mini M1 + macOS Monterey 12.3 (21E230):

    image

    image

  33. hebasto approved
  34. hebasto commented at 6:25 PM on March 26, 2022: member

    ACK 7cbeee9ffcfc55df6bb6c3ff009fe75f5462ed00

  35. prusnak commented at 10:49 AM on March 27, 2022: contributor

    Pushed 2 new commits:

    • 34d469a - cherry-picked the fix from #24684
    • 8d83d31 - applied CVE fixes mentioned earlier in the thread

    ~Note: We might want to backport 8d83d31 into 23.x branch. Right now, it applies cleanly with no conflicts.~ edit: not needed, see below #24668 (comment)

  36. DrahtBot commented at 2:39 PM on March 27, 2022: contributor

    <!--9cd9c72976c961c55c7acef8f6ba82cd-->

    Guix builds

    File commit 4aaa74e947f85cb7d1ed6c9aa4b39e878950980c<br>(master) commit cf4964515d43df1a205c05ac43b92cb07164a14b<br>(master and this pull)
    SHA256SUMS.part 06df07c1ea86a43e... a523b7ecadc2a3e3...
    *-aarch64-linux-gnu-debug.tar.gz b2edab55bf920ce7... de8d8029b39d4edd...
    *-aarch64-linux-gnu.tar.gz b497c3330434a208... 300275326cc63f56...
    *-arm-linux-gnueabihf-debug.tar.gz 139c3d440db4bfd1... d1b618df5f0fc686...
    *-arm-linux-gnueabihf.tar.gz 02ecd366e99dbf43... ced7e795263f30a5...
    *-arm64-apple-darwin-unsigned.dmg 5cc8e4ea32d440b8... 91a0754d057cfefe...
    *-arm64-apple-darwin-unsigned.tar.gz 54b1bbafe7f24b46... d800a77b4dff359a...
    *-arm64-apple-darwin.tar.gz 80ac4238bf4f6297... 60bb393152b214e4...
    *-powerpc64-linux-gnu-debug.tar.gz 289f8ba8e150a3dd... 20ca1ea9506c1747...
    *-powerpc64-linux-gnu.tar.gz ed7cc9b2f408fc6d... 5c9beb834c5875d3...
    *-powerpc64le-linux-gnu-debug.tar.gz ed1d8eb47bd1b10b... 138d24aadb188594...
    *-powerpc64le-linux-gnu.tar.gz 0ce6e501f15462df... 62620939dc200bd4...
    *-riscv64-linux-gnu-debug.tar.gz 7ee69d8fc78c9243... d267592860227dde...
    *-riscv64-linux-gnu.tar.gz 449244a8f4bc9372... 847718b6c16e2e2c...
    *-win64-debug.zip b6512eab5dfceb44... 526573fa3e7286ff...
    *-win64-setup-unsigned.exe 7a658da0440ff2da... 36a5ae01b3590988...
    *-win64-unsigned.tar.gz 0c6db8c2381d23a3... b350a5014fb0eed9...
    *-win64.zip d0d6b2c386fd64c2... d070f5e4c96548e1...
    *-x86_64-apple-darwin-unsigned.dmg b3bc483c281893cd... 7fe5c4ba540a288d...
    *-x86_64-apple-darwin-unsigned.tar.gz 9bbb5f0d1ec16437... 26c8848affbaf2c0...
    *-x86_64-apple-darwin.tar.gz be0f670df75d2ddb... 8f9fb2930da55ed0...
    *-x86_64-linux-gnu-debug.tar.gz 5b21b10b4c09dcea... f62af2d9900b07e7...
    *-x86_64-linux-gnu.tar.gz bf110a92d1b6a922... 6a6c79dd794555af...
    *.tar.gz c1cdce1386e34c76... b067182d1f27eb0e...
    guix_build.log 5091ab7fb59692bb... 0fa41110f52edad4...
    guix_build.log.diff 240953449733aafa...
  37. DrahtBot removed the label DrahtBot Guix build requested on Mar 27, 2022
  38. DrahtBot added the label Build system on Mar 27, 2022
  39. DrahtBot added the label Needs rebase on Mar 29, 2022
  40. prusnak force-pushed on Mar 29, 2022
  41. prusnak commented at 9:29 PM on March 29, 2022: contributor

    Rebased

  42. DrahtBot removed the label Needs rebase on Mar 29, 2022
  43. fanquake commented at 8:28 AM on March 30, 2022: member

    Updating to 5.15.3 and dropping some patches is fine. Not a priority unless there are some important fixes that we aren't already patching.

    It's not clear to me why we need these QProcess CVE patches, or why they would need to be backported:

    CVE-2022-25255 | https://codereview.qt-project.org/c/qt/qtbase/+/393113 We have a single usage of QProcess in our codebase (macOS only). Looking at the abandoned patch for the 5.15 branch, from what I can tell, this only affects the case where you pass QProcess a binary blah, and it needs to lookup a full path. Given that we pass /usr/bin/open, we shouldn't fall into either if (!program.contains(QLatin1Char('/'))) { block, which is where the patching is happens, so it's not clear how we are affected by this CVE.

    CVE-2022-25634 | https://codereview.qt-project.org/c/qt/qtbase/+/396440 This patches Windows code that loads opengl32 & opengl32sw. I don't understand how this affect us, given our Windows Qt is built without support for OpenGL. Does the code being patched here even end up in our built Qt libs / binary? Note that opengl* also isn't in our list of allowed to be loaded PE libs.

  44. prusnak commented at 8:53 AM on March 30, 2022: contributor

    It's not clear to me why we need these ... CVE patches

    My rationale was that it's better to have these known Qt vulnerabilities patched defensively now in case we start using the affected functionality some time in the future and no-one will realise that the otherwise perfectly fine change will enable these vulnerabilities.

    If that sounds over the top, I am fine with dropping 18588c1 from the PR.

    And of course it's nice to know that older releases are not affected and 18588c1 does not need to be backported.

  45. DrahtBot added the label Needs rebase on Apr 1, 2022
  46. build, qt: bump Qt5 version to 5.15.3
    Qt 5.15.3 release is a patch release made on the top of Qt 5.15.2. As a patch
release, Qt 5.15.3 does not add any new functionality but provides bug fixes
and other improvements.

https://code.qt.io/cgit/qt/qtreleasenotes.git/about/qt/5.15.3/release-note.md

* dropped patches:
  - patches/qt/dont_use_avx_android_x86_64.patch
  - patches/qt/fix_bigsur_style.patch
* adjusted patches:
  - patches/qt/fix_android_jni_static.patch
  - patches/qt/fix_limits_header.patch
  - patches/qt/use_android_ndk23.patch

Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
    ef20add4c9
  47. build, qt: drop fix_no_printer.patch
    The removed patch is not required since switching Qt version from
5.12.11 to 5.15.2.
    826cbc470f
  48. build, qt: use one patch per line in depends/packages/qt.mk 7f6042849c
  49. prusnak force-pushed on Apr 1, 2022
  50. prusnak commented at 3:03 PM on April 1, 2022: contributor

    Rebased

  51. DrahtBot removed the label Needs rebase on Apr 1, 2022
  52. fanquake commented at 2:45 PM on April 2, 2022: member

    If that sounds over the top, I am fine with dropping https://github.com/bitcoin/bitcoin/commit/18588c16ee110b145baba547525720255cd3366a from the PR.

    I think that's what we can do for now.

  53. hebasto commented at 4:56 PM on April 2, 2022: member

    If that sounds over the top, I am fine with dropping 18588c1 from the PR.

    I think that's what we can do for now.

    Agree. Another concerns about the CVE patches are that it is not clear (at least for me) how they are maintained. I cannot see them in the Qt repository, there are no discussion in https://bugreports.qt.io etc.

    Btw, I'm working on removing Qprocess from our codebase.

    nit: In 7f6042849c976ef1c7ac90c6aa8982ee1492a4bf "build, qt: use one patch per line in depends/packages/qt.mk" suggesting to place patches, and correspondent patch calls, in lexicographical order to be consistent with same ordering of files. (although, not sure if the latter won't break something).

  54. prusnak force-pushed on Apr 2, 2022
  55. hebasto commented at 5:06 PM on April 2, 2022: member

    Approach ACK 7f6042849c976ef1c7ac90c6aa8982ee1492a4bf.

  56. prusnak commented at 5:08 PM on April 2, 2022: contributor

    Dropped the patch adding fixes for CVEs.

  57. hebasto commented at 6:41 AM on April 3, 2022: member

    Guix buids on x86_64:

    $ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
76f3d7997db56b6d90ee9e2e3fdc33c768a8f953be15bd5d486b4febd6f5e8d6  guix-build-7f6042849c97/output/aarch64-linux-gnu/SHA256SUMS.part
3bb69942c74703ef21ae8366741008fdedad37ea1c3d919e75947d4074990b08  guix-build-7f6042849c97/output/aarch64-linux-gnu/bitcoin-7f6042849c97-aarch64-linux-gnu-debug.tar.gz
b73ca45833a6642c339878269d2dabcd11431dbfdeb998c21462a43f7a39323d  guix-build-7f6042849c97/output/aarch64-linux-gnu/bitcoin-7f6042849c97-aarch64-linux-gnu.tar.gz
0d5fe415819f58837e6f117440e14998c332df312a7dcfcdd8afa2f5b8d67d32  guix-build-7f6042849c97/output/arm-linux-gnueabihf/SHA256SUMS.part
8c93c48f07d378cc63e2c2754ab99c0fc3fa30df84a1423505959ee3a5333960  guix-build-7f6042849c97/output/arm-linux-gnueabihf/bitcoin-7f6042849c97-arm-linux-gnueabihf-debug.tar.gz
947879079ffc48d1a325a0bcc4454ee2a0944572eab941d1697547464b1f123a  guix-build-7f6042849c97/output/arm-linux-gnueabihf/bitcoin-7f6042849c97-arm-linux-gnueabihf.tar.gz
6910d25cf6a64dbf8419f81142bca733c95c5eb86f80c59ad7f9a0b0f37c1e5c  guix-build-7f6042849c97/output/arm64-apple-darwin/SHA256SUMS.part
f3176844154966d975867ec7f057a9f474cfc7e7e41bd019537bc3df6488b985  guix-build-7f6042849c97/output/arm64-apple-darwin/bitcoin-7f6042849c97-arm64-apple-darwin-unsigned.dmg
9e81155dd2e63674abbce029d17c5fe124606ca253441bad0b9ff312f9393cf3  guix-build-7f6042849c97/output/arm64-apple-darwin/bitcoin-7f6042849c97-arm64-apple-darwin-unsigned.tar.gz
a2bb04a0250af36cc6ac78048ad1f8fc08591bea0d455a6e5269921d8ef39567  guix-build-7f6042849c97/output/arm64-apple-darwin/bitcoin-7f6042849c97-arm64-apple-darwin.tar.gz
6d3335243f9e831f4054447c2a7b541fae33b9b8816f227ad63e4755dcdaa8d2  guix-build-7f6042849c97/output/dist-archive/bitcoin-7f6042849c97.tar.gz
f99615b53c90d8dae44daccb8bf4ccfdcbba03350947ab64544d440fb23e3ed8  guix-build-7f6042849c97/output/powerpc64-linux-gnu/SHA256SUMS.part
b14b7e13af791654848722a3cf5b71b2ac565864ab28937c768490dd16061aa5  guix-build-7f6042849c97/output/powerpc64-linux-gnu/bitcoin-7f6042849c97-powerpc64-linux-gnu-debug.tar.gz
a2e0d119b63910369d8f1ed48bce616e3b9b3cb3e7a5404b988357019407f53c  guix-build-7f6042849c97/output/powerpc64-linux-gnu/bitcoin-7f6042849c97-powerpc64-linux-gnu.tar.gz
b62eb694039c3a2914a71d3b9c747876471c8cad0dd4747f295068393c0810f5  guix-build-7f6042849c97/output/powerpc64le-linux-gnu/SHA256SUMS.part
46a431b70e530e1be7b90f0277401348b6bd11ae462ce7803e3a3fa895b32e06  guix-build-7f6042849c97/output/powerpc64le-linux-gnu/bitcoin-7f6042849c97-powerpc64le-linux-gnu-debug.tar.gz
3b9bfecb7e057a0addedf26b00b57bda4804e847c9daf7f578623e1e46583641  guix-build-7f6042849c97/output/powerpc64le-linux-gnu/bitcoin-7f6042849c97-powerpc64le-linux-gnu.tar.gz
e31bbd499ffd2b1bf5044e31ec89d9b91e9e6a508829c8bc0e03e21a6e5af07c  guix-build-7f6042849c97/output/riscv64-linux-gnu/SHA256SUMS.part
11cff702cbab9d74b9192b8319d9e7269d89ffbe8bd774bc1411d9c6f8d57146  guix-build-7f6042849c97/output/riscv64-linux-gnu/bitcoin-7f6042849c97-riscv64-linux-gnu-debug.tar.gz
d2bd48c47415912ad8c96e03e3bc84f80ecae1fbf9a4ae483068dd6ce53529aa  guix-build-7f6042849c97/output/riscv64-linux-gnu/bitcoin-7f6042849c97-riscv64-linux-gnu.tar.gz
a8742730616abdf5c29b964ef0f5be4d12edc8c773a6c0d7ed1cd7065ef6e5d3  guix-build-7f6042849c97/output/x86_64-apple-darwin/SHA256SUMS.part
c29c67362d7add11a963713854e8de3636113b6934b9091d22d6ad7947ac2494  guix-build-7f6042849c97/output/x86_64-apple-darwin/bitcoin-7f6042849c97-x86_64-apple-darwin-unsigned.dmg
08d96c29904f04af666f1673189f4164a33eec3e63adf0adf39c35e30dad6521  guix-build-7f6042849c97/output/x86_64-apple-darwin/bitcoin-7f6042849c97-x86_64-apple-darwin-unsigned.tar.gz
2b3aa7b66a3d63255eadbb3f152163cdafff567e2ac26edca4642c5a5a11e30f  guix-build-7f6042849c97/output/x86_64-apple-darwin/bitcoin-7f6042849c97-x86_64-apple-darwin.tar.gz
e0a776f46aa032a7d24791b1752e874008d171a10b0e8e44eed5b1bbf2e45150  guix-build-7f6042849c97/output/x86_64-linux-gnu/SHA256SUMS.part
fa8f47ecb686c6aa66cdb18c1d0e22020df05157612e9486257b788720afe201  guix-build-7f6042849c97/output/x86_64-linux-gnu/bitcoin-7f6042849c97-x86_64-linux-gnu-debug.tar.gz
8561f2c4642f74064ae28a2a579f7a2b7b4cca3a6918dccc37998f98b972dfc7  guix-build-7f6042849c97/output/x86_64-linux-gnu/bitcoin-7f6042849c97-x86_64-linux-gnu.tar.gz
f14d08defc9e52a1057d9209e85d00ef3f6348a983f3389420fd39944ed72fad  guix-build-7f6042849c97/output/x86_64-w64-mingw32/SHA256SUMS.part
a71e546835eb4a889782be841fe2f6632df0581a6973d2f91833bcc2b78bfbe8  guix-build-7f6042849c97/output/x86_64-w64-mingw32/bitcoin-7f6042849c97-win64-debug.zip
ce67f2886f9f584244dcfc8d54df8b8ccb75b6bf4c3b65e8e06df83bbe1cdf66  guix-build-7f6042849c97/output/x86_64-w64-mingw32/bitcoin-7f6042849c97-win64-setup-unsigned.exe
d3945996e788545bbff9f95105451c308aa0fd2bda42674b4eacacca15c7e401  guix-build-7f6042849c97/output/x86_64-w64-mingw32/bitcoin-7f6042849c97-win64-unsigned.tar.gz
3a9b3eca1b7a92d4e426b551210beac09630c036354118f55b5d609a1a175b3b  guix-build-7f6042849c97/output/x86_64-w64-mingw32/bitcoin-7f6042849c97-win64.zip
  58. hebasto approved
  59. hebasto commented at 6:41 AM on April 3, 2022: member

    ACK 7f6042849c976ef1c7ac90c6aa8982ee1492a4bf

  60. fanquake commented at 1:59 PM on April 3, 2022: member

    Guix Build (on x86_64):

    76f3d7997db56b6d90ee9e2e3fdc33c768a8f953be15bd5d486b4febd6f5e8d6  guix-build-7f6042849c97/output/aarch64-linux-gnu/SHA256SUMS.part
3bb69942c74703ef21ae8366741008fdedad37ea1c3d919e75947d4074990b08  guix-build-7f6042849c97/output/aarch64-linux-gnu/bitcoin-7f6042849c97-aarch64-linux-gnu-debug.tar.gz
b73ca45833a6642c339878269d2dabcd11431dbfdeb998c21462a43f7a39323d  guix-build-7f6042849c97/output/aarch64-linux-gnu/bitcoin-7f6042849c97-aarch64-linux-gnu.tar.gz
0d5fe415819f58837e6f117440e14998c332df312a7dcfcdd8afa2f5b8d67d32  guix-build-7f6042849c97/output/arm-linux-gnueabihf/SHA256SUMS.part
8c93c48f07d378cc63e2c2754ab99c0fc3fa30df84a1423505959ee3a5333960  guix-build-7f6042849c97/output/arm-linux-gnueabihf/bitcoin-7f6042849c97-arm-linux-gnueabihf-debug.tar.gz
947879079ffc48d1a325a0bcc4454ee2a0944572eab941d1697547464b1f123a  guix-build-7f6042849c97/output/arm-linux-gnueabihf/bitcoin-7f6042849c97-arm-linux-gnueabihf.tar.gz
6910d25cf6a64dbf8419f81142bca733c95c5eb86f80c59ad7f9a0b0f37c1e5c  guix-build-7f6042849c97/output/arm64-apple-darwin/SHA256SUMS.part
f3176844154966d975867ec7f057a9f474cfc7e7e41bd019537bc3df6488b985  guix-build-7f6042849c97/output/arm64-apple-darwin/bitcoin-7f6042849c97-arm64-apple-darwin-unsigned.dmg
9e81155dd2e63674abbce029d17c5fe124606ca253441bad0b9ff312f9393cf3  guix-build-7f6042849c97/output/arm64-apple-darwin/bitcoin-7f6042849c97-arm64-apple-darwin-unsigned.tar.gz
a2bb04a0250af36cc6ac78048ad1f8fc08591bea0d455a6e5269921d8ef39567  guix-build-7f6042849c97/output/arm64-apple-darwin/bitcoin-7f6042849c97-arm64-apple-darwin.tar.gz
6d3335243f9e831f4054447c2a7b541fae33b9b8816f227ad63e4755dcdaa8d2  guix-build-7f6042849c97/output/dist-archive/bitcoin-7f6042849c97.tar.gz
f99615b53c90d8dae44daccb8bf4ccfdcbba03350947ab64544d440fb23e3ed8  guix-build-7f6042849c97/output/powerpc64-linux-gnu/SHA256SUMS.part
b14b7e13af791654848722a3cf5b71b2ac565864ab28937c768490dd16061aa5  guix-build-7f6042849c97/output/powerpc64-linux-gnu/bitcoin-7f6042849c97-powerpc64-linux-gnu-debug.tar.gz
a2e0d119b63910369d8f1ed48bce616e3b9b3cb3e7a5404b988357019407f53c  guix-build-7f6042849c97/output/powerpc64-linux-gnu/bitcoin-7f6042849c97-powerpc64-linux-gnu.tar.gz
b62eb694039c3a2914a71d3b9c747876471c8cad0dd4747f295068393c0810f5  guix-build-7f6042849c97/output/powerpc64le-linux-gnu/SHA256SUMS.part
46a431b70e530e1be7b90f0277401348b6bd11ae462ce7803e3a3fa895b32e06  guix-build-7f6042849c97/output/powerpc64le-linux-gnu/bitcoin-7f6042849c97-powerpc64le-linux-gnu-debug.tar.gz
3b9bfecb7e057a0addedf26b00b57bda4804e847c9daf7f578623e1e46583641  guix-build-7f6042849c97/output/powerpc64le-linux-gnu/bitcoin-7f6042849c97-powerpc64le-linux-gnu.tar.gz
e31bbd499ffd2b1bf5044e31ec89d9b91e9e6a508829c8bc0e03e21a6e5af07c  guix-build-7f6042849c97/output/riscv64-linux-gnu/SHA256SUMS.part
11cff702cbab9d74b9192b8319d9e7269d89ffbe8bd774bc1411d9c6f8d57146  guix-build-7f6042849c97/output/riscv64-linux-gnu/bitcoin-7f6042849c97-riscv64-linux-gnu-debug.tar.gz
d2bd48c47415912ad8c96e03e3bc84f80ecae1fbf9a4ae483068dd6ce53529aa  guix-build-7f6042849c97/output/riscv64-linux-gnu/bitcoin-7f6042849c97-riscv64-linux-gnu.tar.gz
a8742730616abdf5c29b964ef0f5be4d12edc8c773a6c0d7ed1cd7065ef6e5d3  guix-build-7f6042849c97/output/x86_64-apple-darwin/SHA256SUMS.part
c29c67362d7add11a963713854e8de3636113b6934b9091d22d6ad7947ac2494  guix-build-7f6042849c97/output/x86_64-apple-darwin/bitcoin-7f6042849c97-x86_64-apple-darwin-unsigned.dmg
08d96c29904f04af666f1673189f4164a33eec3e63adf0adf39c35e30dad6521  guix-build-7f6042849c97/output/x86_64-apple-darwin/bitcoin-7f6042849c97-x86_64-apple-darwin-unsigned.tar.gz
2b3aa7b66a3d63255eadbb3f152163cdafff567e2ac26edca4642c5a5a11e30f  guix-build-7f6042849c97/output/x86_64-apple-darwin/bitcoin-7f6042849c97-x86_64-apple-darwin.tar.gz
e0a776f46aa032a7d24791b1752e874008d171a10b0e8e44eed5b1bbf2e45150  guix-build-7f6042849c97/output/x86_64-linux-gnu/SHA256SUMS.part
fa8f47ecb686c6aa66cdb18c1d0e22020df05157612e9486257b788720afe201  guix-build-7f6042849c97/output/x86_64-linux-gnu/bitcoin-7f6042849c97-x86_64-linux-gnu-debug.tar.gz
8561f2c4642f74064ae28a2a579f7a2b7b4cca3a6918dccc37998f98b972dfc7  guix-build-7f6042849c97/output/x86_64-linux-gnu/bitcoin-7f6042849c97-x86_64-linux-gnu.tar.gz
f14d08defc9e52a1057d9209e85d00ef3f6348a983f3389420fd39944ed72fad  guix-build-7f6042849c97/output/x86_64-w64-mingw32/SHA256SUMS.part
a71e546835eb4a889782be841fe2f6632df0581a6973d2f91833bcc2b78bfbe8  guix-build-7f6042849c97/output/x86_64-w64-mingw32/bitcoin-7f6042849c97-win64-debug.zip
ce67f2886f9f584244dcfc8d54df8b8ccb75b6bf4c3b65e8e06df83bbe1cdf66  guix-build-7f6042849c97/output/x86_64-w64-mingw32/bitcoin-7f6042849c97-win64-setup-unsigned.exe
d3945996e788545bbff9f95105451c308aa0fd2bda42674b4eacacca15c7e401  guix-build-7f6042849c97/output/x86_64-w64-mingw32/bitcoin-7f6042849c97-win64-unsigned.tar.gz
3a9b3eca1b7a92d4e426b551210beac09630c036354118f55b5d609a1a175b3b  guix-build-7f6042849c97/output/x86_64-w64-mingw32/bitcoin-7f6042849c97-win64.zip
  61. fanquake approved
  62. fanquake commented at 8:16 AM on April 4, 2022: member

    ACK 7f6042849c976ef1c7ac90c6aa8982ee1492a4bf

  63. fanquake merged this on Apr 4, 2022
  64. fanquake closed this on Apr 4, 2022
  65. sidhujag referenced this in commit 75efc47ecb on Apr 4, 2022
  66. prusnak deleted the branch on Apr 6, 2022
  67. hebasto referenced this in commit da9578da80 on Aug 12, 2022
  68. hebasto commented at 9:39 AM on August 12, 2022: member

    The first commit has been backported to the 23.x branch in #25828 to address:

    • bitcoin/bitcoin#24939
    • bitcoin-core/gui#638
  69. fanquake referenced this in commit 45c9f4afa4 on Oct 2, 2022
  70. kwvg referenced this in commit 5929c6714a on May 9, 2023
  71. kwvg referenced this in commit e2e06092cf on May 9, 2023
  72. Fabcien referenced this in commit 6dd5e9f637 on May 26, 2023
  73. kwvg referenced this in commit a3affd82e7 on May 31, 2023
  74. kwvg referenced this in commit 0ea10d7aa2 on Jun 8, 2023
  75. kwvg referenced this in commit 9510cc16e5 on Jun 11, 2023
  76. kwvg referenced this in commit 4d7ae54c15 on Jun 11, 2023
  77. kwvg referenced this in commit 1e7043ff37 on Jun 19, 2023
  78. kwvg referenced this in commit 7ce2c7c97f on Jun 20, 2023
  79. kwvg referenced this in commit 15ef4b27cb on Jun 29, 2023
  80. kwvg referenced this in commit b03982dae9 on Jul 3, 2023
  81. kwvg referenced this in commit 423bd3727c on Jul 3, 2023
  82. kwvg referenced this in commit a3c8df018d on Jul 4, 2023
  83. kwvg referenced this in commit f65fa48c5e on Aug 2, 2023
  84. kwvg referenced this in commit 1da4455421 on Aug 2, 2023
  85. kwvg referenced this in commit 2b154c2e6d on Aug 3, 2023
  86. PastaPastaPasta referenced this in commit d121666341 on Aug 8, 2023
  87. PastaPastaPasta referenced this in commit 666fa51a7c on Aug 8, 2023
  88. bitcoin locked this on Aug 12, 2023
Contributors
prusnakhebastoDrahtBotpromagfanquake
Labels
Build system
Linked (view graph)
#24688 build, qt: drop fix_no_printer patch, add CVE fixes
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-02 18:14 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me