doc, test: Compilation for 64-bit Windows with msys2 #24985

pull rnapoles wants to merge 12 commits into bitcoin:master from rnapoles:msys2-windows-build changing 4 files +197 −28
  1. rnapoles commented at 1:30 am on April 26, 2022: none
    • update steps for build Bitcoin Core with msys2
    • fix test/util/rpcauth-test.py and test/util/test_runner.py to run in msys2
    • added test/util/path_helper.py to handle msys2 paths in python
  2. * Compilation for 64-bit Windows with msys2 
    updated doc/build-windows.md and modified test/util/*.py  to run under msys2
    b54e979e78
  3. * fix F841 flake8 rule 440a96d213
  4. rnapoles renamed this:
    doc,test: Compilation for 64-bit Windows with msys2
    Compilation for 64-bit Windows with msys2
    on Apr 26, 2022
  5. DrahtBot added the label Docs on Apr 26, 2022
  6. DrahtBot added the label Tests on Apr 26, 2022
  7. laanwj added the label Windows on Apr 26, 2022
  8. in doc/build-windows.md:108 in 440a96d213 outdated 
    103+  pacman -Su
104+  pacman -S base-devel gcc vim cmake git mingw-w64-{x86_64,i686}-nsis
105+  pacman -S --needed filesystem msys2-runtime bash libreadline libiconv libarchive libgpgme libcurl pacman ncurses libintl
106+  pacman -S make autoconf autotools automake libtool pkg-config autotools-dev pkg-config
107+  pacman -S mingw-w64-{i686,x86_64}-toolchain mingw-w64-{i686,x86_64}-pkgconf
108+  pacman -S mingw-w64-{i686,x86_64}-{boost,protobuf}
    fanquake commented at 8:05 am on April 26, 2022:
    protobuf is not required.
    rnapoles commented at 7:49 pm on April 26, 2022:
    included in updated doc/build-windows.md
  9. in doc/build-windows.md:112 in 440a96d213 outdated 
    107+  pacman -S mingw-w64-{i686,x86_64}-toolchain mingw-w64-{i686,x86_64}-pkgconf
108+  pacman -S mingw-w64-{i686,x86_64}-{boost,protobuf}
109+  pacman -S mingw-w64-{i686,x86_64}-crt-git
110+  pacman -S mingw-w64-{i686,x86_64}-libevent
111+  pacman -S mingw-w64-{i686,x86_64}-db mingw-w64-{i686,x86_64}-leveldb
112+  pacman -S mingw-w64-{i686,x86_64}-miniupnpc
    fanquake commented at 8:05 am on April 26, 2022:
    You’re installing miniupnpc and then configuring with --without-miniupnpc?
    rnapoles commented at 7:49 pm on April 26, 2022:
    included in updated doc/build-windows.md
  10. in doc/build-windows.md:111 in 440a96d213 outdated 
    106+  pacman -S make autoconf autotools automake libtool pkg-config autotools-dev pkg-config
107+  pacman -S mingw-w64-{i686,x86_64}-toolchain mingw-w64-{i686,x86_64}-pkgconf
108+  pacman -S mingw-w64-{i686,x86_64}-{boost,protobuf}
109+  pacman -S mingw-w64-{i686,x86_64}-crt-git
110+  pacman -S mingw-w64-{i686,x86_64}-libevent
111+  pacman -S mingw-w64-{i686,x86_64}-db mingw-w64-{i686,x86_64}-leveldb
    fanquake commented at 8:06 am on April 26, 2022:
    leveldb is part of our source. It doesn’t need installing.
    rnapoles commented at 7:49 pm on April 26, 2022:
    included in updated doc/build-windows.md
  11. in doc/build-windows.md:128 in 440a96d213 outdated 
    123+
124+  ./configure \
125+      --with-gui=no \
126+      --without-miniupnpc \
127+      --without-bdb \
128+      --without-gui \
    fanquake commented at 8:06 am on April 26, 2022:
    --with-gui=no and --without-gui do the same thing.
    rnapoles commented at 7:49 pm on April 26, 2022:
    included in updated doc/build-windows.md
  12. in doc/build-windows.md:129 in 440a96d213 outdated 
    124+  ./configure \
125+      --with-gui=no \
126+      --without-miniupnpc \
127+      --without-bdb \
128+      --without-gui \
129+      --with-qrencode
    fanquake commented at 8:07 am on April 26, 2022:
    Why are you passing --with-qrencode (gui component) if you’ve explicitly disabled the GUI?
    rnapoles commented at 7:49 pm on April 26, 2022:
    included in updated doc/build-windows.md
  13. in doc/build-windows.md:136 in 440a96d213 outdated 
    131+  make -J
132+
133+  make check
134+```
135+
136+#### Credits
    fanquake commented at 8:07 am on April 26, 2022:
    Credits section can be removed.
    rnapoles commented at 7:51 pm on April 26, 2022:
    rename to “References” doc/build-windows.md, What do you think about this?
    fanquake commented at 9:35 pm on April 26, 2022:

    What do you think about this?

    I still don’t think there’s any need for a references, or credits section. Let alone one that links to a repository that hasn’t been updated in 7 years.

    rnapoles commented at 4:15 am on April 27, 2022:
    I understand, removed outdated references in new commit
  14. in doc/build-windows.md:104 in 440a96d213 outdated 
     99+
100+#### Install
101+```bash
102+  pacman -Sy
103+  pacman -Su
104+  pacman -S base-devel gcc vim cmake git mingw-w64-{x86_64,i686}-nsis
    fanquake commented at 8:11 am on April 26, 2022:
    vim?
    rnapoles commented at 7:51 pm on April 26, 2022:
    remove in updated doc/build-windows.md
  15. in doc/build-windows.md:131 in 440a96d213 outdated 
    126+      --without-miniupnpc \
127+      --without-bdb \
128+      --without-gui \
129+      --with-qrencode
130+
131+  make -J
    fanquake commented at 8:13 am on April 26, 2022:
    -J alone won’t do anything.
    rnapoles commented at 7:52 pm on April 26, 2022:
    corrected in updated doc/build-windows.md
  16. in doc/build-windows.md:107 in 440a96d213 outdated 
    102+  pacman -Sy
103+  pacman -Su
104+  pacman -S base-devel gcc vim cmake git mingw-w64-{x86_64,i686}-nsis
105+  pacman -S --needed filesystem msys2-runtime bash libreadline libiconv libarchive libgpgme libcurl pacman ncurses libintl
106+  pacman -S make autoconf autotools automake libtool pkg-config autotools-dev pkg-config
107+  pacman -S mingw-w64-{i686,x86_64}-toolchain mingw-w64-{i686,x86_64}-pkgconf
    fanquake commented at 8:16 am on April 26, 2022:
    Do we definitely need pkgconf and pkg-config?
    rnapoles commented at 7:52 pm on April 26, 2022:
    corrected in updated doc/build-windows.md
  17. in doc/build-windows.md:106 in 440a96d213 outdated 
    101+```bash
102+  pacman -Sy
103+  pacman -Su
104+  pacman -S base-devel gcc vim cmake git mingw-w64-{x86_64,i686}-nsis
105+  pacman -S --needed filesystem msys2-runtime bash libreadline libiconv libarchive libgpgme libcurl pacman ncurses libintl
106+  pacman -S make autoconf autotools automake libtool pkg-config autotools-dev pkg-config
    fanquake commented at 8:17 am on April 26, 2022:
    pkg-config is listed twice.
  18. in doc/build-windows.md:105 in 440a96d213 outdated 
    100+#### Install
101+```bash
102+  pacman -Sy
103+  pacman -Su
104+  pacman -S base-devel gcc vim cmake git mingw-w64-{x86_64,i686}-nsis
105+  pacman -S --needed filesystem msys2-runtime bash libreadline libiconv libarchive libgpgme libcurl pacman ncurses libintl
    fanquake commented at 8:20 am on April 26, 2022:
    Is pacman meant to be listed here? I’m not sure what the rest of these dependencies are used for.
    rnapoles commented at 7:53 pm on April 26, 2022:
    corrected in updated doc/build-windows.md
  19. * update doc remove unused packages and build options without sense b71c1f5b85
  20. * only support 64 bits builds e327bc90b5
  21. * remove outdated references f24d90b8e3
  22. * removed outdated references 4fae554f40
  23. Merge branch 'msys2-windows-build' of https://github.com/rnapoles/bitcoin into msys2-windows-build 8f762ba919
  24. * move msys2 doc build to end of file 178655ac30
  25. Merge branch 'bitcoin:master' into msys2-windows-build e9ce943397
  26. * split commands 62c52831b5
  27. * prettify doc/build-windows.md 0ad3583b40
  28. * prettify doc/build-windows.md removed extra spaces 10239b3b79
  29. DrahtBot commented at 2:19 am on April 28, 2022: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #24993 (test, contrib, refactor: use with when opening a file by brunoerg)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  30. rnapoles renamed this:
    Compilation for 64-bit Windows with msys2
    doc, test: Compilation for 64-bit Windows with msys2
    on Apr 28, 2022
  31. fanquake commented at 2:53 pm on April 28, 2022: member
    @rnapoles note that you’ll need to squash / cleanup your commits (no need to open a new PR). @sipsorcery any thoughts on this?
  32. sipsorcery commented at 3:11 pm on April 28, 2022: member

    @rnapoles I’d recommend splitting this PR up. Some of the changes seem to be pure formatting, some are related to the msys2 change (which is all that is expected given the PR title) and some seem to be changes to the test scripts. It’s a lot easier to get reviewers and ACK’s on PRs if they are single purpose.

    In regards to the msys2 change my personal opinion would be that it’s better to stick with mingw because that’s what the Bitcoin Core guix builds are done with.

  33. MarcoFalke commented at 3:14 pm on April 28, 2022: member
    I think the plan is to move from mingw to clang windows cross builds
  34. DrahtBot added the label Needs rebase on May 4, 2022
  35. DrahtBot commented at 7:19 pm on May 4, 2022: contributor

    🐙 This pull request conflicts with the target branch and needs rebase.

    Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a “draft”.

  36. fanquake commented at 1:18 pm on August 15, 2022: member

    In regards to the msys2 change my personal opinion would be that it’s better to stick with mingw because that’s what the Bitcoin Core guix builds are done with.

    Closing for now.

  37. fanquake closed this on Aug 15, 2022
  38. bitcoin locked this on Aug 15, 2023


rnapoles fanquake DrahtBot sipsorcery MarcoFalke

Labels
Docs Windows Tests Needs rebase

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-09-29 01:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me