Bitcoin Core wallet -> HD key generation disabled #25066

issue Garcialojav opened this issue on May 5, 2022
  1. Garcialojav commented at 9:52 AM on May 5, 2022: none

    The Bitcoin Core wallet window has icons in the lower right corner. One of those icons is the letters "HD". With the v.22.0 version when passing the mouse cursor over this icon, a message appeared which said "HD key generation is enabled". However, after downloading the latest version of Bitcoin Core, 23.0, the message that appears to me is the opposite: "HD key generation is disabled". (1st screenshot).

    The wallet had no funds and, in that sense, I have not lost anything. But I am concerned that after upgrading Bitcoin Core to the latest version, the HD key generation has changed. I'm pretty new to this and don't understand much. I have asked, read and looked for some solution but no one has been able to tell me what happens, whether it is normal or not, what the solution is...etc.

    Also note that, when using the "getwalletinfo" command in the Bitcoin Core console, appeared this (2nd screenshot) and that I do not know if it refers to the same (HD key generation) or not.

    Also tried to upgrade the bitcoin core wallet with the "upgradewallet" comand. (3rd screenshot)

    I got the latest version of bitcoin core from: https://bitcoincore.org/. And i got this url from the Bitcoin Core Project profile on twitter.

    My OS is windows 10 Pro. And my CPU is a Intel(R) Core(TM) i5-4460 CPU @ 3.20GHz 3.20 GHz.

    For me this is first time doing this...so sorry for what might be wrong, and sorry for my english (i do not speak it well enough)

    Captura de pantalla 2022-05-05 113132 Captura de pantalla 2022-05-01 200018 UPGRADE WALLET

  2. Garcialojav added the label Bug on May 5, 2022
  3. achow101 commented at 2:57 PM on May 5, 2022: member

    Do you see hdseedid in the getwalletinfo output?

    IIRC if the wallet does not have HD enabled, the icon is also crossed out in addition to saying disabled. I suspect this is just a display bug.

    It is also possible that this is a translation error. If you change the language to english, what does it say?

  4. Garcialojav commented at 7:16 PM on May 5, 2022: none

    Yes, i see "hdseedid"in the "getwalletinfo" output, and seems right. Once i've changed to american english language it says it is enabled...

    Thank you so much for your help. Would like to ask to you what IIRC means, well, you know, to learn more things about all of this.

    Captura de pantalla 2022-05-05 210642

  5. sipa commented at 7:17 PM on May 5, 2022: member

    IIRC = If I Recall Correctly

  6. Garcialojav commented at 7:37 PM on May 5, 2022: none

    Ok, Thank's a lot!

    Finally seems a transaction error. I'm going to close the issue but not before thanking the entire bitcoiner community for how well they have treated me. Keep it up because it's amazing to find so many good people. Again thank you so much to all of you

  7. Garcialojav closed this on May 5, 2022

  8. murchandamus commented at 8:26 PM on May 5, 2022: contributor

    Just a moment, we should definitely fix the translation error still! There seem to be multiple Spanish translations:

    • Spanish (es)
    • Spanish (Chile) (es_CL)
    • Spanish (Colombia) (es_CO)
    • Spanish (Dominican Republic) (es_DO)
    • Spanish (Mexico) (es_MX)
    • Spanish (Venezuela) (es_VE)

    Could you let us know which one you were using? I checked Spanish (es), but didn't find the incorrect string and only then realized that there are multiple translations. The translations for Bitcoin Core are being coordinated on https://www.transifex.com/bitcoin if you want to jump in and fix it yourself.

  9. achow101 commented at 8:35 PM on May 5, 2022: member

    I checked all of the spanish translations and nothing there indicates that the wrong string is used. It may be an intermittent bug that goes away when the software is restarted rather than a translations problem.

  10. w0xlt commented at 8:46 PM on May 5, 2022: contributor

    From the text, it appears to be Spanish (Colombia) (es_CO).

    I changed the OS language to es_CO but could not reproduce the error.

    I also checked the ts files and the translation is correct.

  11. Garcialojav reopened this on May 6, 2022

  12. Garcialojav commented at 9:55 AM on May 6, 2022: none

    Just a moment, we should definitely fix the translation error still! There seem to be multiple Spanish translations:

    * Spanish (es)
    
    * Spanish (Chile) (es_CL)
    
    * Spanish (Colombia) (es_CO)
    
    * Spanish (Dominican Republic) (es_DO)
    
    * Spanish (Mexico) (es_MX)
    
    * Spanish (Venezuela) (es_VE)

    Could you let us know which one you were using? I checked Spanish (es), but didn't find the incorrect string and only then realized that there are multiple translations. The translations for Bitcoin Core are being coordinated on https://www.transifex.com/bitcoin if you want to jump in and fix it yourself.

    Hi! Ok, sorry, first time here and i thought that something as unimportant as what was happening to me... you might think it was better to close it.

    I was using the spanish (es) translation. I'll try to to get in touch with them to see if there is any error... who knows, maybe it is not a translation error

  13. Garcialojav commented at 10:05 AM on May 6, 2022: none

    I checked all of the spanish translations and nothing there indicates that the wrong string is used. It may be an intermittent bug that goes away when the software is restarted rather than a translations problem.

    it's possible you are right because in english everything seems to be correct, but I change to Spanish (es) and, when i restart BC, it comes out again like the HD key generation is disabled

  14. Garcialojav commented at 10:15 AM on May 6, 2022: none

    From the text, it appears to be Spanish (Colombia) (es_CO).

    I changed the OS language to es_CO but could not reproduce the error.

    I also checked the ts files and the translation is correct.

    gonna try with other spanish languages, what i got is that the "HD key generation is disabled" comes out with:

    • Spanish (es)
    • Spanish (republica Dominicana)
    • Spanish (Venezuela)

    The other spanish languages seems to be right

  15. murchandamus commented at 12:36 PM on May 6, 2022: contributor

    I think I found it: image

    Gonna try to submit a correction.

  16. murchandamus commented at 12:39 PM on May 6, 2022: contributor

    Not sure if I did that right, but this looks better to me: image

  17. w0xlt commented at 1:00 PM on May 6, 2022: contributor

    @Xekyo where did you find this text ? The only file I found the expression La generación de clave HD está deshabilitada is the bitcoin_es_CO.ts and looks correct there:

        <message>
            <source>HD key generation is &lt;b&gt;enabled&lt;/b&gt;</source>
            <translation type="unfinished">La generación de clave HD está &lt;b&gt;habilitada&lt;/b&gt;</translation>
        </message>
        <message>
            <source>HD key generation is &lt;b&gt;disabled&lt;/b&gt;</source>
            <translation type="unfinished">La generación de clave HD está &lt;b&gt;deshabilitada&lt;/b&gt;</translation>
        </message>
    
  18. achow101 commented at 1:55 PM on May 6, 2022: member

    Ah, in the 23.x branch the translation is backwards. These translations are different from the ones in master as they have been updated for the release, but master is not.

    src/qt/locale/bitcoin_es.ts:1072:    <message>
    src/qt/locale/bitcoin_es.ts:1073:        <source>HD key generation is &lt;b&gt;enabled&lt;/b&gt;</source>
    src/qt/locale/bitcoin_es.ts:1074:        <translation type="unfinished">La generación de clave HD está &lt;b&gt;deshabilitada&lt;/b&gt;</translation>
    src/qt/locale/bitcoin_es.ts:1075:    </message>
    src/qt/locale/bitcoin_es.ts:1076:    <message>
    src/qt/locale/bitcoin_es.ts:1077:        <source>HD key generation is &lt;b&gt;disabled&lt;/b&gt;</source>
    src/qt/locale/bitcoin_es.ts:1078:        <translation type="unfinished">La generación de clave HD está &lt;b&gt;habilitada&lt;/b&gt;</translation>
    src/qt/locale/bitcoin_es.ts:1079:    </message>
    src/qt/locale/bitcoin_es.ts:1080:    <message>
    
  19. laanwj commented at 1:56 PM on May 6, 2022: member

    A bit of an off-topic question (also @hebasto): do we actually need so many Spanish variants?

  20. murchandamus commented at 2:11 PM on May 6, 2022: contributor

    @Xekyo where did you find this text ? The only file I found the expression La generación de clave HD está deshabilitada is the bitcoin_es_CO.ts and looks correct there:

    I found it in Spanish (es).

  21. w0xlt commented at 2:37 PM on May 6, 2022: contributor

    @Xekyo I noticed I can´t find it on the master branch because it was removed from bitcoin_es.ts in b67ef6d59b832035aae85f8f59ca27bcbc8bc531.

    Would you know why it was removed?

  22. murchandamus commented at 3:08 PM on May 6, 2022: contributor

    @w0xlt: Sorry, before yesterday, I only knew that Bitcoin used Transifex but had never interacted with any of the translations.

  23. w0xlt commented at 3:11 PM on May 6, 2022: contributor

    @Xekyo Thanks.

  24. Garcialojav commented at 6:10 PM on May 6, 2022: none

    @Xekyo #25066 (comment) Yes, you re right, looks much more better! Thanks a lot for being so involved!

    And again, to all of you, keep doing like this please, because, you make the community amazing and for people like me, with little technological/computer knowledge, you make the difference

  25. murchandamus commented at 7:35 PM on May 6, 2022: contributor

    A bit of an off-topic question (also @hebasto): do we actually need so many Spanish variants?

    I would imagine that they may differ in details but generally match all across. It would seem that they should rather be a patchset for some phrases rather than wholly independent translations. Maybe @Garcialojav can weigh in more on that?

  26. Garcialojav commented at 5:04 AM on May 7, 2022: none

    A bit of an off-topic question (also @hebasto): do we actually need so many Spanish variants?

    I would imagine that they may differ in details but generally match all across. It would seem that they should rather be a patchset for some phrases rather than wholly independent translations. Maybe @Garcialojav can weigh in more on that?

    You are very right, it does not seem to me that there is so much difference between one and the others as to make different translations. A translation for all of them with some other patch for more specific things should be enough and give a better result.

  27. hebasto commented at 9:47 AM on May 7, 2022: member

    Some notes about the way how the Bitcoin Core project interacts with Transifex.

    1. Translation resources--including translation files--are bounded to release branches, not to the master one. Although, translations in the master branch itself are being updated from time to time, it is not advised to rely on them. In other words, the translated GUI is supposed to be used only with release binaries.
    2. Transifex does not have a concept of "similar" languages, and it does not support a patching of translation files. Patching them on our side would break a separation of responsibilities between coding and translation.

    Just a moment, we should definitely fix the translation error still! There seem to be multiple Spanish translations:

    • Spanish (es)

    • Spanish (Chile) (es_CL)

    • Spanish (Colombia) (es_CO)

    • Spanish (Dominican Republic) (es_DO)

    • Spanish (Mexico) (es_MX)

    • Spanish (Venezuela) (es_VE)

    Could you let us know which one you were using? I checked Spanish (es), but didn't find the incorrect string and only then realized that there are multiple translations. The translations for Bitcoin Core are being coordinated on https://www.transifex.com/bitcoin if you want to jump in and fix it yourself.

    • es: coordinator seone (neither active nor reachable), 351 translators
    • es_CL: coordinator seone (neither active nor reachable), 35 translators
    • es_CO: no coordinators, 47 translators
    • es_DO: coordinator deamon3, 13 translators
    • es_MX: coordinator mborruel, 101 translators
    • es_VE: no coordinators, 35 translators

    es_MX for the 23.x branch does not contain any significant amount of actually translated strings. Most of them are just marked as "translated". Therefore, this translation file was skipped by the update-translations.py script.

    es_DO and es_VE have not those two string been translated.

    es has been already fixed by @Xekyo:

    image

    But this fixup will be pulled into the 23.x branch only for v23.1 release.

  28. hebasto commented at 9:57 AM on May 7, 2022: member

    @laanwj

    A bit of an off-topic question (also @hebasto): do we actually need so many Spanish variants?

    I'm Ukrainian and I don't speak any Spanish dialect :)

    es_MX for the 23.x branch does not contain any significant amount of actually translated strings. Most of them are just marked as "translated". Therefore, this translation file was skipped by the update-translations.py script.

    To do not rush, we could start from removing Spanish (Mexico) (es_MX).

    As for other Spanish dialects, I have no opinion for now..

  29. laanwj commented at 6:48 PM on May 9, 2022: member

    I'm Ukrainian and I don't speak any Spanish dialect :)

    Haha I understand, it was just that you've been involved with translations before so I thought I'd ask you into the discussion.

    Patching them on our side would break a separation of responsibilities between coding and translation.

    Transifex doesn't have explicit support for that, but it's how Qt's translation system already works internally; if it looks up a message for say, es_MX, it will check es_MX then es then en (base translation).

    So if, say, es_MX has only a few messages (the ones that are different from es) it would work out. But getting to that state without Transifex having UI support for this is going to be difficult to impossible.

    To do not rush, we could start from removing Spanish (Mexico) (es_MX).

    Agree.

  30. murchandamus commented at 6:51 PM on May 9, 2022: contributor

    It might also be interesting to see where all these different Spanish translations even differ at all.

  31. omirete commented at 3:45 PM on July 28, 2022: none

    Hi, spanish is my mother tongue! :) I hope I can provide some clarity on the multiple translations/variants:

    Generally speaking, for written language the es translation (spanish from Spain) should be enough as all spanish speakers will understand it.

    That said, it would still be nice to have a second translation with words that are more familiar to latin american people. In my opinion, es_CO should do the trick because the spanish in Colombia is usually regarded as the most neutral of the latin american variants.

  32. fanquake commented at 2:22 PM on August 8, 2022: member

    What is the status of this issue? Is this being solved upstream in transifex? Does it require changes in this repository? Should it be something we have done for 24.0?

  33. MarcoFalke added the label Wallet on Aug 10, 2022
  34. Garcialojav commented at 5:47 AM on August 16, 2022: none

    I'm afraid I can't answer those questions. In my opinion, I think this issue could be closed, so, unless someone for good reason tells me otherwise, I will close it next week.

  35. Garcialojav closed this on Aug 24, 2022

  36. bitcoin locked this on Aug 24, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 15:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me