Remove send to IP address and IP transactions support #253

pull laanwj wants to merge 0 commits into bitcoin:master from laanwj:master changing 0 files +0 −0
  1. laanwj commented at 8:58 AM on May 22, 2011: member

    Remove send to IP transaction support, as it is insecure and would confuse users when used.

    An IP is a terrible identifier as it does not identify a person or organization. Furthermore, man-in-the-middle attacks are trivial as the internet has no "proof that you have ip XXX" API. In the future address shortening services based on "user@domain" would be useful, but these will likely be based on third party APIs and not on this code.

    • Removes logic to accept transfers by IP
    • Removes UI logic to send transfers by IP (CSendingDialog). Entering an IP in the send box will always result in an error.

    Discussion on forum: https://forum.bitcoin.org/index.php?topic=9334.0

  2. jgarzik commented at 9:03 AM on June 14, 2011: contributor

    ACK

    and I think Gavin is in favor of this, too

  3. TheBlueMatt commented at 8:48 PM on July 2, 2011: member

    NACK, it would appear code was ripped out of uibase.* without modifying the uiproject.fpb file meaning no one can edit the wxUI in the future.

  4. jgarzik commented at 2:12 AM on July 13, 2011: contributor

    Also, please update for latest changes (lots!). We wanted to pull wallet crypto first.

  5. laanwj commented at 7:10 AM on July 13, 2011: member

    yeah I will, first have to get this wx dialog editor tooling

  6. gmaxwell commented at 7:07 AM on July 18, 2011: contributor

    Aww. The removal of this would mean we can't run a lottery for nodes running the most recent version of bitcoin as an incentive to make people upgrade. :)

  7. laanwj commented at 7:50 AM on July 18, 2011: member

    Wow, you probably hit upon the first actual useful application for send to IP transactions. But watch out for people MITMing you to steal the incentives :)

  8. gmaxwell commented at 7:53 AM on July 18, 2011: contributor

    Well, if they are going to go through the trouble of setting up something that pretends to be a current node it would be easier to actually RUN a current node. The lottery could do some reasonable health checks too. :) Like make sure the winner can feed the block chain and forward a transaction.

  9. laanwj merged this on Sep 18, 2011
  10. laanwj closed this on Sep 18, 2011

  11. dexX7 referenced this in commit 43a7014c57 on Sep 26, 2015
  12. deadalnix referenced this in commit 0f2d95da6b on Jan 19, 2017
  13. destenson referenced this in commit 8d84d61e90 on Nov 18, 2017
  14. classesjack referenced this in commit 9119339b64 on Jan 2, 2018
  15. attilaaf referenced this in commit 97100fe9a2 on Jan 13, 2020
  16. rajarshimaitra referenced this in commit c1266e5e13 on Aug 5, 2021
  17. DrahtBot locked this on Aug 16, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me