util: remove MSVC warning pragmas #25492

1. 
   fanquake commented at 4:29 pm on June 28, 2022: member

   4786 - I don’t think this exists any more? 4805 - Is already defined (globally) there.

   Dropped 4717 and 4804, as it seems they are no-longer supressing anything.

   See: https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warnings-c4000-c5999.

2. fanquake added the label Windows on Jun 28, 2022
3. 
   hebasto commented at 4:30 pm on June 28, 2022: member

   Concept ACK.
4. 
   hebasto commented at 9:52 am on June 29, 2022: member

   I agree to move MSVC-specific warning pragmas into MSVC project, but making them global is a drawback. It would be better to place them in build_msvc/libbitcoin_util/libbitcoin_util.vcxproj.in.

   Add 4717 and 4804. I did not check if they are still required etc.

   But, it appears that those warnings are not fired at all – https://api.cirrus-ci.com/v1/task/6384778386604032/logs/build.log

5. 
   MarcoFalke commented at 9:58 am on June 29, 2022: member

   Personally I think it is fine to make them global. We mostly care that msvc can compile at all, not about the warnings. If there are any warnings that are severe, we should obviously fix them, but for noisy warnings there should be no risk in just disabling them globally.
6. util: remove MSVC warning pragmas

   4786 - I don't think this exists any more?
   4805 - Is already defined (globally) in the MSVC project.
   
   Dropped 4717 and 4804, as it seems they are no-longer supressing
   anything.
   
   See:
   https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warnings-c4000-c5999

   d8f8f7812c
7. fanquake force-pushed on Jun 29, 2022
8. 
   fanquake commented at 10:13 am on June 29, 2022: member

   I’ve now just dropped the pragmas entirely, rather than moving any to the MSVC project.
9. MarcoFalke renamed this:
   msvc: move warning pragmas to MSVC project
   util: remove MSVC warning pragmas
   on Jun 29, 2022
10. MarcoFalke added the label Build system on Jun 29, 2022
11. MarcoFalke added the label Refactoring on Jun 29, 2022
12. hebasto approved
13. 
    hebasto commented at 10:31 am on June 29, 2022: member

    ACK d8f8f7812cfa50e853d30f53273601dca57a60ec, build log is free of warnings.
14. MarcoFalke merged this on Jun 29, 2022
15. MarcoFalke closed this on Jun 29, 2022

    ---

16. fanquake deleted the branch on Jun 29, 2022
17. sidhujag referenced this in commit 833986e445 on Jun 29, 2022
18. DrahtBot locked this on Jun 29, 2023

Contributors
fanquake hebasto MarcoFalke

Labels
Refactoring Windows Build system