build: use package_cc for linux qt build #25822

pull fanquake wants to merge 2 commits into bitcoin:master from fanquake:test_22184 changing 1 files +8 −3
  1. fanquake commented at 2:52 PM on August 11, 2022: member

    Could be enough to close #22184.

    make -C depends qt CC=gcc-12 CXX=g++-12 -j9 DEBUG=1
    ...
    # qmake build
    gmake[1]: Entering directory '/home/ubuntu/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.15.5-59cf8e423fe/qtbase/qmake'
    g++-12 -c -o main.o   -std=c++11 -ffunction-sections -fdata-sections -O2 -g  -I/home/ubuntu/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.15.5-59cf8e423fe/qtbase/qmake -I/home/ubuntu/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.15.5-59cf8e423fe/qtbase/qmake/library -I/home/ubuntu/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.15.5-59cf8e423fe/qtbase/qmake/generators -I/home/ubuntu/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.15.5-59cf8e423fe/qtbase/src/3rdparty/tinycbor/src -I/home/ubuntu/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.15.5-59cf8e423fe/qtbase/qmake/generators/unix -I/home/ubuntu/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.15.5-59cf8e423fe/qtbase/qmake/generators/win32 -I/home/ubuntu/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.15.5-59cf8e423fe/qtbase/qmake/generators/mac -I/home/ubuntu/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.15.5-59cf8e423fe/qtbase/include -I/home/ubuntu/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.15.5-59cf8e423fe/qtbase/include/QtCore -I/home/ubuntu/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.15.5-59cf8e423fe/qtbase/include/QtCore/5.15.5 -I/home/ubuntu/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.15.5-59cf8e423fe/qtbase/include/QtCore/5.15.5/QtCore -I../src/corelib/global -I/home/ubuntu/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.15.5-59cf8e423fe/qtbase/mkspecs/linux-g++ -DQT_VERSION_STR=\"5.15.5\" -DQT_VERSION_MAJOR=5 -DQT_VERSION_MINOR=15 -DQT_VERSION_PATCH=5 -DQT_BUILD_QMAKE -DQT_BOOTSTRAPPED -DPROEVALUATOR_FULL -DQT_NO_FOREACH /home/ubuntu/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.15.5-59cf8e423fe/qtbase/qmake/main.cpp
    ...
    # qt configure checks
    > g++-12 -c -m64 -pipe -pipe -std=c++17 -O1 -D_GLIBCXX_DEBUG -D_GLIBCXX_DEBUG_PEDANTIC -D_LIBCPP_DEBUG=1 -I/home/ubuntu/bitcoin/depends/x86_64-pc-linux-gnu/include -maes -O2 -std=gnu++11 -w -fPIC -DNO_ATTRIBUTE -DQT_COMPILER_SUPPORTS_AESNI -I/home/ubuntu/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.15.5-59cf8e423fe/qtbase/config.tests/x86_simd -I. -I/home/ubuntu/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.15.5-59cf8e423fe/qtbase/mkspecs/linux-g++-64 -o main.o /home/ubuntu/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.15.5-59cf8e423fe/qtbase/config.tests/x86_simd/main.cpp
    # qt configuration
    Building on: linux-g++ (x86_64, CPU features: mmx sse sse2)
    Building for: linux-g++-64 (x86_64, CPU features: mmx sse sse2)
    Target compiler: unknown (gcc-12)
    Configuration: cross_compile sse2 aesni sse3 ssse3 sse4_1 sse4_2 avx avx2 avx512f avx512bw avx512cd avx512dq avx512er avx512ifma avx512pf avx512vbmi avx512vl enable_new_dtags f16c largefile optimize_debug precompile_header rdrnd rdseed shani x86SimdAlways debug c++11 c++14 c++17 c++1z dbus reduce_exports release_tools static stl
    ......
    # qt build
    make[4]: Entering directory '/home/ubuntu/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.15.5-e9a047354b8/qtbase/src/corelib'
    g++-12 -c -o qlibraryinfo_final.o   -std=c++11 -ffunction-sections -fdata-sections -O2 -g  -I/home/ubuntu/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.15.5-59cf8e423fe/qtbase/qmake -I/home/ubuntu/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.15.5-59cf8e423fe/qtbase/qmake/library -I/home/ubuntu/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.15.5-59cf8e423fe/qtbase/qmake/generators -I/home/ubuntu/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.15.5-59cf8e423fe/qtbase/src/3rdparty/tinycbor/src -I/home/ubuntu/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.15.5-59cf8e423fe/qtbase/qmake/generators/unix -I/home/ubuntu/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.15.5-59cf8e423fe/qtbase/qmake/generators/win32 -I/home/ubuntu/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.15.5-59cf8e423fe/qtbase/qmake/generators/mac -I/home/ubuntu/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.15.5-59cf8e423fe/qtbase/include -I/home/ubuntu/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.15.5-59cf8e423fe/qtbase/include/QtCore -I/home/ubuntu/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.15.5-59cf8e423fe/qtbase/include/QtCore/5.15.5 -I/home/ubuntu/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.15.5-59cf8e423fe/qtbase/include/QtCore/5.15.5/QtCore -I../src/corelib/global -I/home/ubuntu/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.15.5-59cf8e423fe/qtbase/mkspecs/linux-g++ -DQT_VERSION_STR=\"5.15.5\" -DQT_VERSION_MAJOR=5 -DQT_VERSION_MINOR=15 -DQT_VERSION_PATCH=5 -DQT_BUILD_QMAKE -DQT_BOOTSTRAPPED -DPROEVALUATOR_FULL -DQT_NO_FOREACH /home/ubuntu/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.15.5-59cf8e423fe/qtbase/src/corelib/global/qlibraryinfo.cpp
    

    Guix Build (x86_64):

    Guix Build (arm64):

  2. fanquake added the label Build system on Aug 11, 2022
  3. jarolrod commented at 8:44 PM on August 11, 2022: member

    GUIX hashes

    x86:

    find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
    
    6762af74e4b25a5dbefd9e8d2c4b1cd3a9cedeb7db8fb4577d6cdd19e823fc36  guix-build-b9008b1834e6/output/aarch64-linux-gnu/SHA256SUMS.part
    4838f6dc229e46869eeddf785145dd2241f64bd5469f011f3960cd710321a97c  guix-build-b9008b1834e6/output/aarch64-linux-gnu/bitcoin-b9008b1834e6-aarch64-linux-gnu-debug.tar.gz
    adb68487dd38da6d8bd4e51c3ca4d06e8c725be04e3bf8c10363120494b6d0b9  guix-build-b9008b1834e6/output/aarch64-linux-gnu/bitcoin-b9008b1834e6-aarch64-linux-gnu.tar.gz
    daeca143f20312ddf2785dda38ee67bca60f29593d8382cd7ce7deaac9d8b0dc  guix-build-b9008b1834e6/output/arm-linux-gnueabihf/SHA256SUMS.part
    ae0296d959d8b4a9b077cd9ab9077a8acf49fe461ffdc5f6269bc6acd6a377c5  guix-build-b9008b1834e6/output/arm-linux-gnueabihf/bitcoin-b9008b1834e6-arm-linux-gnueabihf-debug.tar.gz
    fdac3eaf571f5cfdcd8be7a835bddae4fb037544956061b165190075f3d95145  guix-build-b9008b1834e6/output/arm-linux-gnueabihf/bitcoin-b9008b1834e6-arm-linux-gnueabihf.tar.gz
    a1f0dd76a98d8e549da281acc3215f9ea5469a1c2217939faa212acc086dd45e  guix-build-b9008b1834e6/output/arm64-apple-darwin/SHA256SUMS.part
    485e812c47dd07a7a645708aa5e88e9f15976d68e3219f66160cb8a07bf69517  guix-build-b9008b1834e6/output/arm64-apple-darwin/bitcoin-b9008b1834e6-arm64-apple-darwin-unsigned.dmg
    7b48061fb57073f10305b677f5cdccd61be067bff5727a4f9ff985ab35cc43af  guix-build-b9008b1834e6/output/arm64-apple-darwin/bitcoin-b9008b1834e6-arm64-apple-darwin-unsigned.tar.gz
    650e0e4bce9a69f05966a6ad6b473d94cdcb41e8e422c2577c75399025ecf0a4  guix-build-b9008b1834e6/output/arm64-apple-darwin/bitcoin-b9008b1834e6-arm64-apple-darwin.tar.gz
    752d61ffc2e2c5f6f9a633de6e27b63349d45306c5958ace8bd5962e556187a3  guix-build-b9008b1834e6/output/dist-archive/bitcoin-b9008b1834e6.tar.gz
    ba95887083b937530809239a5fcea6218cf6ce3432dd8793a8c6400ebeb37c5f  guix-build-b9008b1834e6/output/powerpc64-linux-gnu/SHA256SUMS.part
    cffe7deb1831dcaccfbf84392514b9cf7ca9a1aa103229d38e7129cdd7bec8e2  guix-build-b9008b1834e6/output/powerpc64-linux-gnu/bitcoin-b9008b1834e6-powerpc64-linux-gnu-debug.tar.gz
    72dca7d1a2ed04d60aae20a897f200363c5e99b241126f21c1947a96142c7b78  guix-build-b9008b1834e6/output/powerpc64-linux-gnu/bitcoin-b9008b1834e6-powerpc64-linux-gnu.tar.gz
    677e90f240eac5ad1d0f2c8fc587ad2023bee5b68732835dac59e818c0686f6d  guix-build-b9008b1834e6/output/powerpc64le-linux-gnu/SHA256SUMS.part
    3c083cb8963ef6fda9109fc615c5bddf04942eaff538de48c858b805d5e9eea7  guix-build-b9008b1834e6/output/powerpc64le-linux-gnu/bitcoin-b9008b1834e6-powerpc64le-linux-gnu-debug.tar.gz
    9668d4a8491bea5cabe4fb12e19e930d4392ea52da66e9e939eb99da730005e6  guix-build-b9008b1834e6/output/powerpc64le-linux-gnu/bitcoin-b9008b1834e6-powerpc64le-linux-gnu.tar.gz
    aa7c025805817c5df29a5904e3facf86e5a76fbe2135c9361c767e0f5632c6cf  guix-build-b9008b1834e6/output/riscv64-linux-gnu/SHA256SUMS.part
    465475e5c95f45bc2230c1c3202ffe9d8385886b11072a8649f814d32f9507f0  guix-build-b9008b1834e6/output/riscv64-linux-gnu/bitcoin-b9008b1834e6-riscv64-linux-gnu-debug.tar.gz
    a833854f65957f35eaa5e177aef82563b0684046ee62972984c27aa08d02d5c1  guix-build-b9008b1834e6/output/riscv64-linux-gnu/bitcoin-b9008b1834e6-riscv64-linux-gnu.tar.gz
    206a9595ae3e11e1196c36aa1c25926555f4c57f7b8224f76425207ddb619bbe  guix-build-b9008b1834e6/output/x86_64-apple-darwin/SHA256SUMS.part
    45f79518c59a57131ec382d3473fcfc06d0ef7f0456958900b20c7f20cbb6bbc  guix-build-b9008b1834e6/output/x86_64-apple-darwin/bitcoin-b9008b1834e6-x86_64-apple-darwin-unsigned.dmg
    31cafdd104ad48407850f8e79774a645cb09fc12443fb0af11837824caf22dde  guix-build-b9008b1834e6/output/x86_64-apple-darwin/bitcoin-b9008b1834e6-x86_64-apple-darwin-unsigned.tar.gz
    438df7e2be5461667a590d8bcb7b737bdf0d902716aa6cd61ccc17cd4f9387ef  guix-build-b9008b1834e6/output/x86_64-apple-darwin/bitcoin-b9008b1834e6-x86_64-apple-darwin.tar.gz
    2183a29868a295ad69aaad98dadabaa60f380143ac638ab550b79c5685787774  guix-build-b9008b1834e6/output/x86_64-linux-gnu/SHA256SUMS.part
    12219c4b5f2332f45815d4f4177f40e784164de244752ae5da5010cf7c62d48d  guix-build-b9008b1834e6/output/x86_64-linux-gnu/bitcoin-b9008b1834e6-x86_64-linux-gnu-debug.tar.gz
    421f8b478a8fdb89d8a904937008c19bc183f4ac41cebdfa09aff92153ca6293  guix-build-b9008b1834e6/output/x86_64-linux-gnu/bitcoin-b9008b1834e6-x86_64-linux-gnu.tar.gz
    f06d07c8e3f3b18e9602f4ffd6ca46133f94682ef4836c92cdaa2ab951dc8980  guix-build-b9008b1834e6/output/x86_64-w64-mingw32/SHA256SUMS.part
    23ad139c570b5279185d86928f95edaaa6a9f1290bba81b3ded4528c5bdaf23f  guix-build-b9008b1834e6/output/x86_64-w64-mingw32/bitcoin-b9008b1834e6-win64-debug.zip
    54ada785cdf0a4b58e3c1f5ac2a1f869a7238c1bc3523b51dbee5d5c0ae20748  guix-build-b9008b1834e6/output/x86_64-w64-mingw32/bitcoin-b9008b1834e6-win64-setup-unsigned.exe
    83dc62b8081872d897a93e26d78af51945fad9db70cc80f00da64175cdb2a323  guix-build-b9008b1834e6/output/x86_64-w64-mingw32/bitcoin-b9008b1834e6-win64-unsigned.tar.gz
    fb8f0ea315f8cec301e74ead47b20a74641bd003c1e450cb802bf8ed566e9dc7  guix-build-b9008b1834e6/output/x86_64-w64-mingw32/bitcoin-b9008b1834e6-win64.zip
    

    arm64:

    find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
    
    daeca143f20312ddf2785dda38ee67bca60f29593d8382cd7ce7deaac9d8b0dc  guix-build-b9008b1834e6/output/arm-linux-gnueabihf/SHA256SUMS.part
    ae0296d959d8b4a9b077cd9ab9077a8acf49fe461ffdc5f6269bc6acd6a377c5  guix-build-b9008b1834e6/output/arm-linux-gnueabihf/bitcoin-b9008b1834e6-arm-linux-gnueabihf-debug.tar.gz
    fdac3eaf571f5cfdcd8be7a835bddae4fb037544956061b165190075f3d95145  guix-build-b9008b1834e6/output/arm-linux-gnueabihf/bitcoin-b9008b1834e6-arm-linux-gnueabihf.tar.gz
    3d40d28e7b3e762adc5aec5e4794f770c89eaafa18b7beed51b30f0b3866b803  guix-build-b9008b1834e6/output/arm64-apple-darwin/SHA256SUMS.part
    a5bb1494b96762a1c60dc8d8314fef25b63906000f914e777d6974c5072d9444  guix-build-b9008b1834e6/output/arm64-apple-darwin/bitcoin-b9008b1834e6-arm64-apple-darwin-unsigned.dmg
    837b476c36df76aefb6ceaf7fe0e9a662fa01648270c5994b98d6ba2f55b7dfa  guix-build-b9008b1834e6/output/arm64-apple-darwin/bitcoin-b9008b1834e6-arm64-apple-darwin-unsigned.tar.gz
    4e85e11a3e682f32d94e34b875fb773feececaaa030e978c8cd6de633ae9d8e6  guix-build-b9008b1834e6/output/arm64-apple-darwin/bitcoin-b9008b1834e6-arm64-apple-darwin.tar.gz
    752d61ffc2e2c5f6f9a633de6e27b63349d45306c5958ace8bd5962e556187a3  guix-build-b9008b1834e6/output/dist-archive/bitcoin-b9008b1834e6.tar.gz
    ba95887083b937530809239a5fcea6218cf6ce3432dd8793a8c6400ebeb37c5f  guix-build-b9008b1834e6/output/powerpc64-linux-gnu/SHA256SUMS.part
    cffe7deb1831dcaccfbf84392514b9cf7ca9a1aa103229d38e7129cdd7bec8e2  guix-build-b9008b1834e6/output/powerpc64-linux-gnu/bitcoin-b9008b1834e6-powerpc64-linux-gnu-debug.tar.gz
    72dca7d1a2ed04d60aae20a897f200363c5e99b241126f21c1947a96142c7b78  guix-build-b9008b1834e6/output/powerpc64-linux-gnu/bitcoin-b9008b1834e6-powerpc64-linux-gnu.tar.gz
    677e90f240eac5ad1d0f2c8fc587ad2023bee5b68732835dac59e818c0686f6d  guix-build-b9008b1834e6/output/powerpc64le-linux-gnu/SHA256SUMS.part
    3c083cb8963ef6fda9109fc615c5bddf04942eaff538de48c858b805d5e9eea7  guix-build-b9008b1834e6/output/powerpc64le-linux-gnu/bitcoin-b9008b1834e6-powerpc64le-linux-gnu-debug.tar.gz
    9668d4a8491bea5cabe4fb12e19e930d4392ea52da66e9e939eb99da730005e6  guix-build-b9008b1834e6/output/powerpc64le-linux-gnu/bitcoin-b9008b1834e6-powerpc64le-linux-gnu.tar.gz
    aa7c025805817c5df29a5904e3facf86e5a76fbe2135c9361c767e0f5632c6cf  guix-build-b9008b1834e6/output/riscv64-linux-gnu/SHA256SUMS.part
    465475e5c95f45bc2230c1c3202ffe9d8385886b11072a8649f814d32f9507f0  guix-build-b9008b1834e6/output/riscv64-linux-gnu/bitcoin-b9008b1834e6-riscv64-linux-gnu-debug.tar.gz
    a833854f65957f35eaa5e177aef82563b0684046ee62972984c27aa08d02d5c1  guix-build-b9008b1834e6/output/riscv64-linux-gnu/bitcoin-b9008b1834e6-riscv64-linux-gnu.tar.gz
    206a9595ae3e11e1196c36aa1c25926555f4c57f7b8224f76425207ddb619bbe  guix-build-b9008b1834e6/output/x86_64-apple-darwin/SHA256SUMS.part
    45f79518c59a57131ec382d3473fcfc06d0ef7f0456958900b20c7f20cbb6bbc  guix-build-b9008b1834e6/output/x86_64-apple-darwin/bitcoin-b9008b1834e6-x86_64-apple-darwin-unsigned.dmg
    31cafdd104ad48407850f8e79774a645cb09fc12443fb0af11837824caf22dde  guix-build-b9008b1834e6/output/x86_64-apple-darwin/bitcoin-b9008b1834e6-x86_64-apple-darwin-unsigned.tar.gz
    438df7e2be5461667a590d8bcb7b737bdf0d902716aa6cd61ccc17cd4f9387ef  guix-build-b9008b1834e6/output/x86_64-apple-darwin/bitcoin-b9008b1834e6-x86_64-apple-darwin.tar.gz
    2183a29868a295ad69aaad98dadabaa60f380143ac638ab550b79c5685787774  guix-build-b9008b1834e6/output/x86_64-linux-gnu/SHA256SUMS.part
    12219c4b5f2332f45815d4f4177f40e784164de244752ae5da5010cf7c62d48d  guix-build-b9008b1834e6/output/x86_64-linux-gnu/bitcoin-b9008b1834e6-x86_64-linux-gnu-debug.tar.gz
    421f8b478a8fdb89d8a904937008c19bc183f4ac41cebdfa09aff92153ca6293  guix-build-b9008b1834e6/output/x86_64-linux-gnu/bitcoin-b9008b1834e6-x86_64-linux-gnu.tar.gz
    f06d07c8e3f3b18e9602f4ffd6ca46133f94682ef4836c92cdaa2ab951dc8980  guix-build-b9008b1834e6/output/x86_64-w64-mingw32/SHA256SUMS.part
    23ad139c570b5279185d86928f95edaaa6a9f1290bba81b3ded4528c5bdaf23f  guix-build-b9008b1834e6/output/x86_64-w64-mingw32/bitcoin-b9008b1834e6-win64-debug.zip
    54ada785cdf0a4b58e3c1f5ac2a1f869a7238c1bc3523b51dbee5d5c0ae20748  guix-build-b9008b1834e6/output/x86_64-w64-mingw32/bitcoin-b9008b1834e6-win64-setup-unsigned.exe
    83dc62b8081872d897a93e26d78af51945fad9db70cc80f00da64175cdb2a323  guix-build-b9008b1834e6/output/x86_64-w64-mingw32/bitcoin-b9008b1834e6-win64-unsigned.tar.gz
    fb8f0ea315f8cec301e74ead47b20a74641bd003c1e450cb802bf8ed566e9dc7  guix-build-b9008b1834e6/output/x86_64-w64-mingw32/bitcoin-b9008b1834e6-win64.zip
    
  4. hebasto commented at 2:41 PM on August 12, 2022: member

    Qt will claim it's using the wrong compiler in it's configure output, but the correct one is being used.

    Qt does use the wrong compiler during the configuration phase. It could cause mis-configuration.

    I believe the correct solution should be similar to https://github.com/bitcoin/bitcoin/blob/bf3f05f41d27a6be3730432aaa7e22e443f7cafa/depends/packages/qt.mk#L265-L266

  5. fanquake commented at 3:45 PM on August 12, 2022: member

    I believe the correct solution should be similar to

    I did something like this initially, but that didn't seem to work properly. We might end up needing both changes.

  6. doc: remove no-longer needed comment 403e28d2e9
  7. fanquake force-pushed on Aug 12, 2022
  8. build: use package_cc for qt Linux build
    Fixes: #22184.
    11d1fec3ae
  9. fanquake force-pushed on Aug 12, 2022
  10. fanquake commented at 4:24 PM on August 12, 2022: member

    I've pushed up a new change, that seems to work "better", in that the correct compiler is used in more places, and shown in the configure output, but compiling now fails due to something in platform detection:

    thread/qatomic.cpp:1747:4: error: #error "Q_ATOMIC_INT64_IS_SUPPORTED must be defined on a 64-bit platform"
     1747 | #  error "Q_ATOMIC_INT64_IS_SUPPORTED must be defined on a 64-bit platform"
          |    ^~~~~
    In file included from global/qt_pch.h:56:
    In file included from global/qt_pch.h:56:
    ../../include/QtCore/../../src/corelib/thread/qbasicatomic.h: In instantiation of ‘class QBasicAtomicInteger<long long unsigned int>’:
    thread/qsemaphore.h:70:39:   required from here
    global/qglobal.h:121:63: error: static assertion failed: template parameter is an integral of a size not supported on this platform
      121 | #  define Q_STATIC_ASSERT_X(Condition, Message) static_assert(bool(Condition), Message)
          |                                                               ^~~~~~~~~~~~~~~
    ../../include/QtCore/../../src/corelib/thread/qbasicatomic.h:97:5: note: in expansion of macro ‘Q_STATIC_ASSERT_X’
       97 |     Q_STATIC_ASSERT_X(QAtomicOpsSupport<sizeof(T)>::IsSupported, "template parameter is an integral of a size not supported on this platform");
          |     ^~~~~~~~~~~~~~~~~
    make[4]: *** [Makefile:21004: .obj/qsemaphore.o] Error 1
    
  11. hebasto commented at 10:41 AM on August 13, 2022: member

    Modifying of mkspecs/common/g++-base.conf should be enough (https://github.com/bitcoin/bitcoin/pull/25822#issuecomment-1213190461, #22184 (comment), QTBUG-66404).

    ~Feel free to pick up my branch with some additional minor improvements.~

  12. hebasto commented at 1:37 PM on August 13, 2022: member

    While the branch from my previous comment (mostly) works, I do believe that approach in #25838 is more correct and elegant.

  13. fanquake commented at 1:41 PM on August 13, 2022: member

    I'm not planning on investigating this any further, so we can follow up in #25838.

  14. fanquake closed this on Aug 13, 2022

  15. fanquake deleted the branch on Aug 13, 2022
  16. fanquake referenced this in commit cc1efe909e on Aug 15, 2022
  17. bitcoin locked this on Aug 13, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 03:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me