There’s no need for this project to maintain Qt build instructions for Windows. Even less so if they don’t always work, when copy-pasted, and lead to us wasting time trying to debug building qt from source on Windows, i.e #25837.
Just link to the Qt docs instead.
There's no need for this project to maintain Qt build instructions for
Windows. Even less so if they don't always work, when copy-pasted,
and lead to us wasting time trying to debug building qt from source
on Windows, i.e #25837.
Just link to the Qt docs instead.
ACK facfba33e35ac5cf0990982cb6ccd95d611a7748
I agree. I verified that the Qt docs include instructions for msvc, didn’t check for their quality but i would assume their better and will stay up to date more than ours could.
edit: withdraw ACK, per @sipsorcery comment. These instructions can be a starting point and link to more complete documentation. One user who ran into a problem and a maintainer who doesn’t use this and therefore “doesn’t care” about this is no signal to remove it.
They are an exact copy of those in the .cirrus.yml file, so they shouldn’t go stale?
I don’t know. According to #25837 (comment) copy-and-pasting the snippet doesn’t work. I don’t care about this enough to debug, but also don’t want our issue tracker spending time helping people compile Qt from source on Windows.
Mild NACK.
If the msvc build instructions are going to be left in place then even imperfect Qt static build steps are better than nothing. When I first attempted an msvc build of Bitcoin Core the Qt builds took as much tme and effort as all the other projects combined, if not more.
Maybe instead of removing the instructions a note could be added that building a static version of Qt is difficult and the instructions are intended as a starting point only, along with support issues related to them will be closed.
If the consensus is to remove them I can go back to maintaining a static binary on https://github.com/sipsorcery/qt_win_binary. Although the binaries and instructions also invariably got out of date or fell behind.
I don’t care about this enough to debug, but also don’t want our issue tracker spending time helping people compile Qt from source on Windows
NACK if this is the rationale for removing qt build instructions. Maybe instructions could be improved or no changes required as it could help with basic steps.
Even Android build instructions could be improved but that would be out of scope for this pull request.
42-nmake install
43-```
44-
45-One could speed up building with [`jom`](https://wiki.qt.io/Jom), a replacement for `nmake` which makes use of all CPU cores.
46+To build Bitcoin Core with the GUI, building and installing a static version of Qt is required.
47+You can do so following the Qt build instructions, available [here](https://wiki.qt.io/Building_Qt_5_from_Git).
There’s no need for this project to maintain Qt build instructions for Windows. Just link to the Qt docs instead.
https://doc.qt.io/qt-5.15/windows-building.html does not look helpful at all.
Leaning to NACK.
https://doc.qt.io/qt-5.15/windows-building.html does not look helpful at all.
What about it is not helpful? It’s basically a more informative version of our docs.
https://doc.qt.io/qt-5.15/windows-building.html does not look helpful at all.
What about it is not helpful? It’s basically a more informative version of our docs.
Some Qt configuration options are required for our needs. Users need to be provided with Windows version of them.
https://doc.qt.io/qt-5.15/windows-building.html does not look helpful at all.
What about it is not helpful? It’s basically a more informative version of our docs.
Some Qt configuration options are required for our needs. Users need to be provided with Windows version of them.
Agree