Don't announce to non-peer CNodes #2595

pull sipa wants to merge 1 commits into bitcoin:master from sipa:noannloc changing 1 files +1 −1

sipa commented at 2:23 PM on April 30, 2013: member

This is a very minor bug: we tried to send out a "version" message in CNode's constructor, which meant also for pnodeLocalHost, causing a "socket send error 9" under Linux or "socket send error 10038" in Windows.

Fixes #2587
laanwj commented at 3:43 PM on April 30, 2013: member

ACK
sipa commented at 4:08 PM on April 30, 2013: member

@TheBlueMatt is there a problem with pulltester here?
Diapolo commented at 4:43 PM on April 30, 2013: none

@sipa Looks like this is the cause but perhaps just related to some pulltester work. Blocks which should/should not have been accepted but weren't/were: 9
Diapolo commented at 4:47 PM on April 30, 2013: none

ACK, I can confirm this fixes #2587.
jgarzik commented at 5:15 PM on April 30, 2013: contributor

ACK
Don't announce to non-peer CNodes 788064dd12
BitcoinPullTester commented at 7:06 PM on April 30, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/788064dd12ab7a7075ad24771f377587ad93b68d for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
gmaxwell commented at 7:08 PM on April 30, 2013: contributor

ACK
gmaxwell referenced this in commit eef2091fe9 on Apr 30, 2013
gmaxwell merged this on Apr 30, 2013
gmaxwell closed this on Apr 30, 2013
sipa deleted the branch on May 3, 2013
laudney referenced this in commit da1a5d3eb4 on Mar 19, 2014
DrahtBot locked this on Sep 8, 2021

Contributors

Linked (view graph)

#2587 Windows: socket send error 10038 in debug.log