remove create_child_with_parents, make_chain, and create_raw_chain from test_framework/wallet #25965

1. 
   glozow commented at 12:27 pm on August 31, 2022: member

   These 3 functions create packages of transactions without broadcasting: https://github.com/bitcoin/bitcoin/blob/01e1627e25bc5477c40f51da03c3c31b609a85c9/test/functional/test_framework/wallet.py#L393

   They were introduced in #20833 and #21800 to avoid using the wallet in non-wallet functional tests.

   Since then, wonderful people have created the same functionality in MiniWallet, so these are now redundant. I’m rewriting my branches to avoid using them. It would be a good cleanup to (1) refactor the call sites in rpc_packages.py to use MiniWallet instead, and (2) remove these 3 functions from wallet.py.

   This is very similar to #20078.

   Useful skills:

   • Familiarity with our functional test suite
   • Good python3 skills

   Want to work on this issue?

   For guidance on contributing, please read CONTRIBUTING.md before opening your pull request.

2. glozow added the label Refactoring on Aug 31, 2022
3. glozow added the label good first issue on Aug 31, 2022
4. 
   amovfx commented at 5:50 pm on September 22, 2022: none

   Ill take a stab at this
5. 
   fanquake commented at 5:54 pm on September 22, 2022: member

   Ill take a stab at this

   There is already a PR open for this: #25986.

6. 
   amovfx commented at 5:58 pm on September 22, 2022: none

   oh ty.
7. 
   glozow commented at 5:59 pm on September 22, 2022: member

   @amovfx Your help in reviewing #25986 would be greatly appreciated :)
8. glozow closed this on Nov 28, 2022

   ---

9. bitcoin locked this on Nov 28, 2023

Contributors
glozow amovfx fanquake

Labels
Refactoring good first issue