Specified base_uint component size #2629

pull wyager wants to merge 1 commits into bitcoin:master from wyager:master changing 1 files +3 −2

wyager commented at 1:48 AM on May 8, 2013: contributor

A base_uint used to be made of an array of unsigned ints. This works fine on most platforms, but might not work on certain present or future platforms. The code breaks if an unsigned int is 16 or 64 bits, so it might pay to be specific. Also changed "u" to "you" in the comment text.

Specified base_uint component size

A base_uint used to be made of an array of unsigned ints. This works
fine on most platforms, but might not work on certain present or future
platforms. The code breaks if an unsigned int is 16 or 64 bits, so it's
important to be specific. Also changed "u" to "you".

5fdd1251a8

gmaxwell commented at 2:01 AM on May 8, 2013: contributor

ACK. Lots of other size assumptions in the code. No harm in fixing some.
BitcoinPullTester commented at 2:28 AM on May 8, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/5fdd1251a87a0938f48e88970ae976e360c6e09f for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

in src/uint256.h:None in 5fdd1251a8

  20 | @@ -20,14 +21,14 @@
  21 |  
  22 |  
  23 |  /** Base class without constructors for uint256 and uint160.
  24 | - * This makes the compiler let u use it in a union.
  25 | + * This makes the compiler let you use it in a union.

sipa commented at 9:11 AM on May 8, 2013:

Haha, the original comment used "will let us use", which I incorrectly copied in 6b8de05d.

sipa commented at 9:14 AM on May 8, 2013: member

This class can probably be easily rewritten to use GMP's mpn library (making it use 64-bit limbs on x86_64 for example), but that's a much larger change. ACK this.
TheBlueMatt commented at 9:56 AM on May 8, 2013: member

ACK
sipa referenced this in commit 8c6bbb3a86 on May 8, 2013
sipa merged this on May 8, 2013
sipa closed this on May 8, 2013
laudney referenced this in commit 9ca2ddd4c8 on Mar 19, 2014
DrahtBot locked this on Sep 8, 2021

Contributors

Linked (view graph)

#32089 Failure to run Fuzz tests when running with corpus