This is the only use of std::exception in util/system, and paves the ways of further splitting that up to remove circular includes and in support of a minimal kernel.
See overall effort, and prior conversation re motivation.
Include libloaderapi.h for GetModuleFileNameA as that's the source noted here: https://docs.microsoft.com/en-us/windows/win32/api/libloaderapi/nf-libloaderapi-getmodulefilenamea
Recommend using git diff master --color-moved=dimmed-zebra
/cc @dongcarl @ryanofsky
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process. A summary of reviews will appear here.
<!--174a7506f384e20aa4161008e828411d-->
Reviewers, this pull request conflicts with the following ones:
UNREACHABLE macro and drop -Wreturn-type/C4715 warnings suppressions by hebasto)If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
This is a minimal extraction of a single public method, but also
the only use of std::exception in util/system.
Include libloaderapi.h for GetModuleFileNameA as that's the
source noted here: https://docs.microsoft.com/en-us/windows/win32/api/libloaderapi/nf-libloaderapi-getmodulefilenamea