build: remove threadinterrupt from libbitcoinkernel #26360

1. 
   fanquake commented at 8:42 am on October 21, 2022: member

   Extracted from #26292.
2. build: remove threadinterrupt from libbitcoinkernel afbcd227dd
3. fanquake added the label Build system on Oct 21, 2022
4. hebasto approved
5. 
   hebasto commented at 3:43 pm on October 23, 2022: member

   ACK afbcd227dd0889002eeeec6148538ed2e2c9aadb, tested on Ubuntu 22.04.

   FWIW, ./configure --with-experimental-kernel-lib --enable-experimental-util-chainstate && make still works even with the following diff:

    0--- a/src/Makefile.am
    1+++ b/src/Makefile.am
    2@@ -886,7 +886,6 @@ libbitcoinkernel_la_SOURCES = \
    3   chain.cpp \
    4   chainparamsbase.cpp \
    5   chainparams.cpp \
    6-  clientversion.cpp \
    7   coins.cpp \
    8   compressor.cpp \
    9   consensus/merkle.cpp \
   10@@ -895,11 +894,9 @@ libbitcoinkernel_la_SOURCES = \
   11   core_read.cpp \
   12   dbwrapper.cpp \
   13   deploymentinfo.cpp \
   14-  deploymentstatus.cpp \
   15   flatfile.cpp \
   16   fs.cpp \
   17   hash.cpp \
   18-  kernel/chain.cpp \
   19   kernel/checks.cpp \
   20   kernel/coinstats.cpp \
   21   kernel/context.cpp \
   22@@ -932,7 +929,6 @@ libbitcoinkernel_la_SOURCES = \
   23   signet.cpp \
   24   support/cleanse.cpp \
   25   support/lockedpool.cpp \
   26-  sync.cpp \
   27   txdb.cpp \
   28   txmempool.cpp \
   29   uint256.cpp \
   

6. 
   fanquake commented at 9:23 am on October 31, 2022: member

   still works even with the following diff:

   • sync.cpp \

   That’s because you didn’t test with --enable-debug. Haven’t looked at the other suggestions.

7. 
   hebasto commented at 10:28 am on October 31, 2022: member

   That’s because you didn’t test with --enable-debug.

   Correct.

   Haven’t looked at the other suggestions.

   ./configure --with-experimental-kernel-lib --enable-experimental-util-chainstate --enable-debug && make still works with the following diff on Ubuntu 22.04:

    0--- a/src/Makefile.am
    1+++ b/src/Makefile.am
    2@@ -886,7 +886,6 @@ libbitcoinkernel_la_SOURCES = \
    3   chain.cpp \
    4   chainparamsbase.cpp \
    5   chainparams.cpp \
    6-  clientversion.cpp \
    7   coins.cpp \
    8   compressor.cpp \
    9   consensus/merkle.cpp \
   10@@ -895,11 +894,9 @@ libbitcoinkernel_la_SOURCES = \
   11   core_read.cpp \
   12   dbwrapper.cpp \
   13   deploymentinfo.cpp \
   14-  deploymentstatus.cpp \
   15   flatfile.cpp \
   16   fs.cpp \
   17   hash.cpp \
   18-  kernel/chain.cpp \
   19   kernel/checks.cpp \
   20   kernel/coinstats.cpp \
   21   kernel/context.cpp \
   

8. 
   theuni commented at 4:09 pm on October 31, 2022: member

   Concept ACK.

   FWIW, I anticipate threadinterrupt coming back to the kernel eventually as I think we’ll want to use it to get rid of shutdown.cpp.

   I think it’s fine to re-add it when it’s actually needed though.

9. 
   fanquake commented at 4:11 pm on October 31, 2022: member

   still works with the following diff

   • deploymentstatus.cpp \

   If “works” means compiles, then sure, however this also drops the compile-time deployment status sanity checks from the kernel build.

10. ryanofsky approved
11. 
    ryanofsky commented at 5:41 pm on October 31, 2022: contributor

    Code review ACK afbcd227dd0889002eeeec6148538ed2e2c9aadb
12. fanquake merged this on Nov 1, 2022
13. fanquake closed this on Nov 1, 2022

    ---

14. fanquake deleted the branch on Nov 1, 2022
15. sidhujag referenced this in commit b6455439bc on Nov 1, 2022
16. bitcoin locked this on Nov 1, 2023

Contributors
fanquake hebasto theuni ryanofsky

Labels
Build system