test-only refactor to drop the deprecated GetTime in favour of the type-safe alternative
test: Use type-safe NodeSeconds for TestMemPoolEntryHelper #26376
pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2210-time-🏾 changing 5 files +38 −39-
maflcko commented at 9:37 AM on October 24, 2022: member
-
test: Use type-safe NodeSeconds for TestMemPoolEntryHelper fa2d01470a
- fanquake added the label Tests on Oct 24, 2022
-
DrahtBot commented at 10:26 AM on October 24, 2022: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK aureleoules Concept ACK fanquake <!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #26289 (Use util::Result in for calculating mempool ancestors by stickies-v)
- #13990 (Allow fee estimation to work with lower fees by ajtowns)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
fanquake commented at 8:29 AM on October 31, 2022: member
Concept ACK
- aureleoules approved
-
aureleoules commented at 5:19 PM on November 21, 2022: member
ACK fa2d01470a9f1a91f35ed8013635ac47dabd868b - verified that there is no behavior change
- fanquake merged this on Nov 22, 2022
- fanquake closed this on Nov 22, 2022
- maflcko deleted the branch on Nov 22, 2022
- sidhujag referenced this in commit c0100fdbb4 on Nov 22, 2022
- bitcoin locked this on Nov 22, 2023
Contributors
Labels