p2p: TryLowWorkHeadersSync follow-ups #26387

1. 
   dergoegge commented at 10:41 am on October 25, 2022: member

   See #26355 (review) and #26355 (review)
2. [net processing] Fixup TryLowWorkHeadersSync comment e891aabf5a
3. fanquake added the label Docs on Oct 25, 2022
4. 
   mzumsande commented at 2:13 pm on October 25, 2022: contributor

   utACK e891aabf5a4992a65b9c5ae8606f8dd08515b310
5. 
   maflcko commented at 3:14 pm on October 25, 2022: member

   Maybe also address #26355 (review) ?
6. [net processing] Simplify use of IsContinuationOfLowWorkHeadersSync in TryLowWorkHeaderSync

   `m_headers_sync` is already reset in IsContinuationOfLowWorkHeadersSync
   if there is a failure, so there is no need to also reset in
   TryLowWorkHeaderSync.

   784b023191
7. dergoegge renamed this:
   doc: Fixup TryLowWorkHeadersSync comment (#26355 follow-up)
   p2p: #26355 follow-ups
   on Oct 26, 2022
8. 
   dergoegge commented at 10:16 am on October 26, 2022: member

   Maybe also address #26355 (review) ?

   Added a commit for that comment.

9. hernanmarino approved
10. 
    hernanmarino commented at 10:59 am on October 27, 2022: contributor

    ACK 784b02319128988038d4bd82f05736be22f14ee9
11. brunoerg approved
12. 
    brunoerg commented at 12:06 pm on October 27, 2022: contributor

    crACK 784b02319128988038d4bd82f05736be22f14ee9
13. maflcko renamed this:
    p2p: #26355 follow-ups
    p2p: TryLowWorkHeadersSync follow-ups
    on Oct 28, 2022
14. maflcko removed the label Docs on Oct 28, 2022
15. DrahtBot added the label P2P on Oct 28, 2022
16. fanquake requested review from mzumsande on Oct 28, 2022
17. 
    mzumsande commented at 3:24 pm on October 31, 2022: contributor

    ACK 784b02319128988038d4bd82f05736be22f14ee9

    I checked that IsContinuationOfLowWorkHeadersSync calls ProcessNextHeaders, which sets the state to FINAL if unsuccessful, resulting in IsContinuationOfLowWorkHeadersSync doing the cleanup of m_headers_sync and m_headers_presync_stats, so it is correct to remove the same cleanup in TryLowWorkHeadersSync.

18. fanquake referenced this in commit 43e813cab2 on Oct 31, 2022
19. 
    fanquake commented at 3:38 pm on October 31, 2022: member

    This has been merged.
20. fanquake closed this on Oct 31, 2022

    ---

21. sidhujag referenced this in commit 57f8033b7c on Oct 31, 2022
22. bitcoin locked this on Oct 31, 2023

Contributors
dergoegge mzumsande maflcko hernanmarino brunoerg fanquake

Labels
P2P