build: Drop unneeded linking of `contrib/devtools/` scripts #26446

pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:221103-checks changing 3 files +2 −6

hebasto commented at 11:53 AM on November 3, 2022: member

The build system targets make test-security-check, make -C src check-security and make -C src check-symbols run contrib/devtools/{test-,}{security,symbol}-check.py scripts from the top source directory, i.e. $(top_srcdir) in the current Autotools-based build system.

This renders needless of linking of those scripts into the build directory.

Both build systems, the current Autotools-based and the future CMake-based, benefit from this simplification.

script: Improve `test-{security,symbol}-check.py` robustness

This change allows to use the `test-{security,symbol}-check.py` scripts
when building out of source tree with no need to link scripts into the
build directory.

77779c3717

build: Drop unneeded linking of `contrib/devtools/` scripts

Th build system targets run those scripts from the top source directory.

29ef26ae25

DrahtBot added the label Build system on Nov 3, 2022
maflcko added the label DrahtBot Guix build requested on Nov 18, 2022

DrahtBot commented at 5:29 AM on November 19, 2022: contributor

Guix builds

File	commit aeb395dcdbfe2b1a6c77ff218939a18afde3add9<br>(master)	commit 98fad23496810d69822f3da802181d505dfc1a23<br>(master and this pull)
SHA256SUMS.part	`eb21d80a76e3145c...`	`aeece2893fc84022...`
*-aarch64-linux-gnu-debug.tar.gz	`05d83792732917d5...`	`55355cd8ae737567...`
*-aarch64-linux-gnu.tar.gz	`78b8d43bc911ae38...`	`e863718f057e6664...`
*-arm-linux-gnueabihf-debug.tar.gz	`ed66c17067167244...`	`a3aaf8ef793095e9...`
*-arm-linux-gnueabihf.tar.gz	`46a0405cb836179d...`	`84f858289f7ee778...`
*-arm64-apple-darwin-unsigned.dmg	`f4c9527faffba802...`	`db9c77509a0ef3fd...`
*-arm64-apple-darwin-unsigned.tar.gz	`0f79bcd0578e7d32...`	`aeca77f552a27fb6...`
*-arm64-apple-darwin.tar.gz	`e5114ffa50d797f7...`	`9b868ef5fa0b002a...`
*-powerpc64-linux-gnu-debug.tar.gz	`ff1c923e0baf3e1a...`	`cb4d200ffe677d28...`
*-powerpc64-linux-gnu.tar.gz	`ae0d40502a2df634...`	`0d243d1dcf2be202...`
*-powerpc64le-linux-gnu-debug.tar.gz	`1503bc66f1d0a1a4...`	`1899057d9cf4b487...`
*-powerpc64le-linux-gnu.tar.gz	`c93acf1381091737...`	`e046aa58b517f621...`
*-riscv64-linux-gnu-debug.tar.gz	`2765289c4f3e2080...`	`5e8cde6292fcf48a...`
*-riscv64-linux-gnu.tar.gz	`615cd2f80236e9be...`	`40cdcc179f1f3ca8...`
*-win64-debug.zip	`fd063653a8ee20c7...`	`0d1d8a738eb20058...`
*-win64-setup-unsigned.exe	`f0dc655fd3c33b7d...`	`81e60301eec79c59...`
*-win64-unsigned.tar.gz	`2ec15dab9c8b3d41...`	`8d393b596d84ea78...`
*-win64.zip	`451a6cd99fe477e4...`	`f7b38ddb57b66988...`
*-x86_64-apple-darwin-unsigned.dmg	`aefe6838bfad36f5...`	`4337429385811f97...`
*-x86_64-apple-darwin-unsigned.tar.gz	`3bc0c525799af7f3...`	`0ea0ca9a904635f1...`
*-x86_64-apple-darwin.tar.gz	`4d1441725ce24f98...`	`74dbc95c1e9cfb12...`
*-x86_64-linux-gnu-debug.tar.gz	`efacd71ff97c206f...`	`c1bb84211e69d568...`
*-x86_64-linux-gnu.tar.gz	`42daecbed5b41a2d...`	`0da98277a6f5a763...`
*.tar.gz	`054d63d339a5d15b...`	`64d72e00a56eb202...`
guix_build.log	`e1dbeb259475716e...`	`ad4c8e2538291a5f...`
guix_build.log.diff		`f061affc630b2a1f...`

DrahtBot removed the label DrahtBot Guix build requested on Nov 19, 2022

jarolrod commented at 9:40 PM on November 20, 2022: member

guix hashes

x86:

e6b8ce4396c364cb65533d394fd0bfcfda7b7015493c939387b0585f77a8ad16  guix-build-29ef26ae25e5/output/aarch64-linux-gnu/SHA256SUMS.part
87b55956d2515566005b2a7a49d9084050da43b688790be784cc464cb5a113f8  guix-build-29ef26ae25e5/output/aarch64-linux-gnu/bitcoin-29ef26ae25e5-aarch64-linux-gnu-debug.tar.gz
34c88fe485d272ba05f920692cc4bf9d61fd6edc690a3288b5da21f2950014eb  guix-build-29ef26ae25e5/output/aarch64-linux-gnu/bitcoin-29ef26ae25e5-aarch64-linux-gnu.tar.gz
62fdd6214325abd42b39038c328eb6d50e1b600111dc1b78f51fe3ce9c49293b  guix-build-29ef26ae25e5/output/arm-linux-gnueabihf/SHA256SUMS.part
020144b2bb3651ff14f6abfe91a4fa64bef561e74e9453fa84f7e2bc8b5146dd  guix-build-29ef26ae25e5/output/arm-linux-gnueabihf/bitcoin-29ef26ae25e5-arm-linux-gnueabihf-debug.tar.gz
1bc9f687d862a388632228779f2cb6f9d864b44f3e78474efe85bf9e3cf8b74a  guix-build-29ef26ae25e5/output/arm-linux-gnueabihf/bitcoin-29ef26ae25e5-arm-linux-gnueabihf.tar.gz
5c689899f36e8c34d1e3ac7d3494735d7a0f2aae14c8223b0b2b6b5953f6282f  guix-build-29ef26ae25e5/output/arm64-apple-darwin/SHA256SUMS.part
19c4b04489a7f0b8ea21054b0a1a6a0cc4bc9d2dc63b37c34317d432e5d98c53  guix-build-29ef26ae25e5/output/arm64-apple-darwin/bitcoin-29ef26ae25e5-arm64-apple-darwin-unsigned.dmg
c3f4f15c814b3564296d1f4ddd6f1fb8e06e91c95cdeea28c4aae9a2132ddf84  guix-build-29ef26ae25e5/output/arm64-apple-darwin/bitcoin-29ef26ae25e5-arm64-apple-darwin-unsigned.tar.gz
ee8c6387928454c5ef2464bd998dd500beca9f5511ee5173fe7c556234fdd10c  guix-build-29ef26ae25e5/output/arm64-apple-darwin/bitcoin-29ef26ae25e5-arm64-apple-darwin.tar.gz
b0ab407a2e18bb984cba68d4499c4bb55e18f7ffc06d8b6ba8896611ee4ae9b2  guix-build-29ef26ae25e5/output/dist-archive/bitcoin-29ef26ae25e5.tar.gz
b399eb81b4c450d8ec3443e8ee507c7aa4ad5ed8c0062fb2ac8d841ab75e88db  guix-build-29ef26ae25e5/output/powerpc64-linux-gnu/SHA256SUMS.part
e67b5483cea10b644aebd52f93e740966da212f353eec56f5716d61cc122ed32  guix-build-29ef26ae25e5/output/powerpc64-linux-gnu/bitcoin-29ef26ae25e5-powerpc64-linux-gnu-debug.tar.gz
12e6b9a1077d3206dcf866d2987c74a9b4345eacb589304edacdfc347ce9128a  guix-build-29ef26ae25e5/output/powerpc64-linux-gnu/bitcoin-29ef26ae25e5-powerpc64-linux-gnu.tar.gz
059e8739b061c0e48c63098b98ff6fa2d0c511f21ee8f309db4235883e53ec99  guix-build-29ef26ae25e5/output/powerpc64le-linux-gnu/SHA256SUMS.part
40f7719d05b98cf4b67dc81b6b9c89c41249ff6109f6ccc139d4f8c9331df2ca  guix-build-29ef26ae25e5/output/powerpc64le-linux-gnu/bitcoin-29ef26ae25e5-powerpc64le-linux-gnu-debug.tar.gz
ec7b094fa1207542625b40d4792d0d9f3df92e6e99d90c32c7bacb0a287fbf90  guix-build-29ef26ae25e5/output/powerpc64le-linux-gnu/bitcoin-29ef26ae25e5-powerpc64le-linux-gnu.tar.gz
3433cc456ac9e10dc25f228343fa5f28fc9a1572a3af40f4a6f68ea5ba789fee  guix-build-29ef26ae25e5/output/riscv64-linux-gnu/SHA256SUMS.part
19bb14f15476dbc2bb45bf033397a28a780d414b273e1c4def584fd5bafd2855  guix-build-29ef26ae25e5/output/riscv64-linux-gnu/bitcoin-29ef26ae25e5-riscv64-linux-gnu-debug.tar.gz
ac05e08d225555bf5d6c0c812f641dca89325767578adb22d9087f59d3322c6f  guix-build-29ef26ae25e5/output/riscv64-linux-gnu/bitcoin-29ef26ae25e5-riscv64-linux-gnu.tar.gz
28c39b946b5835219a15a87d1e46a6094f2bee5fb7f2db6c12a89cb3ca0aa88f  guix-build-29ef26ae25e5/output/x86_64-apple-darwin/SHA256SUMS.part
e8e4ef48aebeec4454e955c6ed5d6c8a85d193b0743901843e0efbfdd9ecd29d  guix-build-29ef26ae25e5/output/x86_64-apple-darwin/bitcoin-29ef26ae25e5-x86_64-apple-darwin-unsigned.dmg
8efb68db97a207ae6960295596d2efd1411d012f6998ac4db98076569dbce054  guix-build-29ef26ae25e5/output/x86_64-apple-darwin/bitcoin-29ef26ae25e5-x86_64-apple-darwin-unsigned.tar.gz
5382bcc37d31b530026d0f4bbdb7f867ac6a737777d227fb878013464d6cce7c  guix-build-29ef26ae25e5/output/x86_64-apple-darwin/bitcoin-29ef26ae25e5-x86_64-apple-darwin.tar.gz
72c7172094610620408c1c5d80f3e379da0a7edacd234de6724eda0f3e4c3102  guix-build-29ef26ae25e5/output/x86_64-linux-gnu/SHA256SUMS.part
6cc7ad01a7e5785a24bb7f824512ed68c06d1494e5499a8189c55c257c7f0b0a  guix-build-29ef26ae25e5/output/x86_64-linux-gnu/bitcoin-29ef26ae25e5-x86_64-linux-gnu-debug.tar.gz
76b5dc3ab0c4370d6fe492a34f7783dcf40506e6d8c896843c1c34424bc65ec6  guix-build-29ef26ae25e5/output/x86_64-linux-gnu/bitcoin-29ef26ae25e5-x86_64-linux-gnu.tar.gz
3bf191a13032a8a4bbd1ff5b1aec855d6a111c7fcdaa07846ddfa1ec22174902  guix-build-29ef26ae25e5/output/x86_64-w64-mingw32/SHA256SUMS.part
8d2219dcda86e4c33956b9c5f41bb3af4991db8476c1385702f03499d7661ac7  guix-build-29ef26ae25e5/output/x86_64-w64-mingw32/bitcoin-29ef26ae25e5-win64-debug.zip
dcef7d1d3a80ac886f62ed1152e03b181241110d9627ef7b4303e831030198d6  guix-build-29ef26ae25e5/output/x86_64-w64-mingw32/bitcoin-29ef26ae25e5-win64-setup-unsigned.exe
a005564371c0f722d1d2687bba2e3e66cbca79da532e7ab1b88da6449c3cdf10  guix-build-29ef26ae25e5/output/x86_64-w64-mingw32/bitcoin-29ef26ae25e5-win64-unsigned.tar.gz
5fb6d4747c3a90424186b9d375a040b03fbb69bd81c52b926cd0063d313983a5  guix-build-29ef26ae25e5/output/x86_64-w64-mingw32/bitcoin-29ef26ae25e5-win64.zip

arm64:

e6b8ce4396c364cb65533d394fd0bfcfda7b7015493c939387b0585f77a8ad16  guix-build-29ef26ae25e5/output/aarch64-linux-gnu/SHA256SUMS.part
87b55956d2515566005b2a7a49d9084050da43b688790be784cc464cb5a113f8  guix-build-29ef26ae25e5/output/aarch64-linux-gnu/bitcoin-29ef26ae25e5-aarch64-linux-gnu-debug.tar.gz
34c88fe485d272ba05f920692cc4bf9d61fd6edc690a3288b5da21f2950014eb  guix-build-29ef26ae25e5/output/aarch64-linux-gnu/bitcoin-29ef26ae25e5-aarch64-linux-gnu.tar.gz
62fdd6214325abd42b39038c328eb6d50e1b600111dc1b78f51fe3ce9c49293b  guix-build-29ef26ae25e5/output/arm-linux-gnueabihf/SHA256SUMS.part
020144b2bb3651ff14f6abfe91a4fa64bef561e74e9453fa84f7e2bc8b5146dd  guix-build-29ef26ae25e5/output/arm-linux-gnueabihf/bitcoin-29ef26ae25e5-arm-linux-gnueabihf-debug.tar.gz
1bc9f687d862a388632228779f2cb6f9d864b44f3e78474efe85bf9e3cf8b74a  guix-build-29ef26ae25e5/output/arm-linux-gnueabihf/bitcoin-29ef26ae25e5-arm-linux-gnueabihf.tar.gz
5c689899f36e8c34d1e3ac7d3494735d7a0f2aae14c8223b0b2b6b5953f6282f  guix-build-29ef26ae25e5/output/arm64-apple-darwin/SHA256SUMS.part
19c4b04489a7f0b8ea21054b0a1a6a0cc4bc9d2dc63b37c34317d432e5d98c53  guix-build-29ef26ae25e5/output/arm64-apple-darwin/bitcoin-29ef26ae25e5-arm64-apple-darwin-unsigned.dmg
c3f4f15c814b3564296d1f4ddd6f1fb8e06e91c95cdeea28c4aae9a2132ddf84  guix-build-29ef26ae25e5/output/arm64-apple-darwin/bitcoin-29ef26ae25e5-arm64-apple-darwin-unsigned.tar.gz
ee8c6387928454c5ef2464bd998dd500beca9f5511ee5173fe7c556234fdd10c  guix-build-29ef26ae25e5/output/arm64-apple-darwin/bitcoin-29ef26ae25e5-arm64-apple-darwin.tar.gz
b0ab407a2e18bb984cba68d4499c4bb55e18f7ffc06d8b6ba8896611ee4ae9b2  guix-build-29ef26ae25e5/output/dist-archive/bitcoin-29ef26ae25e5.tar.gz
b399eb81b4c450d8ec3443e8ee507c7aa4ad5ed8c0062fb2ac8d841ab75e88db  guix-build-29ef26ae25e5/output/powerpc64-linux-gnu/SHA256SUMS.part
e67b5483cea10b644aebd52f93e740966da212f353eec56f5716d61cc122ed32  guix-build-29ef26ae25e5/output/powerpc64-linux-gnu/bitcoin-29ef26ae25e5-powerpc64-linux-gnu-debug.tar.gz
12e6b9a1077d3206dcf866d2987c74a9b4345eacb589304edacdfc347ce9128a  guix-build-29ef26ae25e5/output/powerpc64-linux-gnu/bitcoin-29ef26ae25e5-powerpc64-linux-gnu.tar.gz
059e8739b061c0e48c63098b98ff6fa2d0c511f21ee8f309db4235883e53ec99  guix-build-29ef26ae25e5/output/powerpc64le-linux-gnu/SHA256SUMS.part
40f7719d05b98cf4b67dc81b6b9c89c41249ff6109f6ccc139d4f8c9331df2ca  guix-build-29ef26ae25e5/output/powerpc64le-linux-gnu/bitcoin-29ef26ae25e5-powerpc64le-linux-gnu-debug.tar.gz
ec7b094fa1207542625b40d4792d0d9f3df92e6e99d90c32c7bacb0a287fbf90  guix-build-29ef26ae25e5/output/powerpc64le-linux-gnu/bitcoin-29ef26ae25e5-powerpc64le-linux-gnu.tar.gz
3433cc456ac9e10dc25f228343fa5f28fc9a1572a3af40f4a6f68ea5ba789fee  guix-build-29ef26ae25e5/output/riscv64-linux-gnu/SHA256SUMS.part
19bb14f15476dbc2bb45bf033397a28a780d414b273e1c4def584fd5bafd2855  guix-build-29ef26ae25e5/output/riscv64-linux-gnu/bitcoin-29ef26ae25e5-riscv64-linux-gnu-debug.tar.gz
ac05e08d225555bf5d6c0c812f641dca89325767578adb22d9087f59d3322c6f  guix-build-29ef26ae25e5/output/riscv64-linux-gnu/bitcoin-29ef26ae25e5-riscv64-linux-gnu.tar.gz
28c39b946b5835219a15a87d1e46a6094f2bee5fb7f2db6c12a89cb3ca0aa88f  guix-build-29ef26ae25e5/output/x86_64-apple-darwin/SHA256SUMS.part
e8e4ef48aebeec4454e955c6ed5d6c8a85d193b0743901843e0efbfdd9ecd29d  guix-build-29ef26ae25e5/output/x86_64-apple-darwin/bitcoin-29ef26ae25e5-x86_64-apple-darwin-unsigned.dmg
8efb68db97a207ae6960295596d2efd1411d012f6998ac4db98076569dbce054  guix-build-29ef26ae25e5/output/x86_64-apple-darwin/bitcoin-29ef26ae25e5-x86_64-apple-darwin-unsigned.tar.gz
5382bcc37d31b530026d0f4bbdb7f867ac6a737777d227fb878013464d6cce7c  guix-build-29ef26ae25e5/output/x86_64-apple-darwin/bitcoin-29ef26ae25e5-x86_64-apple-darwin.tar.gz
72c7172094610620408c1c5d80f3e379da0a7edacd234de6724eda0f3e4c3102  guix-build-29ef26ae25e5/output/x86_64-linux-gnu/SHA256SUMS.part
6cc7ad01a7e5785a24bb7f824512ed68c06d1494e5499a8189c55c257c7f0b0a  guix-build-29ef26ae25e5/output/x86_64-linux-gnu/bitcoin-29ef26ae25e5-x86_64-linux-gnu-debug.tar.gz
76b5dc3ab0c4370d6fe492a34f7783dcf40506e6d8c896843c1c34424bc65ec6  guix-build-29ef26ae25e5/output/x86_64-linux-gnu/bitcoin-29ef26ae25e5-x86_64-linux-gnu.tar.gz
3bf191a13032a8a4bbd1ff5b1aec855d6a111c7fcdaa07846ddfa1ec22174902  guix-build-29ef26ae25e5/output/x86_64-w64-mingw32/SHA256SUMS.part
8d2219dcda86e4c33956b9c5f41bb3af4991db8476c1385702f03499d7661ac7  guix-build-29ef26ae25e5/output/x86_64-w64-mingw32/bitcoin-29ef26ae25e5-win64-debug.zip
dcef7d1d3a80ac886f62ed1152e03b181241110d9627ef7b4303e831030198d6  guix-build-29ef26ae25e5/output/x86_64-w64-mingw32/bitcoin-29ef26ae25e5-win64-setup-unsigned.exe
a005564371c0f722d1d2687bba2e3e66cbca79da532e7ab1b88da6449c3cdf10  guix-build-29ef26ae25e5/output/x86_64-w64-mingw32/bitcoin-29ef26ae25e5-win64-unsigned.tar.gz
5fb6d4747c3a90424186b9d375a040b03fbb69bd81c52b926cd0063d313983a5  guix-build-29ef26ae25e5/output/x86_64-w64-mingw32/bitcoin-29ef26ae25e5-win64.zip

DrahtBot commented at 9:40 PM on November 20, 2022: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK fanquake
fanquake approved
fanquake commented at 5:31 PM on November 25, 2022: member

ACK 29ef26ae25e55a198a3b8bb7a040c073cb0878da
fanquake merged this on Nov 25, 2022
fanquake closed this on Nov 25, 2022
sidhujag referenced this in commit b41ccc154b on Nov 25, 2022
hebasto deleted the branch on Nov 25, 2022
bitcoin deleted a comment on Nov 26, 2022
bitcoin locked this on Jun 10, 2024

Type	Reviewers
ACK	fanquake

Contributors

Labels

build: Drop unneeded linking of `contrib/devtools/` scripts #26446

Guix builds

Reviews