new resources for linux software package managers #2650

jonasschnelli commented at 7:42 AM on May 13, 2013: contributor

Package managers like Matt Caraldo (https://launchpad.net/~bitcoin/+archive/bitcoin) should now include the new png icons in their bitcoin linux .deb files. The current xpm file bitcoin80.xpm (80x80px) was deleted because it contains a non-stamdard size. I've testes with png files and did figure out the png files as icons will resize proper while xpm files will end up in non-resizing menu items which then can result in gfx bugs like reported with #2543. I recommend to use png files as pixmaps in upcoming linux software packages.

new xpm resources for different linux window managers
new png files for autoresizing on different linux window managers
favicon with new logo
window .ico with new logo

BitcoinPullTester commented at 8:20 AM on May 13, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/9687ba335b397688aa0445da63a5401c3676b576 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

TheBlueMatt commented at 11:02 AM on May 13, 2013: member

If you want the debian packages to be updated to include new images (I dont really care), please also update the debian package scripts in contrib/debian (and probable email the debian maintainers afterwards to notify them that stuff should be changed, since they decided to use their own package scripts)

jonasschnelli commented at 12:58 PM on May 13, 2013: contributor

@TheBlueMatt Okay. Did change the script. I assume for the upcoming 0.8.2 release you will do the PPA lanuchpad package?

TheBlueMatt commented at 2:11 PM on May 13, 2013: member

Please also update the changelog...and yes, Ill upload the debian stuff to launchpad when 0.8.2 is tagged.

jonasschnelli commented at 2:17 PM on May 13, 2013: contributor

@TheBlueMatt i have no deb experience. Hopefully the changelog is right now...

BitcoinPullTester commented at 2:53 PM on May 13, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/b5c62ca0b2c448658599b56363194392bbdde275 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

in contrib/debian/changelog:None in b5c62ca0b2 outdated

   0 | @@ -1,3 +1,9 @@
   1 | +bitcoin (0.8.1-natty3) natty; urgency=low
   2 | +
   3 | +  * New pixmaps
   4 | +
   5 | + -- Jonas Schnelli <jonas.schnelli@include7.ch>  Mo, 13 May 2013 16:14:00 +0100

TheBlueMatt commented at 6:06 PM on May 13, 2013:

I assume thats a Mon, not Mo

TheBlueMatt commented at 6:06 PM on May 13, 2013: member

Aside from the above, ACK Oh, and please squash commits.

new icons for linux, etc.

- new xpm resources for different linux window managers
- new png files for autoresizing on different linux window managers
- favicon with new logo
- window .ico with new logo
- updated debian package script
- updated changelog

d0d4080013

jonasschnelli commented at 6:20 PM on May 13, 2013: contributor

@TheBlueMatt okay. Changed ("Mo" => "Mon") and squashed.

TheBlueMatt commented at 6:41 PM on May 13, 2013: member

ACK

BitcoinPullTester commented at 6:45 PM on May 13, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/d0d4080013d507aed625043dd9b422623aab015d for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

laanwj referenced this in commit f7f940336e on May 19, 2013

laanwj merged this on May 19, 2013

laanwj closed this on May 19, 2013

gavinandresen commented at 4:10 PM on May 24, 2013: contributor

I need help; the new icons break the win32 gitian build.

The problem:

Now, every time I run the NSIS installer to create the windows -setup.exe file, the sha checksum on the .exe is different. I haven't been able to figure out why.

I am guessing it is the bitcoin.ico file that is the problem, because that is the only file referred to by the .nsi script. Did the resolution or color depth or something change? Maybe NSIS is rescaling the image and using a randomized dithering algorithm or something ????

jonasschnelli commented at 4:16 PM on May 24, 2013: contributor

@gavinandresen Hmm.. the .ico file has changed and yes, I think there are different resolutions which the nsi script might can't handle. I will check it in the next hours and give you a feedback.

gavinandresen commented at 4:29 PM on May 24, 2013: contributor

In case it helps, I tweaked the installer to do file-by-file zlib compression (instead of compressing the whole thing) and there is a 4-byte difference: http://imgur.com/oOljdIV

(and another 4-byte difference at the very end of the file, which I think is a CRC checksum)

sipa commented at 5:01 PM on May 24, 2013: member

Just the fact that the file has changed is not a problem: it doesn't explain why nsis deals with it in an indeterministic way. I checked nsis's source, and there are no rand() or random() calls except in their unit tests. Perhaps it's related to the order in which files are returned by readdir() or something like that?

jonasschnelli commented at 5:03 PM on May 24, 2013: contributor

you could also try to replace the .ico file with the old one and try again. Just to make sure it's the .ico file... or something else like @sipa's idea with the readdir order.

gavinandresen commented at 5:20 PM on May 24, 2013: contributor

Replaced it with the old .ico, and makensis results are predictable again.

Shouldn't be readdir() order, I'm logged into my gitian VM and re-running the makensis command on exactly the same filesystem (not moving files around or anything).

ALSO: FAKETIME is set, so any call to time() in makensis (I don't see any) shouldn't matter.

PS: using version MakeNSIS v2.46-1 (subversion version 6009 I believe).

jonasschnelli commented at 6:35 PM on May 24, 2013: contributor

I just re-created the .icon file. It was lacking of 3 resolutions. 20x20, 64x64 and a 32x32 256 color. The problem maybe is, that the required resolution was always generated (with somehow random elements).

You might try again with the .ICO file: https://github.com/jonasschnelli/bitcoin/blob/fa56a28887de353d8692628d8c240d17d9b38523/share/pixmaps/bitcoin.ico

gavinandresen commented at 7:37 PM on May 24, 2013: contributor

All-resolution .ico seems to fix the problem. Go figure.

jonasschnelli commented at 7:39 PM on May 24, 2013: contributor

Need another pull request with the new .ICO?

gavinandresen commented at 7:45 PM on May 24, 2013: contributor

I can just push the new pixmap.

Is src/qt/res/icons/bitcoin.ico used any more ?

jonasschnelli commented at 7:49 PM on May 24, 2013: contributor

I'm not sure which ico file is used for Win builds. src/qt/res/icons/bitcoin.ico was there when i started redesigning.

laanwj commented at 8:14 AM on May 25, 2013: member

The icons in src/qt/res/icons are used during build of the executable itself.

jonasschnelli commented at 11:01 AM on May 25, 2013: contributor

Can we not use the share/pixmaps/bitcoin.ico for the executable build and remove the src/qt/res/icons/bitcoin.ico?

laanwj commented at 3:47 PM on May 25, 2013: member

I guess so. You'd also have to move the testnet icon there, and change the following file: https://github.com/bitcoin/bitcoin/blob/master/src/qt/res/bitcoin-qt.rc#L1

laudney referenced this in commit ad4fa66899 on Mar 19, 2014

DrahtBot locked this on Sep 8, 2021