There is no need to assign self.next_block to variables if we're not using its return value. Most cases touched here, we're reassigning it right after with the value from self.update_block.
test: remove unused vars in `feature_block` #26507
pull brunoerg wants to merge 1 commits into bitcoin:master from brunoerg:2022-11-unused-feature-block-test changing 1 files +25 −25-
brunoerg commented at 4:55 PM on November 15, 2022: contributor
- fanquake added the label Tests on Nov 15, 2022
-
test: remove unused vars in `feature_block` 741c215b5f
- brunoerg force-pushed on Nov 17, 2022
-
DrahtBot commented at 1:37 PM on November 17, 2022: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers Concept ACK fanquake If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
-
aureleoules commented at 6:21 PM on December 1, 2022: member
For reference, @fanquake suggested tweaking vulture to detect these unused variables. I couldn't make it work though. #25707 (review)
-
fanquake commented at 10:32 AM on February 8, 2023: member
ACK. Seems fine. @MarcoFalke any thoughts? Otherwise we should probably just close.
- maflcko merged this on Feb 8, 2023
- maflcko closed this on Feb 8, 2023
- sidhujag referenced this in commit 4a9ab3a707 on Feb 8, 2023
- bitcoin locked this on Feb 8, 2024
Contributors
Labels