[22.x] GUI backports #26521

1. 
   hebasto commented at 2:38 PM on November 17, 2022: member

   Backports:

   • bitcoin-core/gui#631
   • bitcoin-core/gui#680
2. hebasto added the label Backport on Nov 17, 2022
3. hebasto added this to the milestone 22.1 on Nov 17, 2022
4. 
   DrahtBot commented at 2:38 PM on November 17, 2022: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	jarolrod

5. 
   fanquake commented at 4:29 PM on November 17, 2022: member

   Is there a reason this doesn't include https://github.com/bitcoin-core/gui/pull/631, or is that no-longer being backported to 22.x? If so, can you remove the label.

6. maflcko removed the label Backport on Nov 17, 2022
7. DrahtBot added the label Backport on Nov 17, 2022
8. maflcko removed the label Backport on Nov 18, 2022
9. DrahtBot added the label Backport on Nov 18, 2022
10. Disallow encryption of watchonly wallets

    Watchonly wallets do not have any private keys to encrypt. It does not
    make sense to encrypt such wallets, so disable the option to encrypt
    them.
    
    This avoids an assertion that can be hit when encrypting watchonly descriptor
    wallets.
    
    Github-Pull: bitcoin-core/gui#631
    Rebased-From: 4c495413e138ec1dd6874e41b44e689f0c15e0e3

    7b7bbc145a
11. Fixes bitcoin#26490 by preventing notifications

    MacOS 13 sends a window focus change notification after the main
    window has been destroyed but before the QTApplication has been
    destroyed. This results in the menu bar receiving a notification
    despite it no longer existing. The solution is to pass the main
    window as context when subscribing to the notifications. Qt
    automatically unsubscribes to notifications if the sender OR
    context is destroyed.
    
    Github-Pull: bitcoin-core/gui#680
    Rebased-From: 8a5014cd8a05b3ab86ae34a47653a82ce11bdf17

    272fa25304
12. hebasto force-pushed on Nov 21, 2022
13. 
    hebasto commented at 10:48 AM on November 21, 2022: member

    @fanquake

    Is there a reason this doesn't include bitcoin-core/gui#631, or is that no-longer being backported to 22.x? If so, can you remove the label.

    Thank you for a reminder! Updated.

14. fanquake requested review from jarolrod on Nov 21, 2022
15. fanquake requested review from achow101 on Nov 21, 2022
16. jarolrod approved
17. 
    jarolrod commented at 2:43 AM on November 22, 2022: member

    ACK 272fa2530493b13e4bf7c978e9768162f10ddf7f

    Performed my own backport of the two pr's and confirmed that backporting each commit has no conflicts and that I have a zero-diff with this PR. Tested the functionality of 7b7bbc145aedf149c6d8675c7e252b0767bb8652, but only a code-review ack for 272fa2530493b13e4bf7c978e9768162f10ddf7f as I do not have an intel mac to test on right now.

18. fanquake merged this on Nov 22, 2022
19. fanquake closed this on Nov 22, 2022

    ---

20. hebasto deleted the branch on Nov 22, 2022
21. bitcoin locked this on Nov 22, 2023

Review Requested
achow101

Milestone
22.1