contrib/builder-keys/keys.txt: remove unavailable key #26565

pull RandyMcMillan wants to merge 1 commits into bitcoin:master from RandyMcMillan:1669256933/85892f77c9/38d06e1561-builder-keys changing 1 files +0 −1
  1. RandyMcMillan commented at 2:33 am on November 24, 2022: contributor
  2. contrib/builder-keys/keys.txt: remove unavailable key
    remove unavailable builder-key:
    A2FD494D0021AA9B4FA58F759102B7AE654A4A5A Ilyas Ridhuan (IlyasRidhuan)
    dddfa028ff
  3. DrahtBot commented at 2:33 am on November 24, 2022: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK fanquake

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. RandyMcMillan commented at 4:05 am on November 24, 2022: contributor

    synced all other keys with

    hkp://keys.openpgp.org, hkp://keyserver.ubuntu.com, hkp://pgp.mit.edu

    to ensure redundancy:

    https://raw.githubusercontent.com/RandyMcMillan/bitcoin/2e7e4ec93b85c54e55fc0cf053bb57c8da079d08/builder-key-sync.log

  5. maflcko commented at 7:26 am on November 24, 2022: member
    I think we can remove all keys that were used for gitian builds only and never for a guix build
  6. RandyMcMillan commented at 7:44 am on November 24, 2022: contributor
    additionally - we can setup a ci script that detects when this file changes (PR) and checks that the keys are on public key servers?
  7. maflcko commented at 7:55 am on November 24, 2022: member
    I think it only changes rarely, and if it changes, people will check that the key is available. See also https://github.com/bitcoin-core/guix.sigs/issues/133
  8. RandyMcMillan commented at 3:07 pm on November 24, 2022: contributor

    I think we can remove all keys that were used for gitian builds only and never for a guix build

    I will cross reference the https://github.com/bitcoin-core/guix.sigs repo - and list any unused keys from the contrib/builder-keys/keys.txt in this PR for discussion and/or removal.

  9. glozow requested review from fanquake on Nov 29, 2022
  10. fanquake approved
  11. fanquake commented at 12:11 pm on November 29, 2022: member

    ACK dddfa028ffa6b6d70e4fae761ecb9477877d8ec2

    I think we can remove all keys that were used for gitian builds only and never for a guix build

    I’ll follow up with this.

  12. fanquake merged this on Nov 29, 2022
  13. fanquake closed this on Nov 29, 2022

  14. sidhujag referenced this in commit 70637ce581 on Dec 1, 2022
  15. maflcko referenced this in commit 296e882250 on Jan 5, 2023
  16. bitcoin locked this on Nov 29, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-09-29 01:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me