No description provided.
contrib/builder-keys/keys.txt: remove unavailable key #26565
pull RandyMcMillan wants to merge 1 commits into bitcoin:master from RandyMcMillan:1669256933/85892f77c9/38d06e1561-builder-keys changing 1 files +0 −1-
RandyMcMillan commented at 2:33 AM on November 24, 2022: contributor
-
dddfa028ff
contrib/builder-keys/keys.txt: remove unavailable key
remove unavailable builder-key: A2FD494D0021AA9B4FA58F759102B7AE654A4A5A Ilyas Ridhuan (IlyasRidhuan)
-
DrahtBot commented at 2:33 AM on November 24, 2022: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK fanquake If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
-
RandyMcMillan commented at 4:05 AM on November 24, 2022: contributor
synced all other keys with
hkp://keys.openpgp.org, hkp://keyserver.ubuntu.com, hkp://pgp.mit.edu
to ensure redundancy:
-
maflcko commented at 7:26 AM on November 24, 2022: member
I think we can remove all keys that were used for gitian builds only and never for a guix build
-
RandyMcMillan commented at 7:44 AM on November 24, 2022: contributor
additionally - we can setup a ci script that detects when this file changes (PR) and checks that the keys are on public key servers?
-
maflcko commented at 7:55 AM on November 24, 2022: member
I think it only changes rarely, and if it changes, people will check that the key is available. See also https://github.com/bitcoin-core/guix.sigs/issues/133
-
RandyMcMillan commented at 3:07 PM on November 24, 2022: contributor
I think we can remove all keys that were used for gitian builds only and never for a guix build
I will cross reference the https://github.com/bitcoin-core/guix.sigs repo - and list any unused keys from the contrib/builder-keys/keys.txt in this PR for discussion and/or removal.
- glozow requested review from fanquake on Nov 29, 2022
- fanquake approved
-
fanquake commented at 12:11 PM on November 29, 2022: member
ACK dddfa028ffa6b6d70e4fae761ecb9477877d8ec2
I think we can remove all keys that were used for gitian builds only and never for a guix build
I'll follow up with this.
- fanquake merged this on Nov 29, 2022
- fanquake closed this on Nov 29, 2022
- sidhujag referenced this in commit 70637ce581 on Dec 1, 2022
- maflcko referenced this in commit 296e882250 on Jan 5, 2023
- bitcoin locked this on Nov 29, 2023
Contributors