It's after 2013-05-15 forever now, so remove the code for the May 15 fork #2657

pull gmaxwell wants to merge 1 commits into bitcoin:master from gmaxwell:its_after_may15_forever changing 5 files +0 −190

gmaxwell commented at 8:36 PM on May 16, 2013: contributor

No description provided.
It's after 2013-05-15 forever now, so remove the code for the May 15 fork. a824121eb8
gmaxwell commented at 8:37 PM on May 16, 2013: contributor

I assume we'd pull this after 0.8.2.
BitcoinPullTester commented at 8:45 PM on May 16, 2013: none
Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/a824121eb8458350a2c4f7c64601a9d1b41425c9 for binaries and test log.

This could happen for one of several reasons:
1. It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts (please tweak those patches in contrib/test-scripts)
2. It adds/modifies tests which test network rules (thanks for doing that), which conflicts with a patch applied at test time
3. It does not build on either Linux i386 or Win32 (via MinGW cross compile)
4. The test suite fails on either Linux i386 or Win32
5. The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)
If you believe this to be in error, please ping BlueMatt on freenode or TheBlueMatt here.

This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
BitcoinPullTester commented at 9:24 PM on May 16, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/a824121eb8458350a2c4f7c64601a9d1b41425c9 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
TheBlueMatt commented at 9:42 PM on May 16, 2013: member

What? you couldn't just use the commits in those patches? ACK
sipa commented at 3:14 AM on May 30, 2013: member

ACK
laanwj commented at 7:11 AM on May 30, 2013: member

ACK
in src/test/checkblock_tests.cpp:None in a824121eb8
```
  51 | @@ -52,8 +52,6 @@
  52 |      if (read_block("Mar12Fork.dat", forkingBlock))
```
sipa commented at 8:18 AM on May 30, 2013:

It seems to me that this entire test case can be removed?
jgarzik referenced this in commit af93273799 on May 30, 2013
jgarzik merged this on May 30, 2013
jgarzik closed this on May 30, 2013
DrahtBot locked this on Sep 8, 2021

Contributors