util: Include full version id in bug reports #26645

1. 
   maflcko commented at 10:16 am on December 6, 2022: member

   This will show the unique id of the full source code when the bug occurred, which can help debugging
2. util: Include full version id in bug reports fa825bd227
3. 
   DrahtBot commented at 10:16 am on December 6, 2022: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	1440000bytes, theStack, john-moffett
   Concept ACK	hebasto, dergoegge

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot renamed this:
   util: Include full version id in bug reports
   util: Include full version id in bug reports
   on Dec 6, 2022
5. DrahtBot added the label Utils/log/libs on Dec 6, 2022
6. 
   maflcko commented at 10:18 am on December 6, 2022: member

   For example:

   0$ ./src/bitcoin-cli -named echo 'arg9=trigger_internal_bug'
   1error code: -1
   2error message:
   3Internal bug detected: "request.params[9].get_str() != "trigger_internal_bug""
   4rpc/node.cpp:315 (operator())
   5Bitcoin Core v24.99.0-fa825bd227b9
   6Please report this issue here: https://github.com/bitcoin/bitcoin/issues
   

7. 
   ghost commented at 1:13 pm on December 6, 2022: none

   utACK https://github.com/bitcoin/bitcoin/commit/fa825bd227b9d2bace896a2d29b5ce78bbd4e59c
8. 
   hebasto commented at 1:20 pm on December 6, 2022: member

   Concept ACK.
9. theStack approved
10. 
    theStack commented at 5:19 pm on December 6, 2022: contributor

    ACK fa825bd227b9d2bace896a2d29b5ce78bbd4e59c

    Output diff of the trigger_internal_bug-test between master and PR, once without and once with local changes (files have been created with e.g. ./src/bitcoin-cli -named echo 'arg9=trigger_internal_bug' 2> /tmp/master):

    0diff --git a/tmp/master b/tmp/pr
    1index aa5ae158a..a81a965a8 100644
    2--- a/tmp/master
    3+++ b/tmp/pr
    4@@ -2,5 +2,6 @@ error code: -1
    5 error message:
    6 Internal bug detected: "request.params[9].get_str() != "trigger_internal_bug""
    7 rpc/node.cpp:315 (operator())
    8+Bitcoin Core v24.99.0-fa825bd227b9
    9 Please report this issue here: https://github.com/bitcoin/bitcoin/issues
    

    0diff --git a/tmp/master b/tmp/pr_dirty
    1index aa5ae158a..60598c2e6 100644
    2--- a/tmp/master
    3+++ b/tmp/pr_dirty
    4@@ -2,5 +2,6 @@ error code: -1
    5 error message:
    6 Internal bug detected: "request.params[9].get_str() != "trigger_internal_bug""
    7 rpc/node.cpp:315 (operator())
    8+Bitcoin Core v24.99.0-fa825bd227b9-dirty
    9 Please report this issue here: https://github.com/bitcoin/bitcoin/issues
    

11. john-moffett approved
12. 
    john-moffett commented at 9:34 pm on December 6, 2022: contributor

    ACK fa825bd227b9d2bace896a2d29b5ce78bbd4e59c
13. 
    dergoegge commented at 10:59 pm on December 6, 2022: member

    Concept ACK
14. maflcko merged this on Dec 7, 2022
15. maflcko closed this on Dec 7, 2022

    ---

16. maflcko deleted the branch on Dec 7, 2022
17. sidhujag referenced this in commit aa73f41daf on Dec 8, 2022
18. hebasto referenced this in commit ba8508de10 on Dec 10, 2022
19. hebasto referenced this in commit 1b176d1124 on Dec 12, 2022
20. hebasto referenced this in commit 1370d89b2d on Dec 12, 2022
21. bitcoin locked this on Dec 7, 2023

Contributors
maflcko DrahtBot ghost hebasto theStack john-moffett dergoegge

Labels
Utils/log/libs