This will show the unique id of the full source code when the bug occurred, which can help debugging
util: Include full version id in bug reports #26645
pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2212-full-version-id-🍁 changing 1 files +5 −1-
maflcko commented at 10:16 AM on December 6, 2022: member
-
util: Include full version id in bug reports fa825bd227
-
DrahtBot commented at 10:16 AM on December 6, 2022: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK 1440000bytes, theStack, john-moffett Concept ACK hebasto, dergoegge If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot renamed this:
util: Include full version id in bug reports
util: Include full version id in bug reports
on Dec 6, 2022 - DrahtBot added the label Utils/log/libs on Dec 6, 2022
-
maflcko commented at 10:18 AM on December 6, 2022: member
For example:
$ ./src/bitcoin-cli -named echo 'arg9=trigger_internal_bug' error code: -1 error message: Internal bug detected: "request.params[9].get_str() != "trigger_internal_bug"" rpc/node.cpp:315 (operator()) Bitcoin Core v24.99.0-fa825bd227b9 Please report this issue here: https://github.com/bitcoin/bitcoin/issues -
ghost commented at 1:13 PM on December 6, 2022: none
-
hebasto commented at 1:20 PM on December 6, 2022: member
Concept ACK.
- theStack approved
-
theStack commented at 5:19 PM on December 6, 2022: contributor
ACK fa825bd227b9d2bace896a2d29b5ce78bbd4e59c
Output diff of the
trigger_internal_bug-test between master and PR, once without and once with local changes (files have been created with e.g../src/bitcoin-cli -named echo 'arg9=trigger_internal_bug' 2> /tmp/master):diff --git a/tmp/master b/tmp/pr index aa5ae158a..a81a965a8 100644 --- a/tmp/master +++ b/tmp/pr @@ -2,5 +2,6 @@ error code: -1 error message: Internal bug detected: "request.params[9].get_str() != "trigger_internal_bug"" rpc/node.cpp:315 (operator()) +Bitcoin Core v24.99.0-fa825bd227b9 Please report this issue here: https://github.com/bitcoin/bitcoin/issuesdiff --git a/tmp/master b/tmp/pr_dirty index aa5ae158a..60598c2e6 100644 --- a/tmp/master +++ b/tmp/pr_dirty @@ -2,5 +2,6 @@ error code: -1 error message: Internal bug detected: "request.params[9].get_str() != "trigger_internal_bug"" rpc/node.cpp:315 (operator()) +Bitcoin Core v24.99.0-fa825bd227b9-dirty Please report this issue here: https://github.com/bitcoin/bitcoin/issues - john-moffett approved
-
john-moffett commented at 9:34 PM on December 6, 2022: contributor
ACK fa825bd227b9d2bace896a2d29b5ce78bbd4e59c
-
dergoegge commented at 10:59 PM on December 6, 2022: member
Concept ACK
- maflcko merged this on Dec 7, 2022
- maflcko closed this on Dec 7, 2022
- maflcko deleted the branch on Dec 7, 2022
- sidhujag referenced this in commit aa73f41daf on Dec 8, 2022
- hebasto referenced this in commit ba8508de10 on Dec 10, 2022
- hebasto referenced this in commit 1b176d1124 on Dec 12, 2022
- hebasto referenced this in commit 1370d89b2d on Dec 12, 2022
- bitcoin locked this on Dec 7, 2023
